All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kilian Zinnecker via buildroot <buildroot@buildroot.org>
To: buildroot@buildroot.org
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 0/2] Fix Rock 5B build, broken by gcc 12 warnings
Date: Tue, 08 Aug 2023 22:44:04 +0200	[thread overview]
Message-ID: <1860848.tdWV9SEqCh@kilian-aisec> (raw)
In-Reply-To: <20230808094348.1c7a8650@windsurf>

Hello Thomas, all,

> > Building the image for the Radxa Rock 5B currently breaks: The gcc
> > version was recently changed to version 12 and gcc 12 seems to stop
> > compiling, if certain warnings occur. See the broken build here:
> > 
> > https://gitlab.com/buildroot.org/buildroot/-/jobs/4795673759
> > 
> > This patch series adds two patches from the mainline Linux kernel,
> > which fix two of the warnings. However, also custom code parts of the
> > used custom kernel break due to warnings from gcc 12. The best
> > solution would be to fix those issues as well. However, until they are
> > fixed, the version of gcc used for the Rock 5B is set to the previous
> > version, gcc 11.
> > 
> > Kilian Zinnecker (2):
> >   configs/rock5b: Freeze gcc to version 11
> >   board/radxa/rock5b: Add patches for gcc12 warnings
> 
> I'm not sure to understand the reasoning for the second patch. Does it
> fix all gcc 12.x issues or not? If not, what is the motivation for this
> second patch?

No, the second patch does not fix all gcc 12.x issues. It only fixes two of 
them. I think that fixing two of the warnings for now still is a plus.

> Also: gcc 11.x is currently the oldest version supported by Buildroot,
> it means that as soon as gcc 14.x is released, we will drop support for
> gcc 11.x. So clearly, the solution of sticking to gcc 11.x is not going
> to work for a very long time.

Thanks for the info, I actually would not have known this! I think that the 
best way is to ask the maintainers of the Radxa custom kernel whether they may 
fix the remaining issues, so that the custom kernel compiles with gcc 12.x. I 
intend to do so.

I think both patches should be applied. However, the first patch alone should 
already cause to fix the build itself. (Tbh. I did not test it though.)

Best regards,
Kilian


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-08-08 20:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08  5:01 [Buildroot] [PATCH 0/2] Fix Rock 5B build, broken by gcc 12 warnings Kilian Zinnecker via buildroot
2023-08-08  5:01 ` [Buildroot] [PATCH 1/2] configs/rock5b: Freeze gcc to version 11 Kilian Zinnecker via buildroot
2023-08-08  5:01 ` [Buildroot] [PATCH 2/2] board/radxa/rock5b: Add patches for gcc12 warnings Kilian Zinnecker via buildroot
2023-08-08  7:43 ` [Buildroot] [PATCH 0/2] Fix Rock 5B build, broken by gcc 12 warnings Thomas Petazzoni via buildroot
2023-08-08 20:44   ` Kilian Zinnecker via buildroot [this message]
2023-08-08 21:19     ` Thomas Petazzoni via buildroot
2023-08-09  5:31       ` Kilian Zinnecker via buildroot
2023-08-12  9:36       ` Kilian Zinnecker via buildroot
2023-08-20 15:29   ` Kilian Zinnecker via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1860848.tdWV9SEqCh@kilian-aisec \
    --to=buildroot@buildroot.org \
    --cc=kilian.zinnecker@mail.de \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.