From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v5 1/2] devicetree/bindings: display: Add document for rockchip RGB output Date: Wed, 29 Aug 2018 14:15:04 +0200 Message-ID: <1862757.LMSXp8aoQ6@phil> References: <1535443954-38806-1-git-send-email-hjc@rock-chips.com> <1535443954-38806-2-git-send-email-hjc@rock-chips.com> <2858027f-69f5-57ee-d14a-2f0b329e8e0e@ysoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <2858027f-69f5-57ee-d14a-2f0b329e8e0e@ysoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgTWljaGFsLAoKQW0gRGllbnN0YWcsIDI4LiBBdWd1c3QgMjAxOCwgMTA6MzE6MTUgQ0VTVCBz Y2hyaWViIE1pY2hhbCBWb2vDocSNOgo+IE9uIDI4LjguMjAxOCAxMDoxMiwgU2FuZHkgSHVhbmcg d3JvdGU6Cj4gPiBUaGlzIHBhdGggYWRkIHN1cHBvcnQgcnYxMTA4IGFuZCBweDMwIHJnYiBvdXRw dXQgaW50ZXJmYWNlIGRyaXZlci4KPiAKPiBIaSBTYW5keSwKPiBTZWVtcyBsaWtlIHlvdSBmb3Jn b3QgdG8gYWRkcmVzcyBSb2IncyBjb21tZW50IHJlZ2FyZGluZyB0aGUgImRyaXZlciIgd29yZC4K PiBBbHNvIGZpeCB0aGUgdHlwbzogcy9wYXRoL3BhdGNoCj4gVGhlIHN1YmplY3QgY291bGQgYmUg aW1wcm92ZWQgYXMgd2VsbDogcy9kZXZpY2V0cmVlXC9iaW5kaW5ncy9kdC1iaW5kaW5ncwoKV2Ug YWN0dWFsbHkgaG9ub3JlZCBSb2IncyBiaWdnZXIgY29uY2VybiBvZiB0aGUgcmdiIG91dHB1dCBu b3QgYmVpbmcKYW4gYWN0dWFsIGRldmljZSBiYWNrZWQgYnkgcHJvZ3JhbW1hYmxlIGhhcmR3YXJl IGFuZCBtb3ZlZCB0aGUgcmdiCm91dHB1dCBpbnNpZGUgdGhlIGRyaXZlciwgc2VlIHY3IG9mIHRo ZSBwYXRjaHNldCBbMF0uCgoKSGVpa28KClswXSBodHRwczovL3BhdGNod29yay5mcmVlZGVza3Rv cC5vcmcvcGF0Y2gvMjQ2Mjk3LwpodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0 Y2gvMjQ2Mjk4LwpodHRwczovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvMjQ2Mjk5 LwoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 29 Aug 2018 14:15:04 +0200 Subject: [PATCH v5 1/2] devicetree/bindings: display: Add document for rockchip RGB output In-Reply-To: <2858027f-69f5-57ee-d14a-2f0b329e8e0e@ysoft.com> References: <1535443954-38806-1-git-send-email-hjc@rock-chips.com> <1535443954-38806-2-git-send-email-hjc@rock-chips.com> <2858027f-69f5-57ee-d14a-2f0b329e8e0e@ysoft.com> Message-ID: <1862757.LMSXp8aoQ6@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Michal, Am Dienstag, 28. August 2018, 10:31:15 CEST schrieb Michal Vok??: > On 28.8.2018 10:12, Sandy Huang wrote: > > This path add support rv1108 and px30 rgb output interface driver. > > Hi Sandy, > Seems like you forgot to address Rob's comment regarding the "driver" word. > Also fix the typo: s/path/patch > The subject could be improved as well: s/devicetree\/bindings/dt-bindings We actually honored Rob's bigger concern of the rgb output not being an actual device backed by programmable hardware and moved the rgb output inside the driver, see v7 of the patchset [0]. Heiko [0] https://patchwork.freedesktop.org/patch/246297/ https://patchwork.freedesktop.org/patch/246298/ https://patchwork.freedesktop.org/patch/246299/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D4B6C433F5 for ; Wed, 29 Aug 2018 12:15:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2512A204FD for ; Wed, 29 Aug 2018 12:15:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2512A204FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727871AbeH2QLv convert rfc822-to-8bit (ORCPT ); Wed, 29 Aug 2018 12:11:51 -0400 Received: from gloria.sntech.de ([185.11.138.130]:44002 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727182AbeH2QLv (ORCPT ); Wed, 29 Aug 2018 12:11:51 -0400 Received: from wd0180.dip.tu-dresden.de ([141.76.108.180] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fuzNJ-0001Yz-PZ; Wed, 29 Aug 2018 14:15:05 +0200 From: Heiko Stuebner To: Michal =?utf-8?B?Vm9rw6HEjQ==?= Cc: Sandy Huang , robh@kernel.org, David Airlie , Rob Herring , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/2] devicetree/bindings: display: Add document for rockchip RGB output Date: Wed, 29 Aug 2018 14:15:04 +0200 Message-ID: <1862757.LMSXp8aoQ6@phil> In-Reply-To: <2858027f-69f5-57ee-d14a-2f0b329e8e0e@ysoft.com> References: <1535443954-38806-1-git-send-email-hjc@rock-chips.com> <1535443954-38806-2-git-send-email-hjc@rock-chips.com> <2858027f-69f5-57ee-d14a-2f0b329e8e0e@ysoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, Am Dienstag, 28. August 2018, 10:31:15 CEST schrieb Michal Vokáč: > On 28.8.2018 10:12, Sandy Huang wrote: > > This path add support rv1108 and px30 rgb output interface driver. > > Hi Sandy, > Seems like you forgot to address Rob's comment regarding the "driver" word. > Also fix the typo: s/path/patch > The subject could be improved as well: s/devicetree\/bindings/dt-bindings We actually honored Rob's bigger concern of the rgb output not being an actual device backed by programmable hardware and moved the rgb output inside the driver, see v7 of the patchset [0]. Heiko [0] https://patchwork.freedesktop.org/patch/246297/ https://patchwork.freedesktop.org/patch/246298/ https://patchwork.freedesktop.org/patch/246299/