From: David Woodhouse <dwmw2@infradead.org>
To: John Levon <moz@compsoc.man.ac.uk>
Cc: linux-kernel@vger.kernel.org, alan@redhat.com
Subject: Re: [PATCH] Small kernel-api addition
Date: Thu, 10 May 2001 19:05:05 +0100 [thread overview]
Message-ID: <18661.989517905@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0105101826290.11103-100000@mrbusy.compsoc.man.ac.uk>
In-Reply-To: <Pine.LNX.4.21.0105101826290.11103-100000@mrbusy.compsoc.man.ac.uk>
moz@compsoc.man.ac.uk said:
+ * This macro should be used for accessing values larger in size than single
+ * bytes at locations that may be improperly aligned, e.g. retrieving a u16
+ * value from a location not u16-aligned.
I'd suggest s/that may be/that are expected to be/
If it's _expected_, then by all means use {get,put}_unaligned(). If it's
normally going to be aligned, and it _may_ occasionally be otherwise, let
the common case go fast, and let the fixup handle it otherwise.
--
dwmw2
next prev parent reply other threads:[~2001-05-10 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-10 17:29 [PATCH] Small kernel-api addition John Levon
2001-05-10 18:05 ` David Woodhouse [this message]
2001-05-10 18:38 ` John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18661.989517905@redhat.com \
--to=dwmw2@infradead.org \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=moz@compsoc.man.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.