From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] app/testpmd: fix strcat can overrun fixed-size string Date: Wed, 27 Apr 2016 17:01:06 +0200 Message-ID: <1866947.fZjuAlv0Tu@xps13> References: <1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Tomasz Kulasek Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 25314FE5 for ; Wed, 27 Apr 2016 17:01:10 +0200 (CEST) Received: by mail-wm0-f52.google.com with SMTP id e201so43022141wme.0 for ; Wed, 27 Apr 2016 08:01:10 -0700 (PDT) In-Reply-To: <1460390628-4716-1-git-send-email-tomaszx.kulasek@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-11 18:03, Tomasz Kulasek: > CID 13307 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) > fixed_size_dest: You might overrun the 128 byte fixed-size string fwd_modes > by copying fwd_eng->fwd_mode_name without checking the length. > > Fixes: 769ce6b17835 ("app/testpmd: list forwarding engines") > > Signed-off-by: Tomasz Kulasek Applied, thanks