From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] doc: remove confusing command to send patch
Date: Wed, 11 Oct 2023 10:03:07 +0200 [thread overview]
Message-ID: <1868656.CQOukoFCf9@thomas> (raw)
In-Reply-To: <CAJFAV8w1H+sEMXvp8=TMH_gqpMAPrvDwK_EuhFHxKTx2szM0aA@mail.gmail.com>
11/10/2023 09:30, David Marchand:
> On Tue, Oct 10, 2023 at 6:26 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > In the contributor guide, it was said that no need to Cc maintainers
> > for new additions, probably for new directories not having a maintainer.
> > There is no harm, and it is a good habit, to always Cc maintainers.
> >
> > Remove this case as it can mislead to not Cc maintainers when needed.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> I agree Cc: maintainers should be the default / recommended way of
> sending patches.
>
> Just to convince myself, adding some meson skeleton for a "plop"
> library, adding an entry in the release notes and hooking in
> lib/meson.build:
> $ git show --stat
> doc/guides/rel_notes/release_23_11.rst | 4 ++++
> lib/meson.build | 1 +
> lib/plop/meson.build | 2 ++
>
> $ ./devtools/get-maintainer.sh 0001-new-awesome-library.patch
>
> In this case, it translates to an empty To: list if you follow the
> example command line:
> git send-email --to-cmd ./devtools/get-maintainer.sh --cc
> dev@dpdk.org 000*.patch
>
> We could add a default list of recipients if no maintainer is found by
> the script.
> And the next question is who should be in that list..
Or we can send to dev@dpdk.org, Cc maintainers.
This is what I do:
git send-email --to dev@dpdk.org --cc-cmd devtools/get-maintainer.sh
next prev parent reply other threads:[~2023-10-11 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 16:26 [PATCH] doc: remove confusing command to send patch Thomas Monjalon
2023-10-11 2:04 ` fengchengwen
2023-10-11 7:30 ` David Marchand
2023-10-11 8:03 ` Thomas Monjalon [this message]
2023-10-11 8:30 ` Bruce Richardson
2023-10-11 8:41 ` Ferruh Yigit
2023-10-11 10:20 ` Thomas Monjalon
2023-10-11 10:22 ` Ferruh Yigit
2023-10-11 16:03 ` Thomas Monjalon
2023-10-11 15:52 ` Stephen Hemminger
2023-10-11 16:02 ` Thomas Monjalon
2024-10-07 18:13 ` Stephen Hemminger
2024-11-30 21:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1868656.CQOukoFCf9@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.