From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 05/23] drm: omapdrm: fb: Simplify mode command checks when creating framebuffer Date: Mon, 06 Jun 2016 03:24:55 +0300 Message-ID: <1868781.7NR8S1PBC1@avalon> References: <1461702945-14185-1-git-send-email-laurent.pinchart@ideasonboard.com> <1461702945-14185-6-git-send-email-laurent.pinchart@ideasonboard.com> <5730A97E.6020303@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAB356E0F2 for ; Mon, 6 Jun 2016 00:24:46 +0000 (UTC) In-Reply-To: <5730A97E.6020303@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVG9taSwKCk9uIE1vbmRheSAwOSBNYXkgMjAxNiAxODoxNToxMCBUb21pIFZhbGtlaW5lbiB3 cm90ZToKPiBPbiAyNi8wNC8xNiAyMzozNSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+IENo ZWNrcyBjYW4gYmUgc2ltcGxpZmllZCBiYXNlZCBvbiB0aGUgcmVxdWlyZW1lbnQgdGhhdCBwaXRj aGVzIG11c3QgYmUKPiA+IGlkZW50aWNhbCBmb3IgYWxsIHBsYW5lcy4KPiAKPiBZb3VyIGNvZGUg YWxzbyBwcmVzdW1lcyB0aGVyZSBhcmUgb25seSAxIG9yIDIgcGxhbmVzLCBJIHRoaW5rIHRoYXQK PiBzaG91bGQgYmUgbWVudGlvbmVkIHRvby4KCkknbGwgdXBkYXRlIHRoZSBjb21taXQgbWVzc2Fn ZSBhbmQgYWRkIGEgY29tbWVudCB0byB0aGUgY29kZS4KCj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVy ZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiAtLS0K PiA+IAo+ID4gIGRyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmIuYyB8IDUxICsrKysrKysr KysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0 aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vb21hcGRybS9vbWFwX2ZiLmMKPiA+IGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21h cF9mYi5jIGluZGV4IDAxNWI2YTUwYzU4MS4uODYyOWJhNmZmOWQ3Cj4gPiAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmIuYwo+ID4gKysrIGIvZHJpdmVycy9n cHUvZHJtL29tYXBkcm0vb21hcF9mYi5jCj4gPiBAQCAtNDA3LDYgKzQwNyw3IEBAIHN0cnVjdCBk cm1fZnJhbWVidWZmZXIgKm9tYXBfZnJhbWVidWZmZXJfaW5pdChzdHJ1Y3QKPiA+IGRybV9kZXZp Y2UgKmRldiw+IAo+ID4gIAlzdHJ1Y3Qgb21hcF9mcmFtZWJ1ZmZlciAqb21hcF9mYiA9IE5VTEw7 Cj4gPiAgCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gTlVMTDsKPiA+ICAJY29uc3Qgc3Ry dWN0IGZvcm1hdCAqZm9ybWF0ID0gTlVMTDsKPiA+ICsJdW5zaWduZWQgaW50IHBpdGNoID0gbW9k ZV9jbWQtPnBpdGNoZXNbMF07Cj4gPiAgCWludCByZXQsIGk7Cj4gPiAgCQo+ID4gIAlEQkcoImNy ZWF0ZSBmcmFtZWJ1ZmZlcjogZGV2PSVwLCBtb2RlX2NtZD0lcCAoJWR4JWRAJTQuNHMpIiwKPiA+ IEBAIC00MzcsMzggKzQzOCwzOCBAQCBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpvbWFwX2ZyYW1l YnVmZmVyX2luaXQoc3RydWN0Cj4gPiBkcm1fZGV2aWNlICpkZXYsPiAKPiA+ICAJb21hcF9mYi0+ Zm9ybWF0ID0gZm9ybWF0Owo+ID4gIAltdXRleF9pbml0KCZvbWFwX2ZiLT5sb2NrKTsKPiA+IAo+ ID4gLQlmb3IgKGkgPSAwOyBpIDwgZm9ybWF0LT5udW1fcGxhbmVzOyBpKyspIHsKPiA+IC0JCXN0 cnVjdCBwbGFuZSAqcGxhbmUgPSAmb21hcF9mYi0+cGxhbmVzW2ldOwo+ID4gLQkJaW50IHNpemUs IHBpdGNoID0gbW9kZV9jbWQtPnBpdGNoZXNbaV07Cj4gPiArCWlmIChmb3JtYXQtPm51bV9wbGFu ZXMgPT0gMiAmJiBwaXRjaCAhPSBtb2RlX2NtZC0+cGl0Y2hlc1sxXSkgewo+ID4gKwkJZGV2X2Vy cihkZXYtPmRldiwgInBpdGNoZXMgZGlmZmVyIGJldHdlZW4gcGxhbmVzIDAgYW5kIDFcbiIpOwo+ ID4gKwkJcmV0ID0gLUVJTlZBTDsKPiA+ICsJCWdvdG8gZmFpbDsKPiA+ICsJfQo+ID4gCj4gPiAt CQlpZiAocGl0Y2ggPCAobW9kZV9jbWQtPndpZHRoICogZm9ybWF0LT5zdHJpZGVfYnBwKSkgewo+ ID4gLQkJCWRldl9lcnIoZGV2LT5kZXYsICJwcm92aWRlZCBidWZmZXIgcGl0Y2ggaXMgdG9vIHNt YWxsISAlZCA8IAolZFxuIiwKPiA+IC0JCQkJCXBpdGNoLCBtb2RlX2NtZC0+d2lkdGggKiBmb3Jt YXQtPnN0cmlkZV9icHApOwo+ID4gLQkJCXJldCA9IC1FSU5WQUw7Cj4gPiAtCQkJZ290byBmYWls Owo+ID4gLQkJfQo+ID4gKwlpZiAocGl0Y2ggPCBtb2RlX2NtZC0+d2lkdGggKiBmb3JtYXQtPnN0 cmlkZV9icHApIHsKPiA+ICsJCWRldl9lcnIoZGV2LT5kZXYsCj4gPiArCQkJInByb3ZpZGVkIGJ1 ZmZlciBwaXRjaCBpcyB0b28gc21hbGwhICV1IDwgJXVcbiIsCj4gPiArCQkJcGl0Y2gsIG1vZGVf Y21kLT53aWR0aCAqIGZvcm1hdC0+c3RyaWRlX2JwcCk7Cj4gPiArCQlyZXQgPSAtRUlOVkFMOwo+ ID4gKwkJZ290byBmYWlsOwo+ID4gKwl9Cj4gPiAKPiA+IC0JCWlmIChwaXRjaCAlIGZvcm1hdC0+ c3RyaWRlX2JwcCAhPSAwKSB7Cj4gPiAtCQkJZGV2X2VycihkZXYtPmRldiwKPiA+IC0JCQkJImJ1 ZmZlciBwaXRjaCAoJWQgYnl0ZXMpIGlzIG5vdCBhIG11bHRpcGxlIG9mIHBpeGVsIHNpemUgKCVk Cj4gPiBieXRlcylcbiIsIC0JCQkJcGl0Y2gsIGZvcm1hdC0+c3RyaWRlX2JwcCk7Cj4gPiAtCQkJ cmV0ID0gLUVJTlZBTDsKPiA+IC0JCQlnb3RvIGZhaWw7Cj4gPiAtCQl9Cj4gPiArCWlmIChwaXRj aCAlIGZvcm1hdC0+c3RyaWRlX2JwcCAhPSAwKSB7Cj4gPiArCQlkZXZfZXJyKGRldi0+ZGV2LAo+ ID4gKwkJCSJidWZmZXIgcGl0Y2ggKCV1IGJ5dGVzKSBpcyBub3QgYSBtdWx0aXBsZSBvZiBwaXhl bCBzaXplICgldQo+ID4gYnl0ZXMpXG4iLAo+ID4gKwkJCXBpdGNoLCBmb3JtYXQtPnN0cmlkZV9i cHApOwo+ID4gKwkJcmV0ID0gLUVJTlZBTDsKPiA+ICsJCWdvdG8gZmFpbDsKPiA+ICsJfQo+ID4g Kwo+ID4gKwlmb3IgKGkgPSAwOyBpIDwgZm9ybWF0LT5udW1fcGxhbmVzOyBpKyspIHsKPiA+ICsJ CXN0cnVjdCBwbGFuZSAqcGxhbmUgPSAmb21hcF9mYi0+cGxhbmVzW2ldOwo+ID4gKwkJdW5zaWdu ZWQgaW50IHNpemU7Cj4gPiAKPiA+ICAJCXNpemUgPSBwaXRjaCAqIG1vZGVfY21kLT5oZWlnaHQg LyBmb3JtYXQtPnN1Yl95W2ldOwo+ID4gIAkJCj4gPiAgCQlpZiAoc2l6ZSA+IChvbWFwX2dlbV9t bWFwX3NpemUoYm9zW2ldKSAtIG1vZGVfY21kLT5vZmZzZXRzW2ldKSkgewo+ID4gCj4gPiAtCQkJ ZGV2X2VycihkZXYtPmRldiwgInByb3ZpZGVkIGJ1ZmZlciBvYmplY3QgaXMgdG9vIHNtYWxsISAl ZCA8IAolZFxuIiwKPiA+IC0JCQkJCWJvc1tpXS0+c2l6ZSAtIG1vZGVfY21kLT5vZmZzZXRzW2ld LCBzaXplKTsKPiA+IC0JCQlyZXQgPSAtRUlOVkFMOwo+ID4gLQkJCWdvdG8gZmFpbDsKPiA+IC0J CX0KPiA+IC0KPiA+IC0JCWlmIChpID4gMCAmJiBwaXRjaCAhPSBtb2RlX2NtZC0+cGl0Y2hlc1tp IC0gMV0pIHsKPiA+IAo+ID4gIAkJCWRldl9lcnIoZGV2LT5kZXYsCj4gPiAKPiA+IC0JCQkJInBp dGNoZXMgYXJlIG5vdCB0aGUgc2FtZSBiZXR3ZWVuIGZyYW1lYnVmZmVyIHBsYW5lcyAlZCAhPSAK JWRcbiIsCj4gPiAtCQkJCXBpdGNoLCBtb2RlX2NtZC0+cGl0Y2hlc1tpIC0gMV0pOwo+ID4gKwkJ CQkicHJvdmlkZWQgYnVmZmVyIG9iamVjdCBpcyB0b28gc21hbGwhICVkIDwgJWRcbiIsCj4gPiAr CQkJCWJvc1tpXS0+c2l6ZSAtIG1vZGVfY21kLT5vZmZzZXRzW2ldLCBzaXplKTsKPiA+IAo+ID4g IAkJCXJldCA9IC1FSU5WQUw7Cj4gPiAgCQkJZ290byBmYWlsOwo+ID4gIAkJCj4gPiAgCQl9Cj4g Cj4gU28sIGhtbS4uLiBJIHRoaW5rIHRoZSBjdXJyZW50IGNvZGUgaXMgYWN0dWFsbHkgbm90IHJp Z2h0LCBldmVuIGlmIGl0Cj4gd29ya3MgcmlnaHQ6IEkgdGhpbmsgdGhlIERTUydzIHJlcXVpcmVt ZW50IGlzIGFjdHVhbGx5IHRoYXQgdGhlIHdpZHRoIGluCj4gcGl4ZWxzIGlzIHRoZSBzYW1lIGJl dHdlZW4gcGxhbmVzLCBub3Qgc3RyaWRlLgo+IAo+IEF0IHRoZSBtb21lbnQgdGhlIG9ubHkgdHdv IHBsYW5lIGZvcm1hdCwgTlYxMiwgaGFzIHRoZSBzYW1lIHBpeGVsIHNpemUKPiBmb3IgYm90aCBw bGFuZXMsIGJ1dCBhbiB1cGNvbWluZyBEU1MgbWlnaHQgaGF2ZSBhIGZvcm1hdCB0aGF0IGhhcyBh Cj4gc2VwYXJhdGUgOCBieXRlIEEgcGxhbmUuIEkgZG9uJ3Qga25vdyBpZiB0aGF0IGV2ZXIgcmVh bGl6ZXMgb3IgaWYgd2UKPiB3YW50IHRvIHN1cHBvcnQgdGhlIG1vZGUsIGJ1dCBhZnRlciB0aGlu a2luZyBhYm91dCB0aGlzLCBpdCBtYWtlcyBtb3JlCj4gc2Vuc2UgdGhhdCB0aGUgcGl4ZWwgd2lk dGggaGFzIHRvIGJlIHRoZSBzYW1lIGJldHdlZW4gcGxhbmVzLCBub3QgdGhlCj4gYnl0ZSB3aWR0 aC4KCkdpdmVuIHRoYXQgdGhlIGNvZGUgaXMgY3VycmVudGx5IHdyb25nIGFueXdheSwgaG93IGFi b3V0IGltcGxlbWVudGluZyBjb3JyZWN0IApnZW5lcmljIHN1cHBvcnQgZm9yIGZvcm1hdHMgd2l0 aCBtb3JlIHRoYW4gdHdvIHBsYW5lcyB3aGVuIGhhcmR3YXJlIHN1cHBvcnRpbmcgCnRob3NlIGZv cm1hdHMgYXBwZWFyID8KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==