From: Thomas Monjalon <thomas@monjalon.net>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
viacheslavo@nvidia.com
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Windows port spawn
Date: Thu, 05 Aug 2021 13:38:39 +0200 [thread overview]
Message-ID: <1869435.CJpndI3GeY@thomas> (raw)
In-Reply-To: <20210805095503.23980-1-getelson@nvidia.com>
05/08/2021 11:55, Gregory Etelson:
> mlx5_dev_check_sibling_config() API was updated to allow newly spawned
> port locate existing sibling devices.
> PMD port initialization for Windows OS was not updated for the new
> API prototype.
> The patch fixes mlx5_dev_check_sibling_config call for Windows OS.
>
> Fixes: e9d420dfc2d0 ("net/mlx5: fix find sibling devices")
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Adding the compilation log:
drivers/net/mlx5/windows/mlx5_os.c:457:50: error:
too few arguments to function call, expected 3, have 2
err = mlx5_dev_check_sibling_config(priv, config);
Changing title to "net/mlx5: fix build on Windows"
I missed the original CI failure in patchwork, sorry.
Applied, thanks.
prev parent reply other threads:[~2021-08-05 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 9:55 [dpdk-dev] [PATCH] net/mlx5: fix Windows port spawn Gregory Etelson
2021-08-05 11:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1869435.CJpndI3GeY@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.