From: Nikolay Borisov <nborisov@suse.com>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH] migration/multifd: Remove redundant copy of page offsets during send
Date: Wed, 7 Sep 2022 16:14:58 +0300 [thread overview]
Message-ID: <186ad67d-fb2c-6fc7-e212-71cc209bdcf7@suse.com> (raw)
In-Reply-To: <20220810103942.580784-1-nborisov@suse.com>
On 10.08.22 г. 13:39 ч., Nikolay Borisov wrote:
> All pages which are going to be migrated are first added to
> MultiFDSendParams::MultiFDPages_t::offset array by the main migration
> thread and are subsequently copied to MultiFDSendParams::normal by the
> multifd thread. This is really unnecessary as the MultiFDPages_t is
> guaranteed to be stable since its mutex is being held. Additionally,
> this somewhat simplifies the code as the migration pages are now kept
> in only 1 place during send, also the name 'offset' coupled with the
> context it's being used - usually added to the host pages makes it
> obvious that this is an offset.
>
> With this change normal/normal_num are no longer used in the multifd
> send path.
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Ping
next prev parent reply other threads:[~2022-09-07 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 10:39 [PATCH] migration/multifd: Remove redundant copy of page offsets during send Nikolay Borisov
2022-09-07 13:14 ` Nikolay Borisov [this message]
2022-09-12 8:56 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186ad67d-fb2c-6fc7-e212-71cc209bdcf7@suse.com \
--to=nborisov@suse.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.