From: Ping-Ke Shih <pkshih@realtek.com>
To: Gongwei Li <13875017792@163.com>, Ping-Ke Shih <pkshih@realtek.com>
Cc: Chin-Yen Lee <timlee@realtek.com>, Kalle Valo <kvalo@kernel.org>,
<linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Gongwei Li <ligongwei@kylinos.cn>
Subject: Re: [PATCH] wifi: rtw89: fw: propagate real error code in rtw89_fw_h2c_add_general_pkt()
Date: Tue, 8 Sep 2026 10:48:30 +0800 [thread overview]
Message-ID: <186f8f00-dec5-4159-b7e3-e2c19c05bd21@RTKEXHMBS04.realtek.com.tw> (raw)
In-Reply-To: <20260901093331.3441469-1-13875017792@163.com>
Gongwei Li <13875017792@163.com> wrote:
> From: Gongwei Li <ligongwei@kylinos.cn>
>
> The error path of rtw89_fw_h2c_add_general_pkt() returns -ENOMEM
> unconditionally, which masks the real reason of a failure. In
> particular:
>
> * rtw89_fw_h2c_add_pkt_offload() can fail with -ENOSPC when no more
> packet offload slot is available, or with the error of H2C TX, but
> the callers only see -ENOMEM and get misled when debugging.
>
> * For an unsupported type, the switch default case returns -ENOMEM,
> which is misleading and should be -EINVAL.
>
> Return a real error code instead of -ENOMEM, and use -EINVAL for
> unsupported types.
>
> Fixes: 5c12bb66b79d ("wifi: rtw89: refine packet offload flow")
> Signed-off-by: Gongwei Li <ligongwei@kylinos.cn>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
5469ea5a14aa wifi: rtw89: fw: propagate real error code in rtw89_fw_h2c_add_general_pkt()
---
https://github.com/pkshih/rtw.git
prev parent reply other threads:[~2026-09-08 2:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 9:33 [PATCH] wifi: rtw89: fw: propagate real error code in rtw89_fw_h2c_add_general_pkt() Gongwei Li
2026-09-02 1:32 ` Ping-Ke Shih
2026-09-08 2:48 ` Ping-Ke Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=186f8f00-dec5-4159-b7e3-e2c19c05bd21@RTKEXHMBS04.realtek.com.tw \
--to=pkshih@realtek.com \
--cc=13875017792@163.com \
--cc=kvalo@kernel.org \
--cc=ligongwei@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=timlee@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.