From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/6] ethdev: add a function to look up Rx
	offload names
Date: Wed, 17 Jan 2018 18:33:25 +0100
Message-ID: <1871861.OTzHAPg5Oj@xps>
References: <1515658359-1041-1-git-send-email-arybchenko@solarflare.com>
 <1515658359-1041-2-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 Shahaf Shuler <shahafs@mellanox.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
 Ivan Malov <ivan.malov@oktetlabs.ru>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 9636A1B023
 for <dev@dpdk.org>; Wed, 17 Jan 2018 18:34:00 +0100 (CET)
In-Reply-To: <1515658359-1041-2-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, 2 comments below

11/01/2018 09:12, Andrew Rybchenko:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> 
> +#define	RTE_RX_OFFLOAD_BIT2STR(_name)	\
> +	{ DEV_RX_OFFLOAD_##_name, #_name }
> +
> +static const struct {
> +	uint64_t offload;
> +	const char *name;
> +} rte_rx_offload_names[] = {
> +	RTE_RX_OFFLOAD_BIT2STR(VLAN_STRIP),
> +	RTE_RX_OFFLOAD_BIT2STR(IPV4_CKSUM),
> +	RTE_RX_OFFLOAD_BIT2STR(UDP_CKSUM),
> +	RTE_RX_OFFLOAD_BIT2STR(TCP_CKSUM),
> +	RTE_RX_OFFLOAD_BIT2STR(TCP_LRO),
> +	RTE_RX_OFFLOAD_BIT2STR(QINQ_STRIP),
> +	RTE_RX_OFFLOAD_BIT2STR(OUTER_IPV4_CKSUM),
> +	RTE_RX_OFFLOAD_BIT2STR(MACSEC_STRIP),
> +	RTE_RX_OFFLOAD_BIT2STR(HEADER_SPLIT),
> +	RTE_RX_OFFLOAD_BIT2STR(VLAN_FILTER),
> +	RTE_RX_OFFLOAD_BIT2STR(VLAN_EXTEND),
> +	RTE_RX_OFFLOAD_BIT2STR(JUMBO_FRAME),
> +	RTE_RX_OFFLOAD_BIT2STR(CRC_STRIP),
> +	RTE_RX_OFFLOAD_BIT2STR(SCATTER),
> +	RTE_RX_OFFLOAD_BIT2STR(TIMESTAMP),
> +	RTE_RX_OFFLOAD_BIT2STR(SECURITY),
> +};
> +
> +#undef RTE_RX_OFFLOAD_BIT2STR

Why this undef?

> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -198,6 +198,12 @@ DPDK_17.11 {
>  
>  } DPDK_17.08;
>  
> +DPDK_18.02 {
> +	global:
> +
> +	rte_eth_dev_rx_offload_name;
> +} DPDK_17.11;

New functions should be experimental.

>  EXPERIMENTAL {
>  	global: