From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Cc: dev@dpdk.org, konstantin.ananyev@intel.com
Subject: Re: [PATCH v2] mk: fix acl library static linking
Date: Thu, 30 Jun 2016 18:22:31 +0200 [thread overview]
Message-ID: <1872534.DI0OsGElcv@xps13> (raw)
In-Reply-To: <d1c78bbb-a8fb-25e0-5d68-b4a1b706234a@intel.com>
2016-06-30 17:14, Sergio Gonzalez Monroy:
> On 30/06/2016 17:10, Thomas Monjalon wrote:
> > 2016-06-30 17:01, Sergio Gonzalez Monroy:
> >> --- a/mk/rte.app.mk
> >> +++ b/mk/rte.app.mk
> >> @@ -76,12 +76,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += -lrte_ip_frag
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_METER) += -lrte_meter
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) += -lrte_sched
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_LPM) += -lrte_lpm
> >> -_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_JOBSTATS) += -lrte_jobstats
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_POWER) += -lrte_power
> >>
> >> _LDLIBS-y += --whole-archive
> >>
> >> +# librte_acl needs --whole-archive because of weak functions
> >> +_LDLIBS-$(CONFIG_RTE_LIBRTE_ACL) += -lrte_acl
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_TIMER) += -lrte_timer
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_HASH) += -lrte_hash
> >> _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lrte_vhost
> > I was suggesting to keep -lrte_acl at the same place in the group of
> > algorithms libraries, in order to keep an order satisfying this comment:
> > # Order is important: from higher level to lower level
> >
> > But I have not tested if --whole-archive -lrte_acl --no-whole-archive works.
> >
>
> Sorry, I missed that.
>
> Why is important being before jobstats and power?
It is not.
But I think we need to have some groups.
And ACL is probably at the same layer level as lpm, sched, etc.
next prev parent reply other threads:[~2016-06-30 16:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 11:10 [PATCH] mk: fix acl library static linking Sergio Gonzalez Monroy
2016-06-30 11:38 ` Thomas Monjalon
2016-06-30 12:04 ` Sergio Gonzalez Monroy
2016-06-30 12:44 ` Thomas Monjalon
2016-06-30 14:02 ` Sergio Gonzalez Monroy
2016-06-30 15:24 ` Ananyev, Konstantin
2016-06-30 15:47 ` Thomas Monjalon
2016-06-30 15:28 ` Thomas Monjalon
2016-06-30 15:58 ` Sergio Gonzalez Monroy
2016-06-30 12:14 ` Ananyev, Konstantin
2016-06-30 16:01 ` [PATCH v2] " Sergio Gonzalez Monroy
2016-06-30 16:10 ` Thomas Monjalon
2016-06-30 16:14 ` Sergio Gonzalez Monroy
2016-06-30 16:22 ` Thomas Monjalon [this message]
2016-07-01 8:05 ` Sergio Gonzalez Monroy
2016-07-01 10:05 ` Thomas Monjalon
2016-07-01 10:27 ` Sergio Gonzalez Monroy
2016-07-01 10:39 ` Thomas Monjalon
2016-06-30 16:11 ` [PATCH v3] " Sergio Gonzalez Monroy
2016-07-01 14:38 ` [PATCH v4 1/2] mk: allow duplicate linker flags in libraries list Sergio Gonzalez Monroy
2016-07-01 14:38 ` [PATCH v4 2/2] mk: fix acl library static linking Sergio Gonzalez Monroy
2016-07-01 14:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1872534.DI0OsGElcv@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.