From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] unit/hfp: Fix wrong check
Date: Thu, 30 Oct 2014 10:30:06 +0100 [thread overview]
Message-ID: <1873008.UsSsUcLRsm@leonov> (raw)
In-Reply-To: <1414502688-17686-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Tuesday 28 of October 2014 15:24:48 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> unit/test-hfp.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/unit/test-hfp.c b/unit/test-hfp.c
> index 24ea402..c11a424 100644
> --- a/unit/test-hfp.c
> +++ b/unit/test-hfp.c
> @@ -154,8 +154,7 @@ static gboolean send_pdu(gpointer user_data)
> ssize_t len;
>
> pdu = &context->data->pdu_list[context->pdu_offset++];
> -
> - if (pdu && !pdu->valid)
> + if (!pdu || !pdu->valid)
> return FALSE;
>
> len = write(context->fd_server, pdu->data, pdu->size);
Patch applied after fixing commit prefix, thanks.
--
BR
Szymon Janc
prev parent reply other threads:[~2014-10-30 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 13:24 [PATCH] unit/hfp: Fix wrong check Andrei Emeltchenko
2014-10-30 9:30 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1873008.UsSsUcLRsm@leonov \
--to=szymon.janc@tieto.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.