From: Neil Brown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Steve Dickson <SteveD@redhat.com>,
Chuck Lever <chuck.lever@oracle.com>,
Phil Endecott
<phil_bnaqb_endecott-wZDNlLIRyE5g9hUCZPvPmw@public.gmane.org>,
linux-nfs@vger.kernel.org
Subject: Re: Make sm-notify faster if there are no servers to notify
Date: Fri, 5 Dec 2008 14:34:54 +1100 [thread overview]
Message-ID: <18744.41310.635618.148281@notabene.brown> (raw)
In-Reply-To: message from J. Bruce Fields on Thursday December 4
On Thursday December 4, bfields@fieldses.org wrote:
>
> Any progress on this? I don't think we can release in the current
> state, since as far as I can tell that means on a new system, unless the
> install scripts create /var/lib/nfs/state, neither sm-notify nor statd
> ever writes to /proc/sys/fs/nfs/nsm_local_state, and (without testing)
> it looks to me like that means lockd defaults to a state of 0, which is
> nonsense?
Why is '0' nonsense?
The only real requirement on 'state' is that it changes when the host
reboots while some peer is monitoring it. Even if it got reset to
zero every time the sm and sm.bak became empty it would still work
just fine. If we reboot and find that both sm and sm.bak are empty
there is really no point in changing 'state'.
I think it would still be valuable to replace the 'sync' with two
'fsync's, one of the file, one on the directory.
This may not be a win on ext3 today (I'm not 100% certain about that)
but there are other filesystems and more seem to be coming.
NeilBrown
next prev parent reply other threads:[~2008-12-05 3:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 0:13 Make sm-notify faster if there are no servers to notify Phil Endecott
[not found] ` <1225239200402-YnoLgZYwwYuCbKHnblo0pmrPP3OPMK55cpQHUIT47Ck@public.gmane.org>
2008-10-29 17:18 ` J. Bruce Fields
2008-10-29 17:30 ` Phil Endecott
[not found] ` <1225301403729-YnoLgZYwwYuCbKHnblo0pmrPP3OPMK55cpQHUIT47Ck@public.gmane.org>
2008-10-29 17:37 ` J. Bruce Fields
2008-10-29 17:45 ` Phil Endecott
[not found] ` <1225302305994-YnoLgZYwwYuCbKHnblo0pmrPP3OPMK55cpQHUIT47Ck@public.gmane.org>
2008-10-29 18:41 ` J. Bruce Fields
2008-10-29 20:30 ` Chuck Lever
2008-10-29 21:11 ` J. Bruce Fields
2008-11-09 19:25 ` J. Bruce Fields
2008-11-10 0:52 ` Chuck Lever
2008-11-10 0:55 ` J. Bruce Fields
2008-11-10 1:00 ` Chuck Lever
2008-11-10 9:40 ` Phil Endecott
2008-11-10 13:41 ` Steve Dickson
[not found] ` <49183A12.7010707-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-04 21:10 ` J. Bruce Fields
2008-12-05 3:34 ` Neil Brown [this message]
[not found] ` <18744.41310.635618.148281-wvvUuzkyo1EYVZTmpyfIwg@public.gmane.org>
2008-12-05 3:58 ` J. Bruce Fields
2008-12-05 13:26 ` Steve Dickson
[not found] ` <49392C14.7000709-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-05 16:38 ` J. Bruce Fields
2008-12-05 17:29 ` J. Bruce Fields
2008-12-05 18:41 ` Chuck Lever
2008-12-06 2:42 ` J. Bruce Fields
2008-12-08 19:50 ` Chuck Lever
2008-12-11 22:44 ` J. Bruce Fields
2008-12-05 19:12 ` Steve Dickson
[not found] ` <49397D1B.3000701-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-06 2:49 ` J. Bruce Fields
2008-12-05 18:42 ` Steve Dickson
[not found] ` <4939760A.9050304-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-12-06 3:08 ` J. Bruce Fields
2008-10-31 17:52 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18744.41310.635618.148281@notabene.brown \
--to=neilb@suse.de \
--cc=SteveD@redhat.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=phil_bnaqb_endecott-wZDNlLIRyE5g9hUCZPvPmw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.