From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIpIQ-00010P-LD for mharc-grub-devel@gnu.org; Wed, 25 Aug 2021 05:34:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIpIO-0000zQ-LX for grub-devel@gnu.org; Wed, 25 Aug 2021 05:34:08 -0400 Received: from mout.gmx.net ([212.227.17.22]:55823) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIpIM-0004ww-RS for grub-devel@gnu.org; Wed, 25 Aug 2021 05:34:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1629884043; bh=+X6RDONexp2YNE9UYhEZIPguipBjI00w9J7Zc497JTw=; h=X-UI-Sender-Class:Date:From:To:Subject:Cc:References:In-Reply-To; b=bRCaJcQyP63YGEGF72HetPAvRlxQONOx70ghX3f19RE5dxU+Nj6TOZ2KQsteZGpz4 f0R8ADKgLu1oeeLB9vGZL4sTrd38Vzd5mqt1vk3lJB2BrvXKswgIUtgKyR1EEqZTcf iKHXKQqZvFCfoE/+ChrF7UAgmvvqvx4Ewaw7XOYQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from scdbackup.webframe.org ([84.179.233.243]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M1HZi-1mKSv32usc-002stg for ; Wed, 25 Aug 2021 11:34:03 +0200 Date: Wed, 25 Aug 2021 11:34:47 +0200 From: "Thomas Schmitt" To: grub-devel@gnu.org Subject: Re: [PATCH v2 1/8] tests: Make sure LANG is set properly for iso9660_test Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: development@efficientek.com References: <17ddccb2ea35790b2effaf6bbe7d9acc4628f48c.1629874373.git.development@efficientek.com> In-Reply-To: <17ddccb2ea35790b2effaf6bbe7d9acc4628f48c.1629874373.git.development@efficientek.com> Message-Id: <18749360916363390519@scdbackup.webframe.org> X-Provags-ID: V03:K1:Y5LwX6vFLVuhHiSLw/sinPg9Vg/7weMtVx+ezLaN+OChJmpni3u J4dg7xXFH6L11MRDOD+R5ZuK6M8lLpu4oP0EFFXZtLYdWGhdAnM5UXz1pECv/eKri6vzl64 aoBg8UUr1sWRAi6Rudc2fM8nEHb4PdkZTzSf1Z2RtdIktMiWJIoBN+ojwsplCl6sn5Q4Fhb BVvVuMeyfPO9pJekTUDFQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:V+RCQqXb9lI=:IkUGb6uAQnmXmR2KD1FsiY scfW9bOLBvj26DPNBQNTf/xWLQ6TobJEsi56lb/7alQOtYPiDpvU5JbH6+YUTcmNrhtPDX6L7 P4iRFD7LGaDEjk7gBKrY6yAJlJL9EmRFbBX8rJLdON0IzenJYwfRsgQfgwKtRSeEXIGkLHa1f x4o3w2BaljCox61lG89MqKpE/1nNf801dGsN+1XWUci2obfiBy1oMTBqnbnx0RD/h769cLO+A Z3cAlYhBahn2Ie7jy9zrjUuWsseYTnLTSHyLDFXYfaR1Xa6nc/3kpzEFj4GWsTLp1GAXmKBMg q2lusc0sJVg7UrQCOsa6JpNpP52SOH0AroPpeUvuQSVz+Gmn65z1ImeKJXiQPzOHxIJEpxZHY zb/u9Ty3HJ8rfAobOJp8f1rYxCAxtjOuf9WqXdf/wuwJm2pUEAcHPcK7P/dnjgdPBqp4B/FsB TF6aJ/WqBCX8z4tUL/+SoyzkNN5DljqiqJm/3Vygwjj9k7SOciPSwNyAuHmJSXtm8Qfitg4+f E50voFZD24I1e8FzatzHfQ1IsjQHOX7p86ZnGKTLxQ615l0anQosd7F1vzknopCp7aweexRic +ayYgBO8nGR1G4NdTqUE1huclg+5Uw6L5tq2PwW7emhMJVPxbzotOU9idKOVHuaK76RBEaZ4e onYibYpvfyWBfXUTxWvq1UidClep/pINKiVPgEqiSZydVEi21Nq/lGlG8iedP05PHeFnsG868 XV608nQ6+kE0REg0MQLqz91ZNfza2kwJ8+3lVl/NOS6Hls1kNlXBA1UbGGn9Xzig6NWUNlQ42 uEsM8ZmItuzrHnW4BcDbCacR+h4cDnPdl0b+kJ/PZlwqGZHOn5A20TAT/nu3buU2MsjYZ3Dr+ +SIDc/wG/mhmYZcQX+9zVKOQl//4t2IiOMr0xi4QpD7qAHeAQYgKp+URRnBmIQwPbTdNBMq1k 6U1mzSX1Wbay4YjL4baSlPfI8RZZrqdhQ54ugZJVq4Rj/DWFs+Do80saVZBKUlVxxtOtmw4YG IaP5N2zcKYpucRdEpF0IxkViBuvR59+IHVkLzoDMELa74kLn89bmc2bewBi+pk8cXc9vadP/Y UEAtax/9AV+zfO4ZJmcmVB79pbYpmfpz2RdwNf2u9NupBaONLdHOV3Tvw== Received-SPF: pass client-ip=212.227.17.22; envelope-from=scdbackup@gmx.net; helo=mout.gmx.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2021 09:34:08 -0000 Hi, Glenn Washburn wrote: > LANG must be set to something that supports international characters, > otherwise xorriso will refuse to include the file with name having > international characters, causing the test to fail. Can you tell me the exact error message from xorriso ? I have some difficulties with reproducing the situation. Your description is plausible, because libisofs takes its character set default from nl_langinfo(3) with item CODESET and uses iconv(3) to convert the file names to the output charset. I would like to bring up for discussion an alternative remedy by these xorrisofs options: -input-charset UTF-8 -output-charset UTF-8 =2D---------------------------------------------------------------------- I am quite sure that it will work, but have problems with creating the situation where it shall be the remedy. On a system with configured LANG=3Den_US.UTF-8 i fail to reproduce the issue with LANG=3DC or LANG=3D"" unless i add the explicit demand to convert to UTF-8. My disappointingly unproblematic xorriso test run is ( LANG=3D xorrisofs -o test.iso '=C3=84=C3=96=C3=9C=C3=9F' ) with various attempts to set the locale charset away from UTF-8: LANG, LANGUAGE, LC_ALL set to empty text or to "C". LANG=3D causes nl_langinfo(CODESET) to return "ANSI_X3.4-1968" but iconv(3= ) throws no error when it shall convert "\303\204\303\226\303\234\303\237". I get warning messages if i tell xorriso to aim for output charset UTF-8 while LANG is empty and the file name contains non-ASCII characters: (LANG=3D xorrisofs -o test.iso -output-charset UTF-8 '=C3=84=C3=96=C3=9C= =C3=9F') yields three times libisofs: WARNING : Charset conversion error. Cannot convert =C3=84=C3= =96=C3=9C=C3=9F from ANSI_X3.4-1968 to UTF-8 libisofs: NOTE : > Caused by: Charset conversion error Inspection of test.iso shows that the file name '=C3=84=C3=96=C3=9C=C3=9F'= was defaulted to name '________'. Adding the other charset option (LANG=3D xorrisofs -o test.iso \ -input-charset UTF-8 -output-charset UTF-8 '=C3=84=C3=96=C3=9C= =C3=9F') yields a run without warning messages resulting in Rock Ridge file name '=C3=84=C3=96=C3=9C=C3=9F'. So i assume that my proposal is a valid alternative to setting LANG=3DUTF-= 8. Whether it is preferrable over setting LANG to UTF-8 would have to be discussed. At least it would be nice for me to know why LANG=3D causes trouble in the GRUB tests but not on my command line. (I see nothing in the xorriso runs of tests/util/grub-fs-tester.in which would be equivalent to the run which fails to convert '=C3=84=C3=96=C3=9C= =C3=9F' here.) Have a nice day :) Thomas