From: Thomas Monjalon <thomas@monjalon.net>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: dev@dpdk.org, cristian.dumitrescu@intel.com
Subject: Re: [PATCH] examples/ip_pipeline: fix freebsd build error
Date: Tue, 10 Apr 2018 00:34:14 +0200 [thread overview]
Message-ID: <1876749.P1BhTyUkUM@xps> (raw)
In-Reply-To: <20180409120632.38567-1-jasvinder.singh@intel.com>
09/04/2018 14:06, Jasvinder Singh:
> IP_Pipeline app is not supported in FreeBSD environment. Therefore,
> skip it while building the sample apps on FreeBSD.
>
> Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")
> Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object")
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> --- a/examples/ip_pipeline/Makefile
> +++ b/examples/ip_pipeline/Makefile
> +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp")
> +$(error This application can only operate in a linuxapp environment, \
> +please change the definition of the RTE_TARGET environment variable)
> +endif
It is not skipping the example, just throwing an error (which is needed).
You should add a test in examples/Makefile to really skip it.
next prev parent reply other threads:[~2018-04-09 22:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 12:06 [PATCH] examples/ip_pipeline: fix freebsd build error Jasvinder Singh
2018-04-09 12:58 ` Dumitrescu, Cristian
2018-04-09 22:34 ` Thomas Monjalon [this message]
2018-04-10 9:53 ` Singh, Jasvinder
2018-04-10 9:51 ` [PATCH v2] " Jasvinder Singh
2018-04-10 10:15 ` Thomas Monjalon
2018-04-10 10:25 ` Singh, Jasvinder
2018-04-10 12:19 ` Thomas Monjalon
2018-04-10 12:39 ` Bruce Richardson
2018-04-10 12:40 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2016-10-17 15:48 [PATCH] examples/ip_pipeline: fix freeBSD " Jasvinder Singh
2016-10-18 13:28 ` Dumitrescu, Cristian
2016-10-25 14:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1876749.P1BhTyUkUM@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.