From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 05/10] drm/rcar-du/crc: Implement verify_crc_source callback Date: Thu, 19 Jul 2018 13:56:35 +0300 Message-ID: <1880807.NPALksyAMY@avalon> References: <20180713135942.25061-1-mahesh1.kumar@intel.com> <20180713135942.25061-6-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180713135942.25061-6-mahesh1.kumar@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mahesh Kumar Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTWFoZXNoLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXksIDEzIEp1bHkg MjAxOCAxNjo1OTozNyBFRVNUIE1haGVzaCBLdW1hciB3cm90ZToKPiBUaGlzIHBhdGNoIGltcGxl bWVudHMgInZlcmlmeV9jcmNfc291cmNlIiBjYWxsYmFjayBmdW5jdGlvbiBmb3IKPiByY2FyIGRy bSBkcml2ZXIuCj4gCj4gQ2hhbmdlcyBTaW5jZSBWMToKPiAgLSBhdm9pZCBkdXBsaWNhdGlvbiBv ZiBjb2RlCj4gQ2hhbmdlcyBTaW5jZSBWMjoKPiAgLSBmdXJ0aGVyIG9wdGltaXplIHRoZSBjb2Rl Cj4gCj4gU2lnbmVkLW9mZi1ieTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNv bT4KPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBMYXVyZW50IFBp bmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gUmV2aWV3ZWQtYnk6 IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jIHwgNzEgKysrKysr KysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTEgaW5zZXJ0aW9u cygrKSwgMjAgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9y Y2FyLWR1L3JjYXJfZHVfY3J0Yy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X2NydGMuYyBpbmRleCAxNWRjOWNhYTEyOGIuLmRmYmJhMWFjYzMxZgo+IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMKPiBAQCAtNzU2LDE3ICs3NTYsMTEgQEAgc3Rh dGljIHZvaWQgcmNhcl9kdV9jcnRjX2Rpc2FibGVfdmJsYW5rKHN0cnVjdAo+IGRybV9jcnRjICpj cnRjKSByY3J0Yy0+dmJsYW5rX2VuYWJsZSA9IGZhbHNlOwo+ICB9Cj4gCj4gLXN0YXRpYyBpbnQg cmNhcl9kdV9jcnRjX3NldF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAtCQkJ CSAgICAgICBjb25zdCBjaGFyICpzb3VyY2VfbmFtZSwKPiAtCQkJCSAgICAgICBzaXplX3QgKnZh bHVlc19jbnQpCj4gK3N0YXRpYyBpbnQgcmNhcl9kdV9jcnRjX3BhcnNlX2NyY19zb3VyY2Uoc3Ry dWN0IHJjYXJfZHVfY3J0YyAqcmNydGMsCj4gKwkJCQkJIGNvbnN0IGNoYXIgKnNvdXJjZV9uYW1l LAo+ICsJCQkJCSBlbnVtIHZzcDFfZHVfY3JjX3NvdXJjZSAqcykKCkknZCBuYW1lIHRoZSBwYXJh bWV0ZXIgc291cmNlLCBpdCdzIG1vcmUgZXhwbGljaXQuCgo+ICB7Cj4gLQlzdHJ1Y3QgcmNhcl9k dV9jcnRjICpyY3J0YyA9IHRvX3JjYXJfY3J0YyhjcnRjKTsKPiAtCXN0cnVjdCBkcm1fbW9kZXNl dF9hY3F1aXJlX2N0eCBjdHg7Cj4gLQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7 Cj4gLQlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gLQllbnVtIHZzcDFfZHVfY3Jj X3NvdXJjZSBzb3VyY2U7Cj4gLQl1bnNpZ25lZCBpbnQgaW5kZXggPSAwOwo+IC0JdW5zaWduZWQg aW50IGk7Cj4gKwl1bnNpZ25lZCBpbnQgaW5kZXg7Cj4gIAlpbnQgcmV0Owo+IAo+ICAJLyoKPiBA QCAtNzc0LDMwICs3NjgsNjYgQEAgc3RhdGljIGludCByY2FyX2R1X2NydGNfc2V0X2NyY19zb3Vy Y2Uoc3RydWN0IGRybV9jcnRjCj4gKmNydGMsICogQ1JDIG9uIGFuIGlucHV0IHBsYW5lICgldSBp cyB0aGUgcGxhbmUgSUQpLCBhbmQgImF1dG8iIHRvIGNvbXB1dGUKPiB0aGUgKiBDUkMgb24gdGhl IGNvbXBvc2VyIChWU1ApIG91dHB1dC4KPiAgCSAqLwo+ICsKPiAgCWlmICghc291cmNlX25hbWUp IHsKPiAtCQlzb3VyY2UgPSBWU1AxX0RVX0NSQ19OT05FOwo+ICsJCSpzID0gVlNQMV9EVV9DUkNf Tk9ORTsKPiArCQlyZXR1cm4gMDsKPiAgCX0gZWxzZSBpZiAoIXN0cmNtcChzb3VyY2VfbmFtZSwg ImF1dG8iKSkgewo+IC0JCXNvdXJjZSA9IFZTUDFfRFVfQ1JDX09VVFBVVDsKPiArCQkqcyA9IFZT UDFfRFVfQ1JDX09VVFBVVDsKPiArCQlyZXR1cm4gMDsKPiAgCX0gZWxzZSBpZiAoc3Ryc3RhcnRz KHNvdXJjZV9uYW1lLCAicGxhbmUiKSkgewo+IC0JCXNvdXJjZSA9IFZTUDFfRFVfQ1JDX1BMQU5F Owo+ICsJCXVuc2lnbmVkIGludCBpOwo+ICsKPiArCQkqcyA9IFZTUDFfRFVfQ1JDX1BMQU5FOwo+ IAo+ICAJCXJldCA9IGtzdHJ0b3VpbnQoc291cmNlX25hbWUgKyBzdHJsZW4oInBsYW5lIiksIDEw LCAmaW5kZXgpOwo+ICAJCWlmIChyZXQgPCAwKQo+ICAJCQlyZXR1cm4gcmV0Owo+IAo+IC0JCWZv ciAoaSA9IDA7IGkgPCByY3J0Yy0+dnNwLT5udW1fcGxhbmVzOyArK2kpIHsKPiAtCQkJaWYgKGlu ZGV4ID09IHJjcnRjLT52c3AtPnBsYW5lc1tpXS5wbGFuZS5iYXNlLmlkKSB7Cj4gLQkJCQlpbmRl eCA9IGk7Cj4gLQkJCQlicmVhazsKPiAtCQkJfQo+IC0JCX0KPiArCQlmb3IgKGkgPSAwOyBpIDwg cmNydGMtPnZzcC0+bnVtX3BsYW5lczsgKytpKQo+ICsJCQlpZiAoaW5kZXggPT0gcmNydGMtPnZz cC0+cGxhbmVzW2ldLnBsYW5lLmJhc2UuaWQpCj4gKwkJCQlyZXR1cm4gaTsKClBsZWFzZSB1c2Ug YnJhY2VzIGZvciB0aGUgb3V0ZXIgZm9yIGxvb3AuIEV2ZW4gaWYgbm90IHN0cmljdGx5IHJlcXVp cmVkIGJ5IHRoZSAKQyBsYW5ndWFnZSwgaXQgbWF0Y2hlcyB0aGUgc3R5bGUgb2YgdGhlIGRyaXZl ci4KCj4gIAkJaWYgKGkgPj0gcmNydGMtPnZzcC0+bnVtX3BsYW5lcykKPiAgCQkJcmV0dXJuIC1F SU5WQUw7CgpXb24ndCB0aGlzIGNoZWNrIGFsd2F5cyBiZSB0cnVlID8gWW91IGNhbiByZXR1cm4g LUVJTlZBTCB1bmNvbmRpdGlvbmFsbHkgaGVyZS4KCj4gLQl9IGVsc2Ugewo+ICsJfQo+ICsKPiAr CXJldHVybiAtRUlOVkFMOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHJjYXJfZHVfY3J0Y192ZXJp ZnlfY3JjX3NvdXJjZShzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gKwkJCQkJICBjb25zdCBjaGFy ICpzb3VyY2VfbmFtZSwKPiArCQkJCQkgIHNpemVfdCAqdmFsdWVzX2NudCkKPiArewo+ICsJc3Ry dWN0IHJjYXJfZHVfY3J0YyAqcmNydGMgPSB0b19yY2FyX2NydGMoY3J0Yyk7Cj4gKwllbnVtIHZz cDFfZHVfY3JjX3NvdXJjZSBzb3VyY2U7Cj4gKwo+ICsJaWYgKHJjYXJfZHVfY3J0Y19wYXJzZV9j cmNfc291cmNlKHJjcnRjLCBzb3VyY2VfbmFtZSwgJnNvdXJjZSkgPCAwKSB7Cj4gKwkJRFJNX0RF QlVHX0RSSVZFUigidW5rbm93biBzb3VyY2UgJXNcbiIsIHNvdXJjZV9uYW1lKTsKPiAgCQlyZXR1 cm4gLUVJTlZBTDsKPiAgCX0KPiAKPiArCSp2YWx1ZXNfY250ID0gMTsKPiArCXJldHVybiAwOwo+ ICt9Cj4gKwo+ICtzdGF0aWMgaW50IHJjYXJfZHVfY3J0Y19zZXRfY3JjX3NvdXJjZShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gKwkJCQkgICAgICAgY29uc3QgY2hhciAqc291cmNlX25hbWUsCj4g KwkJCQkgICAgICAgc2l6ZV90ICp2YWx1ZXNfY250KQo+ICt7Cj4gKwlzdHJ1Y3QgcmNhcl9kdV9j cnRjICpyY3J0YyA9IHRvX3JjYXJfY3J0YyhjcnRjKTsKPiArCXN0cnVjdCBkcm1fbW9kZXNldF9h Y3F1aXJlX2N0eCBjdHg7Cj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4g KwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gKwllbnVtIHZzcDFfZHVfY3JjX3Nv dXJjZSBzb3VyY2U7Cj4gKwl1bnNpZ25lZCBpbnQgaW5kZXggPSAwOwoKTm8gbmVlZCB0byBpbml0 aWFsaXplIGluZGV4IHRvIDAuCgpXaXRoIHRob3NlIHNtYWxsIGlzc3VlcyBmaXhlZCwKClJldmll d2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5j b20+Cgo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSByY2FyX2R1X2NydGNfcGFyc2VfY3JjX3Nv dXJjZShyY3J0Yywgc291cmNlX25hbWUsICZzb3VyY2UpOwo+ICsJaWYgKHJldCA8IDApCj4gKwkJ cmV0dXJuIHJldDsKPiArCj4gKwlpbmRleCA9IHJldDsKPiAgCSp2YWx1ZXNfY250ID0gMTsKPiAK PiAgCS8qIFBlcmZvcm0gYW4gYXRvbWljIGNvbW1pdCB0byBzZXQgdGhlIENSQyBzb3VyY2UuICov Cj4gQEAgLTg2MSw2ICs4OTEsNyBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2Z1bmNz IGNydGNfZnVuY3NfZ2VuMyA9IHsKPiAgCS5lbmFibGVfdmJsYW5rID0gcmNhcl9kdV9jcnRjX2Vu YWJsZV92YmxhbmssCj4gIAkuZGlzYWJsZV92YmxhbmsgPSByY2FyX2R1X2NydGNfZGlzYWJsZV92 YmxhbmssCj4gIAkuc2V0X2NyY19zb3VyY2UgPSByY2FyX2R1X2NydGNfc2V0X2NyY19zb3VyY2Us Cj4gKwkudmVyaWZ5X2NyY19zb3VyY2UgPSByY2FyX2R1X2NydGNfdmVyaWZ5X2NyY19zb3VyY2Us Cj4gIH07Cj4gCj4gIC8qCj4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCgotLSAKUmVnYXJkcywKCkxhdXJl bnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==