Re: [PATCH v2 0/6] Various test fixes proposed by Thomas Schmitt - Thomas Schmitt via Grub-devel

From: Thomas Schmitt via Grub-devel <grub-devel@gnu.org>
To: grub-devel@gnu.org
Cc: Thomas Schmitt <scdbackup@gmx.net>, development@efficientek.com
Subject: Re: [PATCH v2 0/6] Various test fixes proposed by Thomas Schmitt
Date: Tue, 04 Mar 2025 10:56:15 +0100	[thread overview]
Message-ID: <18811325313795624465@scdbackup.webframe.org> (raw)
In-Reply-To: <cover.1740988397.git.development@efficientek.com>

Hi,

Tested-by: Thomas Schmitt <scdbackup@gmx.net>

with remaining unrelated problems.

-----------------------------------------------------------------------
Test details:

The patch series applied by "git am" without problems to a branch cloned
from freshly pulled "master".

  make check TESTS=grub_cmd_cryptomount

produces

  # PASS:  1

No remaining files from that run are to see in / and /tmp.
During the "make check" i could see files appear and vanish in /tmp.

Then i ran the full "make check" (which lasts really long on a 4 GHz
Xeon with "top" reporting the system being mostly idle).

These failures did not happen in june 2024, when i ran "make check":

  FAIL: ntfs_test
  FAIL: zfs_test

Other failures which i already had in 2024 are:

  FAIL: hfs_test
  FAIL: luks1_test
  FAIL: luks2_test
  FAIL: grub_func_test

Some tests which failed in 2024 but don't any more:
  PASS: erofs_test
  PASS: exfat_test

(My mail in june 2024 with the list of test failures was
 Date: Thu, 20 Jun 2024 22:05:02 +0200
 Message-Id: <20240620200504.466683-1-scdbackup@gmx.net>
Regrettably http://lists.gnu.org/mailman/listinfo/grub-devel does not
work for me today. So i cannot give a link into the archive.)

Files which remained in /tmp:

  grub-fs-tester.20250304100244880329310.ntfs.JrW
  grub-fs-tester.20250304100732808627445.vfat12.AKi
  grub-fs-tester.20250304102111753946043.zfs_zstd.HeI
  grub-fs-tester.20250304102132560362937.luks1.szH
  grub-fs-tester.20250304102140126776818.luks2.eTV
  tmp.3t4AGcksU8
  tmp.5ch8QxZT6p
  tmp.6msLyaqLuq
  tmp.CeFRqmCNlf
  tmp.m60l7N0wuj

tmp.CeFRqmCNlf looks like a GRUB configuration.
tmp.m60l7N0wuj looks like the result of GRUB's "ls" command, possibly
with a grub-mkrescue ISO in (cd0).
The contents of the others give me no clue.

----------------------------------------------------------------------

I also reviewed the patches.
(Give me a note if i shall add the tags by single mails to the patch
mails.)

> [PATCH v2 1/6] tests/util/grub-shell-luks-tester: Add missing line
>    to create RET variable in cleanup

Reviewed-by: Thomas Schmitt <scdbackup@gmx.net>

> [PATCH v2 2/6] tests: Cleanup generated files on expected failure
>    in grub_cmd_cryptomount

Reviewed-by: Thomas Schmitt <scdbackup@gmx.net>
(Deeply impressed by the "set --" gesture)

> [PATCH v2 3/6] tests/grub_cmd_cryptomount: Cleanup the cryptsetup
>    script unless debug is enabled

Reviewed-by: Thomas Schmitt <scdbackup@gmx.net>

> [PATCH v2 4/6] tests/grub_cmd_cryptomount: Default TMPDIR to /tmp

Reviewed-by: Thomas Schmitt <scdbackup@gmx.net>

> [PATCH v2 5/6] tests/grub_cmd_cryptomount: Remove temporary
>    directories if successful and debug is not on

Signed-off-by: Thomas Schmitt <scdbackup@gmx.net>

> [PATCH v2 6/6] tests/util/grub-shell: Remove the work directory on
>    successful run and debug is not on

(Already contains Signed-off-by: Thomas Schmitt <scdbackup@gmx.net> )

----------------------------------------------------------------------

Have a nice day :)

Thomas

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel