From: Marius Kittler <mkittler@suse.de>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] cgroup: Handle trailing new line in cgroup.controllers
Date: Wed, 25 Oct 2023 13:19:20 +0200 [thread overview]
Message-ID: <1881613.tdWV9SEqCh@linux-9lzf> (raw)
In-Reply-To: <20231025110533.6516-1-rpalethorpe@suse.com>
Am Mittwoch, 25. Oktober 2023, 13:05:33 CEST schrieb Richard Palethorpe via
ltp:
> + switch (ctrl_name[l]) {
> + case '\n': break;
> + case '\0': break;
> + default:
> + tst_brk(TBROK, "Unexpected char in %s: %c", ctrl_name,
ctrl_name[l]);
I'm wondering whether that's a bit too restrictive. Or is there any official
documentation says that you really can only have the letters a-z in cgroup
names (and not even A-Z). Otherwise it might be better to make this just a
warning or allow any printable characters.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-25 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:05 [LTP] [PATCH] cgroup: Handle trailing new line in cgroup.controllers Richard Palethorpe via ltp
2023-10-25 11:19 ` Marius Kittler [this message]
2023-10-25 15:18 ` Petr Vorel
2023-10-26 7:32 ` Richard Palethorpe
2023-10-26 9:34 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1881613.tdWV9SEqCh@linux-9lzf \
--to=mkittler@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.