From: "Charlie Davies" <charles.davies@whitetree.xyz>
To: bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH] bitbake: fetch/git: add support for SRC_URI containing spaces in url
Date: Wed, 16 Sep 2020 14:28:14 -0700 [thread overview]
Message-ID: <18836.1600291694255569397@lists.openembedded.org> (raw)
In-Reply-To: <075098f5e21fc34a925187c6114206af92bbfd78.camel@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
Hi,
I have added some unit tests and submitted v2 of the patch for your consideration.
I added unit tests to test the uri parsing and the removal of spaces in the filepaths. I didn't add a test for the addition of quotes in the git commands. The only method to test this that I could think of is to mock the runfetchmd. This seemed very invasive and looking at the rest of the tests not in keeping with what has been done before. However, I ran a full build of my project overnight and there weren't any issues with the patch applied.
Yes, I agree the purpose of this patch would only be to cope with spaces in the url of a repository.
Do I have to do anything else to have the patch merged into dunfell - if it is accepted - as this is the branch of poky I am working from?
Many Thanks,
Charlie
[-- Attachment #2: Type: text/html, Size: 863 bytes --]
prev parent reply other threads:[~2020-09-16 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 21:12 [PATCH] bitbake: fetch/git: add support for SRC_URI containing spaces in url Charlie Davies
2020-09-16 12:58 ` [bitbake-devel] " Richard Purdie
2020-09-16 21:28 ` Charlie Davies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18836.1600291694255569397@lists.openembedded.org \
--to=charles.davies@whitetree.xyz \
--cc=bitbake-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.