From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 683023D70; Sat, 26 Feb 2022 17:59:22 +0000 (UTC) Received: by mail-wm1-f47.google.com with SMTP id n25-20020a05600c3b9900b00380f41e51e6so3593771wms.2; Sat, 26 Feb 2022 09:59:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9V9Jct16AZTz4K2DeDR/xCDxmdE9Vl1rLYHKFySR8Q8=; b=OS5rKUhE7WXuiZzAYW7cwzYiV8SBfaes2cbt2tE8S+TsEw1AJJ/EtauXm86t/sGGOk 6Gtznw8XzXomN2E/jJX1Ab/F4luPeUHfombr9N4K93wAUclK1Q5xLFFAlq8pEUfN/85P nPPov3wToi44wYltDMShEha7ixTIYA0kQadq5sw8EiEUEo5T+zhVbzoouPd8RuNibsNc vjFiFWeAb1mlzc9ubE77Lg4FPwakw78ykg0kXAEL06cUaWCdknrUlqstev+v2hqB4Zvb eZG3EyajjZ2e4Y+1Akl3IqfS7qbDc7pvcencVFz3EUr+Kn+9K/kb4i0buxEI2YwpKCR9 ZWzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9V9Jct16AZTz4K2DeDR/xCDxmdE9Vl1rLYHKFySR8Q8=; b=v8+Xg1N3yUdtky1DA+vjrfTDfO19hVue66aqdtWt4Hnf6sT571jsfn3q7pmKv1AMDN N1sfKHyLcf/nrrBHwlIFL+XR51hXxxzVGivU4Is9zz7ZraBUDx7temkBd/2wgEk0rYOa U3VwXhw/84uxuBAHAyUC2PuOyOHink8UAUgHsI48X1+0/gyhN3Qo7N/P0U1JSlHm1odr e6mluewgWytQJKLLro5inyqYxnY2W7rJfuqlKzfD3BtUPKqtPsjZupsKkCHDmMklUXzy uhhVittNMzV2Gty4vyk09anVOgQFquOxnaoF1UwW5kd4CbY/SS101J4O9A5OgB8nOqq0 sE7g== X-Gm-Message-State: AOAM531xcYYChhhRJ1iA/kAepmtN+3dqSfUb4eBqRHZHbWloefka06Tm Y0pypqqMUAtPbGaGiHe/f9c= X-Google-Smtp-Source: ABdhPJyTvdvsVl/KFu4YEwlfjU6HwwCb17kFxKDf8UAE6YUZfvMzy4E+dNh/VU3uZpPV3DhazFtIAw== X-Received: by 2002:a05:600c:4281:b0:381:40e5:6cea with SMTP id v1-20020a05600c428100b0038140e56ceamr5143482wmc.151.1645898360547; Sat, 26 Feb 2022 09:59:20 -0800 (PST) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id e15-20020a5d6d0f000000b001ef7dca67fasm3741211wrq.114.2022.02.26.09.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 09:59:20 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jonas@kwiboo.se, nicolas@ndufresne.ca, Benjamin Gaignard Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk, Benjamin Gaignard Subject: Re: Re: [PATCH v3 09/14] media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control Date: Sat, 26 Feb 2022 18:59:18 +0100 Message-ID: <1884298.PYKUYFuaPT@kista> In-Reply-To: <4378293.LvFx2qVVIh@kista> References: <20220225164600.1044663-1-benjamin.gaignard@collabora.com> <20220225164600.1044663-10-benjamin.gaignard@collabora.com> <4378293.LvFx2qVVIh@kista> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Hi! Dne petek, 25. februar 2022 ob 20:30:20 CET je Jernej =C5=A0krabec napisal(= a): > Hi! >=20 > Dne petek, 25. februar 2022 ob 17:45:55 CET je Benjamin Gaignard napisal(= a): > > The number of 'entry point offset' could be very variable. > > Rather than use a large static array define a v4l2 dynamic array > > of integer control. >=20 > I suggest we should be more specific and say U32 (V4L2_CTRL_TYPE_U32). >=20 > > The number of entry point offsets is reported by the elems field. I did few more tests and these are my findings: 1. dynamic array can't be set over size, specified in .dims array 2. entry point offsets are per slice, so if we make slices dynamic array, t= hen=20 entry points would become two dimensional dynamic array 3. num_entry_point_offsets must be part of slice control, because it can be= =20 zero, but size of array can't be 4. fortunately, not setting entry points doesn't impact decoding correctnes= s.=20 This is in line what John told me about them. Hans, can you comment points 1-3? I might misunderstand point 1. In short, it seems like we don't really need entry points, even if they are= =20 used in BSP library. In both cases, I got fluster score 119/138 (10-bit=20 excluded), so we can just drop this patch, although I'm a bit uneasy not=20 setting entry points... Best regards, Jernej > >=20 > > Signed-off-by: Benjamin Gaignard > > --- > > .../userspace-api/media/v4l/ext-ctrls-codec.rst | 9 +++++++++ > > include/media/hevc-ctrls.h | 1 + > > 2 files changed, 10 insertions(+) > >=20 > > diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst = b/ > Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > > index 44a268a948c0..71f7dc1c1ccd 100644 > > --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > > +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst > > @@ -3128,6 +3128,15 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - > > =20 > > \normalsize > > =20 > > +``V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSETS (integer)`` >=20 > Here you have OFFSETS (plural) ... >=20 > > + Specifies the i-th entry point offset in bytes and is represented = by > > + offset_len_minus1 plus 1 bits. >=20 > You probably mean entry_point_offset_minus1? offset_len_minus1 just tells= how=20 > much bits need to be read for each element and it's not important for act= ual=20 > decoding. >=20 > > + This control is a dynamically sized array. The number of entry poi= nt > > + offsets is reported by the ``elems`` field. > > + This bitstream parameter is defined according to :ref:`hevc`. > > + They are described in section 7.4.7.1 "General slice segment header > > + semantics" of the specification. > > + > > ``V4L2_CID_STATELESS_HEVC_SCALING_MATRIX (struct)`` > > Specifies the HEVC scaling matrix parameters used for the scaling= =20 > process > > for transform coefficients. > > diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h > > index 3016c1abb1d0..3f8a67924df3 100644 > > --- a/include/media/hevc-ctrls.h > > +++ b/include/media/hevc-ctrls.h > > @@ -20,6 +20,7 @@ > > #define V4L2_CID_STATELESS_HEVC_DECODE_PARAMS (V4L2_CID_CODEC_BASE +=20 > 1012) > > #define V4L2_CID_STATELESS_HEVC_DECODE_MODE (V4L2_CID_CODEC_BASE +=20 > 1015) > > #define V4L2_CID_STATELESS_HEVC_START_CODE (V4L2_CID_CODEC_BASE +=20 1016) > > +#define V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET (V4L2_CID_CODEC_BAS= E +=20 > 1017) >=20 > ... and here you have OFFSET (singlular). I suggest plural form to be use= d=20 in=20 > all places, including subject line of this commit. >=20 > Additionally, it would be nice if control is initialized, like so: > https://github.com/jernejsk/linux-1/commit/ > f938e162cd8dd77c9f6f1b248d80144840a37bce >=20 > Best regards, > Jernej >=20 > > =20 > > /* enum v4l2_ctrl_type type values */ > > #define V4L2_CTRL_TYPE_HEVC_SPS 0x0120 > > --=20 > > 2.32.0 > >=20 > >=20 >=20 >=20 >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BBC8BC433EF for ; Sat, 26 Feb 2022 18:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pUZfZ0YxYA+MeitLyilugXVWikfTnB9ldYyNvbFCJVc=; b=v59QYLN9cftQHh uUsiFMttrrLKmOBNLbSQcAV4OVkFwe5DOqAjwRPjI1X/5FN3XybM+Lnx/dhWRVAslQvprRQSG/OtE 3vvICKmb8cgVjfgCUQi+pVtyprDKYF10fZ0TVKV3OXYRViAWUDoVaU32tQpx62XMKCgx+9qCsds4g Hrvic/qcXaDR8ve5SGLp1BZhIqOffbh6mlLQ5E8c6O2RYCz6Uj/5Vij/j0PVEoN2KlZmKvbNsapDr AcMARCjjpLIYpcLRqsuAJrjo+s5X1e1svukVHqD6iXBGsFd/0CzgQqgut8ZePOLwJFi3L/zl8PJnw CM47uuuuDwGLVFMDekWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO1Lq-008JkA-Dj; Sat, 26 Feb 2022 17:59:26 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nO1Lm-008Jja-2E for linux-arm-kernel@lists.infradead.org; Sat, 26 Feb 2022 17:59:23 +0000 Received: by mail-wm1-x333.google.com with SMTP id p184-20020a1c29c1000000b0037f76d8b484so3574009wmp.5 for ; Sat, 26 Feb 2022 09:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9V9Jct16AZTz4K2DeDR/xCDxmdE9Vl1rLYHKFySR8Q8=; b=OS5rKUhE7WXuiZzAYW7cwzYiV8SBfaes2cbt2tE8S+TsEw1AJJ/EtauXm86t/sGGOk 6Gtznw8XzXomN2E/jJX1Ab/F4luPeUHfombr9N4K93wAUclK1Q5xLFFAlq8pEUfN/85P nPPov3wToi44wYltDMShEha7ixTIYA0kQadq5sw8EiEUEo5T+zhVbzoouPd8RuNibsNc vjFiFWeAb1mlzc9ubE77Lg4FPwakw78ykg0kXAEL06cUaWCdknrUlqstev+v2hqB4Zvb eZG3EyajjZ2e4Y+1Akl3IqfS7qbDc7pvcencVFz3EUr+Kn+9K/kb4i0buxEI2YwpKCR9 ZWzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9V9Jct16AZTz4K2DeDR/xCDxmdE9Vl1rLYHKFySR8Q8=; b=68HydPO1BKlpkbj4Dxk0FRioDYu6/7lByDqBYJEZvP5rPUuLdFxbUksmdnqPZxqK2H VdVRydv02qaMXTcTxBFEewjieYH/ZajXDda34e6S+aSXHhMQToiY9T4jNqp7kLiaJnfO 9PvapA7r97eCYsLfjyCYGxIxS0Jspe8xjs1frVcblAVs09hM5Ca6v8WmW5Ss1tW6K4re +lhPW/gOQ8WgJGOCvshT5d/RXWsgtqM0K0+0crOz10albEyJq9OtwtN2DmTB/rmLvQXV +oz01vq9qrfVvIEchi1D/hQR6OruKx6aiAp2JhhDS/PjqBILL7yGleyadhNkmG4nbRII T6wg== X-Gm-Message-State: AOAM530729fR9GwyWYZCiHR6cBj0jU8nStp+TO/vX0Lpz5N+v5OhCukB Xf5tn+uoYkINHzskxHMDx7U= X-Google-Smtp-Source: ABdhPJyTvdvsVl/KFu4YEwlfjU6HwwCb17kFxKDf8UAE6YUZfvMzy4E+dNh/VU3uZpPV3DhazFtIAw== X-Received: by 2002:a05:600c:4281:b0:381:40e5:6cea with SMTP id v1-20020a05600c428100b0038140e56ceamr5143482wmc.151.1645898360547; Sat, 26 Feb 2022 09:59:20 -0800 (PST) Received: from kista.localnet (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id e15-20020a5d6d0f000000b001ef7dca67fasm3741211wrq.114.2022.02.26.09.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 09:59:20 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: mchehab@kernel.org, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, jonas@kwiboo.se, nicolas@ndufresne.ca, Benjamin Gaignard Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com, knaerzche@gmail.com, jc@kynesim.co.uk, Benjamin Gaignard Subject: Re: Re: [PATCH v3 09/14] media: uapi: Add V4L2_CID_STATELESS_HEVC_ENTRY_POINT_OFFSET control Date: Sat, 26 Feb 2022 18:59:18 +0100 Message-ID: <1884298.PYKUYFuaPT@kista> In-Reply-To: <4378293.LvFx2qVVIh@kista> References: <20220225164600.1044663-1-benjamin.gaignard@collabora.com> <20220225164600.1044663-10-benjamin.gaignard@collabora.com> <4378293.LvFx2qVVIh@kista> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220226_095922_162095_C81F8C32 X-CRM114-Status: GOOD ( 26.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkhCgpEbmUgcGV0ZWssIDI1LiBmZWJydWFyIDIwMjIgb2IgMjA6MzA6MjAgQ0VUIGplIEplcm5l aiDFoGtyYWJlYyBuYXBpc2FsKGEpOgo+IEhpIQo+IAo+IERuZSBwZXRlaywgMjUuIGZlYnJ1YXIg MjAyMiBvYiAxNzo0NTo1NSBDRVQgamUgQmVuamFtaW4gR2FpZ25hcmQgbmFwaXNhbChhKToKPiA+ IFRoZSBudW1iZXIgb2YgJ2VudHJ5IHBvaW50IG9mZnNldCcgY291bGQgYmUgdmVyeSB2YXJpYWJs ZS4KPiA+IFJhdGhlciB0aGFuIHVzZSBhIGxhcmdlIHN0YXRpYyBhcnJheSBkZWZpbmUgYSB2NGwy IGR5bmFtaWMgYXJyYXkKPiA+IG9mIGludGVnZXIgY29udHJvbC4KPiAKPiBJIHN1Z2dlc3Qgd2Ug c2hvdWxkIGJlIG1vcmUgc3BlY2lmaWMgYW5kIHNheSBVMzIgKFY0TDJfQ1RSTF9UWVBFX1UzMiku Cj4gCj4gPiBUaGUgbnVtYmVyIG9mIGVudHJ5IHBvaW50IG9mZnNldHMgaXMgcmVwb3J0ZWQgYnkg dGhlIGVsZW1zIGZpZWxkLgoKSSBkaWQgZmV3IG1vcmUgdGVzdHMgYW5kIHRoZXNlIGFyZSBteSBm aW5kaW5nczoKMS4gZHluYW1pYyBhcnJheSBjYW4ndCBiZSBzZXQgb3ZlciBzaXplLCBzcGVjaWZp ZWQgaW4gLmRpbXMgYXJyYXkKMi4gZW50cnkgcG9pbnQgb2Zmc2V0cyBhcmUgcGVyIHNsaWNlLCBz byBpZiB3ZSBtYWtlIHNsaWNlcyBkeW5hbWljIGFycmF5LCB0aGVuIAplbnRyeSBwb2ludHMgd291 bGQgYmVjb21lIHR3byBkaW1lbnNpb25hbCBkeW5hbWljIGFycmF5CjMuIG51bV9lbnRyeV9wb2lu dF9vZmZzZXRzIG11c3QgYmUgcGFydCBvZiBzbGljZSBjb250cm9sLCBiZWNhdXNlIGl0IGNhbiBi ZSAKemVybywgYnV0IHNpemUgb2YgYXJyYXkgY2FuJ3QgYmUKNC4gZm9ydHVuYXRlbHksIG5vdCBz ZXR0aW5nIGVudHJ5IHBvaW50cyBkb2Vzbid0IGltcGFjdCBkZWNvZGluZyBjb3JyZWN0bmVzcy4g ClRoaXMgaXMgaW4gbGluZSB3aGF0IEpvaG4gdG9sZCBtZSBhYm91dCB0aGVtLgoKSGFucywgY2Fu IHlvdSBjb21tZW50IHBvaW50cyAxLTM/IEkgbWlnaHQgbWlzdW5kZXJzdGFuZCBwb2ludCAxLgoK SW4gc2hvcnQsIGl0IHNlZW1zIGxpa2Ugd2UgZG9uJ3QgcmVhbGx5IG5lZWQgZW50cnkgcG9pbnRz LCBldmVuIGlmIHRoZXkgYXJlIAp1c2VkIGluIEJTUCBsaWJyYXJ5LiBJbiBib3RoIGNhc2VzLCBJ IGdvdCBmbHVzdGVyIHNjb3JlIDExOS8xMzggKDEwLWJpdCAKZXhjbHVkZWQpLCBzbyB3ZSBjYW4g anVzdCBkcm9wIHRoaXMgcGF0Y2gsIGFsdGhvdWdoIEknbSBhIGJpdCB1bmVhc3kgbm90IApzZXR0 aW5nIGVudHJ5IHBvaW50cy4uLgoKQmVzdCByZWdhcmRzLApKZXJuZWoKCj4gPiAKPiA+IFNpZ25l ZC1vZmYtYnk6IEJlbmphbWluIEdhaWduYXJkIDxiZW5qYW1pbi5nYWlnbmFyZEBjb2xsYWJvcmEu Y29tPgo+ID4gLS0tCj4gPiAgLi4uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1j b2RlYy5yc3QgICAgICAgICAgfCA5ICsrKysrKysrKwo+ID4gIGluY2x1ZGUvbWVkaWEvaGV2Yy1j dHJscy5oICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMSArCj4gPiAgMiBmaWxlcyBj aGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0 aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2RlYy5yc3QgYi8KPiBEb2N1 bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2RlYy5yc3QKPiA+ IGluZGV4IDQ0YTI2OGE5NDhjMC4uNzFmN2RjMWMxY2NkIDEwMDY0NAo+ID4gLS0tIGEvRG9jdW1l bnRhdGlvbi91c2Vyc3BhY2UtYXBpL21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0Cj4gPiAr KysgYi9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1jdHJscy1jb2Rl Yy5yc3QKPiA+IEBAIC0zMTI4LDYgKzMxMjgsMTUgQEAgZW51bSB2NGwyX21wZWdfdmlkZW9faGV2 Y19zaXplX29mX2xlbmd0aF9maWVsZCAtCj4gPiAgCj4gPiAgICAgIFxub3JtYWxzaXplCj4gPiAg Cj4gPiArYGBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19FTlRSWV9QT0lOVF9PRkZTRVRTIChpbnRl Z2VyKWBgCj4gCj4gSGVyZSB5b3UgaGF2ZSBPRkZTRVRTIChwbHVyYWwpIC4uLgo+IAo+ID4gKyAg ICBTcGVjaWZpZXMgdGhlIGktdGggZW50cnkgcG9pbnQgb2Zmc2V0IGluIGJ5dGVzIGFuZCBpcyBy ZXByZXNlbnRlZCBieQo+ID4gKyAgICBvZmZzZXRfbGVuX21pbnVzMSBwbHVzIDEgYml0cy4KPiAK PiBZb3UgcHJvYmFibHkgbWVhbiBlbnRyeV9wb2ludF9vZmZzZXRfbWludXMxPyBvZmZzZXRfbGVu X21pbnVzMSBqdXN0IHRlbGxzIGhvdyAKPiBtdWNoIGJpdHMgbmVlZCB0byBiZSByZWFkIGZvciBl YWNoIGVsZW1lbnQgYW5kIGl0J3Mgbm90IGltcG9ydGFudCBmb3IgYWN0dWFsIAo+IGRlY29kaW5n Lgo+IAo+ID4gKyAgICBUaGlzIGNvbnRyb2wgaXMgYSBkeW5hbWljYWxseSBzaXplZCBhcnJheS4g VGhlIG51bWJlciBvZiBlbnRyeSBwb2ludAo+ID4gKyAgICBvZmZzZXRzIGlzIHJlcG9ydGVkIGJ5 IHRoZSBgYGVsZW1zYGAgZmllbGQuCj4gPiArICAgIFRoaXMgYml0c3RyZWFtIHBhcmFtZXRlciBp cyBkZWZpbmVkIGFjY29yZGluZyB0byA6cmVmOmBoZXZjYC4KPiA+ICsgICAgVGhleSBhcmUgZGVz Y3JpYmVkIGluIHNlY3Rpb24gNy40LjcuMSAiR2VuZXJhbCBzbGljZSBzZWdtZW50IGhlYWRlcgo+ ID4gKyAgICBzZW1hbnRpY3MiIG9mIHRoZSBzcGVjaWZpY2F0aW9uLgo+ID4gKwo+ID4gIGBgVjRM Ml9DSURfU1RBVEVMRVNTX0hFVkNfU0NBTElOR19NQVRSSVggKHN0cnVjdClgYAo+ID4gICAgICBT cGVjaWZpZXMgdGhlIEhFVkMgc2NhbGluZyBtYXRyaXggcGFyYW1ldGVycyB1c2VkIGZvciB0aGUg c2NhbGluZyAKPiBwcm9jZXNzCj4gPiAgICAgIGZvciB0cmFuc2Zvcm0gY29lZmZpY2llbnRzLgo+ ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbWVkaWEvaGV2Yy1jdHJscy5oIGIvaW5jbHVkZS9tZWRp YS9oZXZjLWN0cmxzLmgKPiA+IGluZGV4IDMwMTZjMWFiYjFkMC4uM2Y4YTY3OTI0ZGYzIDEwMDY0 NAo+ID4gLS0tIGEvaW5jbHVkZS9tZWRpYS9oZXZjLWN0cmxzLmgKPiA+ICsrKyBiL2luY2x1ZGUv bWVkaWEvaGV2Yy1jdHJscy5oCj4gPiBAQCAtMjAsNiArMjAsNyBAQAo+ID4gICNkZWZpbmUgVjRM Ml9DSURfU1RBVEVMRVNTX0hFVkNfREVDT0RFX1BBUkFNUwkoVjRMMl9DSURfQ09ERUNfQkFTRSAr IAo+IDEwMTIpCj4gPiAgI2RlZmluZSBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19ERUNPREVfTU9E RQkoVjRMMl9DSURfQ09ERUNfQkFTRSArIAo+IDEwMTUpCj4gPiAgI2RlZmluZSBWNEwyX0NJRF9T VEFURUxFU1NfSEVWQ19TVEFSVF9DT0RFCShWNEwyX0NJRF9DT0RFQ19CQVNFICsgCjEwMTYpCj4g PiArI2RlZmluZSBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19FTlRSWV9QT0lOVF9PRkZTRVQgKFY0 TDJfQ0lEX0NPREVDX0JBU0UgKyAKPiAxMDE3KQo+IAo+IC4uLiBhbmQgaGVyZSB5b3UgaGF2ZSBP RkZTRVQgKHNpbmdsdWxhcikuIEkgc3VnZ2VzdCBwbHVyYWwgZm9ybSB0byBiZSB1c2VkIAppbiAK PiBhbGwgcGxhY2VzLCBpbmNsdWRpbmcgc3ViamVjdCBsaW5lIG9mIHRoaXMgY29tbWl0Lgo+IAo+ IEFkZGl0aW9uYWxseSwgaXQgd291bGQgYmUgbmljZSBpZiBjb250cm9sIGlzIGluaXRpYWxpemVk LCBsaWtlIHNvOgo+IGh0dHBzOi8vZ2l0aHViLmNvbS9qZXJuZWpzay9saW51eC0xL2NvbW1pdC8K PiBmOTM4ZTE2MmNkOGRkNzdjOWY2ZjFiMjQ4ZDgwMTQ0ODQwYTM3YmNlCj4gCj4gQmVzdCByZWdh cmRzLAo+IEplcm5lago+IAo+ID4gIAo+ID4gIC8qIGVudW0gdjRsMl9jdHJsX3R5cGUgdHlwZSB2 YWx1ZXMgKi8KPiA+ICAjZGVmaW5lIFY0TDJfQ1RSTF9UWVBFX0hFVkNfU1BTIDB4MDEyMAo+ID4g LS0gCj4gPiAyLjMyLjAKPiA+IAo+ID4gCj4gCj4gCj4gCgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK