From: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
To: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>,
Kalle Valo <kvalo@kernel.org>, Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] wifi: ath12k: eliminate redundant debug mask check in ath12k_dbg()
Date: Tue, 4 Feb 2025 13:05:10 +0530 [thread overview]
Message-ID: <18856414-c05b-a737-5567-e8669b2349a0@oss.qualcomm.com> (raw)
In-Reply-To: <20250204-unlink_link_arvif_from_chanctx-v1-1-675bd4cea339@oss.qualcomm.com>
On 2/4/2025 9:53 AM, Aditya Kumar Singh wrote:
> The current implementation includes a debug mask check both in the macro
> expansion and in the function __ath12k_dbg(), which is unnecessary.
>
> Simplify the code by removing the redundant check from the helper function
> __ath12k_dbg().
>
> While at this, rename the first argument in macro from ar to ab since the
> first argument name in the function __ath12k_dbg() is ab.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: Aditya Kumar Singh <aditya.kumar.singh@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
next prev parent reply other threads:[~2025-02-04 7:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 4:23 [PATCH 0/8] wifi: ath12k: handle change_vif_links() callback Aditya Kumar Singh
2025-02-04 4:23 ` [PATCH 1/8] wifi: ath12k: eliminate redundant debug mask check in ath12k_dbg() Aditya Kumar Singh
2025-02-04 7:35 ` Vasanthakumar Thiagarajan [this message]
2025-02-04 4:23 ` [PATCH 2/8] wifi: ath12k: introduce ath12k_generic_dbg() Aditya Kumar Singh
2025-02-04 7:35 ` Vasanthakumar Thiagarajan
2025-02-04 4:23 ` [PATCH 3/8] wifi: ath12k: remove redundant vif settings during link interface creation Aditya Kumar Singh
2025-02-04 7:35 ` Vasanthakumar Thiagarajan
2025-02-04 4:23 ` [PATCH 4/8] wifi: ath12k: remove redundant logic for initializing arvif Aditya Kumar Singh
2025-02-04 7:35 ` Vasanthakumar Thiagarajan
2025-02-04 4:23 ` [PATCH 5/8] wifi: ath12k: use arvif instead of link_conf in ath12k_mac_set_key() Aditya Kumar Singh
2025-02-04 7:36 ` Vasanthakumar Thiagarajan
2025-02-04 4:23 ` [PATCH 6/8] wifi: ath12k: relocate a few functions in mac.c Aditya Kumar Singh
2025-02-04 7:36 ` Vasanthakumar Thiagarajan
2025-02-04 4:23 ` [PATCH 7/8] wifi: ath12k: allocate new links in change_vif_links() Aditya Kumar Singh
2025-02-04 7:36 ` Vasanthakumar Thiagarajan
2025-02-04 4:23 ` [PATCH 8/8] wifi: ath12k: handle link removal " Aditya Kumar Singh
2025-02-04 7:37 ` Vasanthakumar Thiagarajan
2025-02-04 10:02 ` [PATCH 0/8] wifi: ath12k: handle change_vif_links() callback Nicolas Escande
2025-02-04 10:23 ` Aditya Kumar Singh
2025-02-04 10:44 ` Nicolas Escande
2025-02-04 17:19 ` Aditya Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18856414-c05b-a737-5567-e8669b2349a0@oss.qualcomm.com \
--to=vasanthakumar.thiagarajan@oss.qualcomm.com \
--cc=aditya.kumar.singh@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.