All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: u-boot@lists.denx.de
Subject: [PATCH v2 0/3] sunxi: OrangePi Zero 2: Ethernet support
Date: Thu, 28 Jan 2021 17:16:42 +0100	[thread overview]
Message-ID: <1886239.ufdBqgdUVp@kista> (raw)
In-Reply-To: <20210127010638.10713-1-andre.przywara@arm.com>

Dne sreda, 27. januar 2021 ob 02:06:35 CET je Andre Przywara napisal(a):
> The first two patches prepare the sun8i-emac driver to deal with the
> EMAC as integrated into the H616 SoC. This IP block is compatible with
> the A64 version, but the current driver prevents us from using that:
> - The EPHY syscon register needs to have a bit cleared to select the
>   external PHY. On the A64 it is cleared on reset, but we should not
>   rely on that. The Linux driver does so as well. Fixed in patch 1/3.
> - The pinmux setting is tied to the compatible string, but the H616
>   requires a different value. Fixed in patch 2/3.
> 
> The final patch enables Ethernet support for the OrangePi Zero 2 board,
> which now works without further ado.

This is cleaner and works for me, so for the whole series:
Tested-by: Jernej Skrabec <jernej.skrabec@siol.net>
Reviewed-by: Jernej Skrabec <jernej.skrabec@siol.net>

Thanks!

Best regards,
Jernej

> 
> Cheers,
> Andre
> 
> Andre Przywara (3):
>   net: sun8i-emac: Always clear syscon EPHY register
>   net: sun8i-emac: Determine pinmux based on SoC, not EMAC type
>   sunxi: OrangePi Zero 2: Enable Ethernet
> 
>  configs/orangepi_zero2_defconfig |  2 ++
>  drivers/net/sun8i_emac.c         | 59 ++++++++++++++++++--------------
>  2 files changed, 35 insertions(+), 26 deletions(-)
> 
> -- 
> 2.17.5
> 
> 

      parent reply	other threads:[~2021-01-28 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  1:06 [PATCH v2 0/3] sunxi: OrangePi Zero 2: Ethernet support Andre Przywara
2021-01-27  1:06 ` [PATCH v2 1/3] net: sun8i-emac: Always clear syscon EPHY register Andre Przywara
2021-01-27  1:06 ` [PATCH v2 2/3] net: sun8i-emac: Determine pinmux based on SoC, not EMAC type Andre Przywara
2021-01-27  1:06 ` [PATCH v2 3/3] sunxi: OrangePi Zero 2: Enable Ethernet Andre Przywara
2021-01-28 16:16 ` Jernej Škrabec [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1886239.ufdBqgdUVp@kista \
    --to=jernej.skrabec@siol.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.