From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Zhang, Helin" <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2 00/27] Add i40e PMD support
Date: Wed, 18 Jun 2014 11:23:55 +0200 [thread overview]
Message-ID: <1886490.uKY7E5th3Z@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A74457A-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 08:51, Zhang, Helin:
> Thomas Monjalon:
> > Some things could be cleaned up later, especially i40e specific flags in
> > generic API must be removed. Please work on a patch for next release.
>
> Btw, what do you mean the i40e specific flags in generic API? Did you mean
> the new flags defined in rte_mbuf.h? Yes, we are working on some bug fixes
> and enhancements which might need to be added in the next release.
I mean that RSS flags are really Intel-specific. In case other NIC vendors
would use this RSS API, it can be a problem to address. But we can wait for
this one.
About mbuf flags, they are all zeros and useless. So a patch is needed to get
some space and define new values (as you already explained).
And last but not the least, RTE_LIBRTE_I40E_16BYTE_RX_DESC handling is very
strange as it can be seen in this commit:
http://dpdk.org/browse/dpdk/commit/?id=ac2ece3fb1f5511
--
Thomas
next prev parent reply other threads:[~2014-06-18 9:23 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 5:08 [PATCH v2 00/27] Add i40e PMD support Helin Zhang
[not found] ` <1401944951-23783-1-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-05 5:08 ` [PATCH v2 01/27] i40e: add basic shared code Helin Zhang
2014-06-05 5:08 ` [PATCH v2 02/27] i40e: add PMD source files Helin Zhang
2014-06-05 5:08 ` [PATCH v2 03/27] pci: add macros and pci device IDs to support i40e Helin Zhang
2014-06-05 5:08 ` [PATCH v2 04/27] igb_uio: add i40e support Helin Zhang
2014-06-05 5:08 ` [PATCH v2 05/27] mbuf: add new packet flags for i40e Helin Zhang
[not found] ` <1401944951-23783-6-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-05 15:30 ` Stephen Hemminger
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A735ACB@SHSMSX104.ccr.corp.intel.com>
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A735ACB-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-12 1:38 ` Zhang, Helin
2014-06-05 5:08 ` [PATCH v2 06/27] ethdev: add i40e support Helin Zhang
2014-06-05 5:08 ` [PATCH v2 07/27] ethdev: support setting maximum packet length to less than 1518 Helin Zhang
2014-06-05 5:08 ` [PATCH v2 08/27] vmxnet3: enlarge the hash flags of RSS to 64 bits Helin Zhang
2014-06-05 5:08 ` [PATCH v2 09/27] ixgbe: " Helin Zhang
2014-06-05 5:08 ` [PATCH v2 10/27] igb: " Helin Zhang
2014-06-05 5:08 ` [PATCH v2 11/27] mk: add i40e support Helin Zhang
2014-06-05 5:08 ` [PATCH v2 12/27] config: add configurations for i40e Helin Zhang
2014-06-05 5:08 ` [PATCH v2 13/27] app/test-pmd: support displaying 32 bytes RX descriptors Helin Zhang
2014-06-05 5:08 ` [PATCH v2 14/27] app/test-pmd: add command of 'tx_vlan set pvid port_id vlan_id (on|off)' Helin Zhang
2014-06-05 5:08 ` [PATCH v2 15/27] app/testpmd: enlarge the hash flags of RSS to 64 bits Helin Zhang
2014-06-05 5:09 ` [PATCH v2 16/27] app/test-pmd: add L3 packet type in offload flags Helin Zhang
2014-06-05 5:09 ` [PATCH v2 17/27] examples/dpdk_qat: use ETH_RSS_IP to replace IP hash flags of RSS Helin Zhang
2014-06-05 5:09 ` [PATCH v2 18/27] examples/ip_reassembly: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 19/27] examples/l3fwd-power: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 20/27] examples/l3fwd-vf: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 21/27] examples/l3fwd: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 22/27] examples/load_balancer: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 23/27] examples/multi_process: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 24/27] examples/qos_meter: " Helin Zhang
2014-06-05 5:09 ` [PATCH v2 25/27] igb_uio: add sys files to read/write specific bits in pci config space Helin Zhang
2014-06-05 5:09 ` [PATCH v2 26/27] pci: support reading/writing sys files of 'extended_tag' and 'max_read_request_size' Helin Zhang
2014-06-05 5:09 ` [PATCH v2 27/27] config: add configurations for enabling 'Extended Tag' or resetting 'Max Read Request Size' Helin Zhang
2014-06-05 8:36 ` [PATCH v2 00/27] Add i40e PMD support Zhu, Heqing
2014-06-17 16:27 ` Thomas Monjalon
2014-06-18 8:51 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A74457A-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-18 9:23 ` Thomas Monjalon [this message]
2014-06-19 6:24 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1886490.uKY7E5th3Z@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.