From: GitHub issues - opened <github@alsa-project.org>
To: alsa-devel@alsa-project.org
Subject: snd_seq_drain_output change breaks existing code.
Date: Tue, 13 Jan 2026 01:28:22 +0100 (CET) [thread overview]
Message-ID: <188a22d3b63fcc00-webhooks-bot@alsa-project.org> (raw)
In-Reply-To: <188a22d3b514b800-webhooks-bot@alsa-project.org>
alsa-project/alsa-lib issue #493 was opened from Hoosier-Beagler:
The little gem shown below has broken a lot of code. Previously, no positive results were returned and software relied on -EAGAIN to detect remaining data. That result is no longer returned if some data was processed. This has broken the old and stable version of my application written in C(++) which is no longer being maintained. I have ported my app to python but this change has also broken public python wrappers for the alsa library. In [alsa-python / pyalsa / alsaseq.c](https://github.com/alsa-project/alsa-python/blob/master/pyalsa/alsaseq.c) below line 2800 and also [python-alsa-midi / alsa_midi / client.py](https://github.com/Jajcus/python-alsa-midi/blob/main/alsa_midi/client.py) at line 626 and possibly the sub-classes as well (lines 1679, 1871). None of these wrappers expected a valid return value and do not pass along said value returned from the c library call.
```
--- alsa-lib-1.2.14/src/seq/seq.c 2025-04-14 11:42:04.000000000 -0500
+++ alsa-lib-1.2.15.2/src/seq/seq.c 2026-01-08 08:27:57.000000000 -0600
@@ -4445,21 +4445,22 @@
int snd_seq_drain_output(snd_seq_t *seq)
{
ssize_t result, processed = 0;
assert(seq);
while (seq->obufused > 0) {
result = seq->ops->write(seq, seq->obuf, seq->obufused);
if (result < 0) {
- if (result == -EAGAIN && processed)
+ if (result == -EAGAIN && processed > 0)
return seq->obufused;
return result;
}
if ((size_t)result < seq->obufused)
memmove(seq->obuf, seq->obuf + result, seq->obufused - result);
seq->obufused -= result;
+ processed += result;
}
return 0;
}
/**
* \brief extract the first event in output buffer
* \param seq sequencer handle
```
Issue URL : https://github.com/alsa-project/alsa-lib/issues/493
Repository URL: https://github.com/alsa-project/alsa-lib
next parent reply other threads:[~2026-01-13 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <188a22d3b514b800-webhooks-bot@alsa-project.org>
2026-01-13 0:28 ` GitHub issues - opened [this message]
[not found] <188a23611a73cd00-webhooks-bot@alsa-project.org>
2026-01-13 0:38 ` snd_seq_drain_output change breaks existing code GitHub issues - edited
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=188a22d3b63fcc00-webhooks-bot@alsa-project.org \
--to=github@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.