From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Mon, 5 Mar 2018 14:00:48 -0500 (EST) Subject: [Cluster-devel] [PATCH 17/20] libgfs2: Don't use buffer_heads in gfs2_log_descriptor_{in, out} In-Reply-To: <20180305182549.17817-18-anprice@redhat.com> References: <20180305182549.17817-1-anprice@redhat.com> <20180305182549.17817-18-anprice@redhat.com> Message-ID: <1890018040.7997557.1520276448893.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | Signed-off-by: Andrew Price | --- | gfs2/edit/gfs2hex.c | 2 +- | gfs2/edit/journal.c | 21 +++++++++------------ | gfs2/libgfs2/libgfs2.h | 6 ++---- | gfs2/libgfs2/ondisk.c | 15 ++++++--------- | 4 files changed, 18 insertions(+), 26 deletions(-) | +extern void gfs2_log_descriptor_out(struct gfs2_log_descriptor *ld, char | *buf); Hm. Looks like gfs2_log_descriptor_out isn't used by any of the utils. We went through a phase where we tried to trim down libgfs2 in favor of moving functions like this to the gfs2-util that uses it, in cases where only one tool used it. Perhaps we should get rid of it altogether? Unless you want to keep it in case third party tools link it in. Regards, Bob