From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header Date: Wed, 26 Dec 2018 11:40:23 +0200 Message-ID: <1891132.39bZHgSTRL@avalon> References: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 950866E6FC for ; Wed, 26 Dec 2018 09:39:30 +0000 (UTC) In-Reply-To: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Brajeswar Ghosh Cc: sabyasachi.linux@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, jrdr.linux@gmail.com List-Id: dri-devel@lists.freedesktop.org SGkgQnJhamVzd2FyLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBNb25kYXksIDI0IERl Y2VtYmVyIDIwMTggMTY6MzI6MTggRUVUIEJyYWplc3dhciBHaG9zaCB3cm90ZToKPiBSZW1vdmUg ZHJtL2RybV9wYW5lbC5oIHdoaWNoIGlzIGluY2x1ZGVkIG1vcmUgdGhhbiBvbmNlCj4gCj4gU2ln bmVkLW9mZi1ieTogQnJhamVzd2FyIEdob3NoIDxicmFqZXN3YXIubGludXhAZ21haWwuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BhbmVsLmMgfCAxIC0KPiAgMSBmaWxlIGNo YW5nZWQsIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2Jy aWRnZS9wYW5lbC5jIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9wYW5lbC5jCj4gaW5kZXggN2Ni YWJhMjEzZWY2Li40MDJiMzE4ZWVlYjIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2Jy aWRnZS9wYW5lbC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9wYW5lbC5jCj4gQEAg LTE1LDcgKzE1LDYgQEAKPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxwZXIuaD4KPiAgI2lu Y2x1ZGUgPGRybS9kcm1fZW5jb2Rlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9tb2Rlc2V0X2hl bHBlcl92dGFibGVzLmg+Cj4gLSNpbmNsdWRlIDxkcm0vZHJtX3BhbmVsLmg+CgpXaGlsZSBhdCBp dCwgaG93IGFib3V0IHNvcnRpbmcgaGVhZGVycyBhbHBoYWJldGljYWxseSB0byBtYWtlIHN1cmUg dGhpcyB3b24ndCAKaGFwcGVuIGFnYWluID8KCldpdGggdGhhdCBjaGFuZ2UsCgpSZXZpZXdlZC1i eTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoK PiAgc3RydWN0IHBhbmVsX2JyaWRnZSB7Cj4gIAlzdHJ1Y3QgZHJtX2JyaWRnZSBicmlkZ2U7Cgot LSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA2FC43387 for ; Wed, 26 Dec 2018 09:39:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF7442148D for ; Wed, 26 Dec 2018 09:39:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="BqcbYpBF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726393AbeLZJja (ORCPT ); Wed, 26 Dec 2018 04:39:30 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:34180 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726013AbeLZJja (ORCPT ); Wed, 26 Dec 2018 04:39:30 -0500 Received: from avalon.localnet (unknown [91.182.109.47]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0675C53D; Wed, 26 Dec 2018 10:39:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1545817168; bh=ADEi63n9BJkQtWF+CVL7tlbAxH8U0Ji3rriPytkCzaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BqcbYpBFXEo035pbXn0UdhVqtNZfLG4+3OsgyEmj7tg7izQpRF4KvBD/xb/R67ReQ zYAeMwPJ8Tu1gD5riXvg1KxnsMnJ+e6xe7jgP4RS9Z6rUmJiBG8IRVqO9XrQDs4C0I CWXSLwDDv/1D0tef3Gb8ZGMUVx5W7+IUHckXJbPw= From: Laurent Pinchart To: Brajeswar Ghosh Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, jrdr.linux@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, sabyasachi.linux@gmail.com Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header Date: Wed, 26 Dec 2018 11:40:23 +0200 Message-ID: <1891132.39bZHgSTRL@avalon> Organization: Ideas on Board Oy In-Reply-To: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar> References: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brajeswar, Thank you for the patch. On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote: > Remove drm/drm_panel.h which is included more than once > > Signed-off-by: Brajeswar Ghosh > --- > drivers/gpu/drm/bridge/panel.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index 7cbaba213ef6..402b318eeeb2 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -15,7 +15,6 @@ > #include > #include > #include > -#include While at it, how about sorting headers alphabetically to make sure this won't happen again ? With that change, Reviewed-by: Laurent Pinchart > struct panel_bridge { > struct drm_bridge bridge; -- Regards, Laurent Pinchart