All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <chris@csamuel.org>
To: linux-btrfs@vger.kernel.org
Cc: Lennart Poettering <lennart@poettering.net>
Subject: Re: btrfs_inode_item's otime?
Date: Tue, 06 Jan 2015 22:47 +1100	[thread overview]
Message-ID: <1891475.iuyauiTsCQ@quad> (raw)
In-Reply-To: <20150105172152.GB19126@gardel-login>

On Mon, 5 Jan 2015 06:21:52 PM Lennart Poettering wrote:

> Is this on purpose, or simply an oversight?


The only hint I can see that it's deliberate is the comment in fs/btrfs/send.c 
that says:

/* TODO Add otime support when the otime patches get into upstream */

However...

> It should be easy to initialize it to the mtime when the inode is
> first created...

This I agree with, well worth doing anyway.

I'll see if I can knock up a patch.

All the best,
Chris
-- 
 Chris Samuel  :  http://www.csamuel.org/  :  Melbourne, VIC



  reply	other threads:[~2015-01-06 11:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 17:21 btrfs_inode_item's otime? Lennart Poettering
2015-01-06 11:47 ` Chris Samuel [this message]
2015-01-06 12:43   ` Chris Samuel
2015-01-06 18:41     ` David Sterba
2015-01-08 10:52       ` Chris Samuel
2015-01-09 16:11         ` David Sterba
2015-01-15 10:48           ` David Sterba
2015-01-16  4:47             ` Chris Samuel
2015-01-06 18:26 ` David Sterba
2015-01-07 13:57   ` Lennart Poettering
2015-01-07 14:42     ` Christoph Hellwig
2015-01-10 10:13       ` Martin Steigerwald
2015-01-10 10:17         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1891475.iuyauiTsCQ@quad \
    --to=chris@csamuel.org \
    --cc=lennart@poettering.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.