All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daejun Park <daejun7.park@samsung.com>
To: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	Bart Van Assche <bvanassche@acm.org>,
	yongmyung lee <ymhungry.lee@samsung.com>,
	Daejun Park <daejun7.park@samsung.com>,
	ALIM AKHTAR <alim.akhtar@samsung.com>,
	"asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
	Zang Leigang <zangleigang@hisilicon.com>,
	Avi Shchislowski <avi.shchislowski@wdc.com>,
	Bean Huo <beanhuo@micron.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
	Avri Altman <avri.altman@wdc.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>,
	JinHwan Park <jh.i.park@samsung.com>
Subject: RE: [PATCH v7 00/11] Add Host control mode to HPB
Date: Mon, 05 Apr 2021 18:29:23 +0900	[thread overview]
Message-ID: <1891546521.01617616201846.JavaMail.epsvc@epcpadp3> (raw)
In-Reply-To: <20210331073952.102162-1-avri.altman@wdc.com>

> The HPB spec defines 2 control modes - device control mode and host
> control mode. In oppose to device control mode, in which the host obey
> to whatever recommendation received from the device - In host control
> mode, the host uses its own algorithms to decide which regions should
> be activated or inactivated.
>  
> We kept the host managed heuristic simple and concise.
>  
> Aside from adding a by-spec functionality, host control mode entails
> some further potential benefits: makes the hpb logic transparent and
> readable, while allow tuning / scaling its various parameters, and
> utilize system-wide info to optimize HPB potential.
>  
> This series is based on Samsung's V32 device-control HPB2.0 driver
>  
> This version was tested on Galaxy S20, and Xiaomi Mi10 pro.
> Your meticulous review and testing is mostly welcome and appreciated.
>  
> Thanks,
> Avri
>  
>  
> Avri Altman (11):
>   scsi: ufshpb: Cache HPB Control mode on init
>   scsi: ufshpb: Add host control mode support to rsp_upiu
>   scsi: ufshpb: Transform set_dirty to iterate_rgn
>   scsi: ufshpb: Add reads counter
>   scsi: ufshpb: Make eviction depends on region's reads
>   scsi: ufshpb: Region inactivation in host mode
>   scsi: ufshpb: Add hpb dev reset response
>   scsi: ufshpb: Add "Cold" regions timer
>   scsi: ufshpb: Limit the number of inflight map requests
>   scsi: ufshpb: Add support for host control mode
>   scsi: ufshpb: Make host mode parameters configurable
>  
>  Documentation/ABI/testing/sysfs-driver-ufs |  84 ++-
>  drivers/scsi/ufs/ufshcd.h                  |   2 +
>  drivers/scsi/ufs/ufshpb.c                  | 568 ++++++++++++++++++++-
>  drivers/scsi/ufs/ufshpb.h                  |  44 ++
>  4 files changed, 663 insertions(+), 35 deletions(-)
>  

The patches in this series look good to me.

Reviewed-by: Daejun Park <daejun7.park@samsung.com>

      parent reply	other threads:[~2021-04-05  9:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210331074004epcas2p3e6d0b2d1bf0f43708902b2d5583069c4@epcms2p6>
2021-03-31  7:39 ` [PATCH v7 00/11] Add Host control mode to HPB Avri Altman
2021-03-31  7:39   ` [PATCH v7 01/11] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-03-31  7:39   ` [PATCH v7 02/11] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-03-31  7:39   ` [PATCH v7 03/11] scsi: ufshpb: Transform set_dirty to iterate_rgn Avri Altman
2021-03-31  7:39   ` [PATCH v7 04/11] scsi: ufshpb: Add reads counter Avri Altman
2021-03-31  7:39   ` [PATCH v7 05/11] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-03-31  7:39   ` [PATCH v7 06/11] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-04-06  4:53     ` Can Guo
2021-04-06  5:20       ` Avri Altman
2021-04-06  6:00         ` Can Guo
2021-04-06  6:16           ` Avri Altman
2021-04-06  6:26             ` Can Guo
2021-04-06  7:16               ` Avri Altman
2021-04-10  1:09                 ` Avri Altman
2021-03-31  7:39   ` [PATCH v7 07/11] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-03-31  7:39   ` [PATCH v7 08/11] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-03-31  7:39   ` [PATCH v7 09/11] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-03-31  7:39   ` [PATCH v7 10/11] scsi: ufshpb: Add support for host control mode Avri Altman
2021-03-31  7:39   ` [PATCH v7 11/11] scsi: ufshpb: Make host mode parameters configurable Avri Altman
2021-04-05  9:29   ` Daejun Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1891546521.01617616201846.JavaMail.epsvc@epcpadp3 \
    --to=daejun7.park@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avi.shchislowski@wdc.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=jh.i.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=sungjun07.park@samsung.com \
    --cc=ymhungry.lee@samsung.com \
    --cc=zangleigang@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.