From: "hoyoung seo" <hy50.seo@samsung.com>
To: <bvanassche@acm.org>
Cc: <Arthur.Simchaev@wdc.com>, <JBottomley@Parallels.com>,
<adrian.hunter@intel.com>, <athierry@redhat.com>,
<avri.altman@wdc.com>, <beanhuo@micron.com>, <jaegeuk@kernel.org>,
<jejb@linux.ibm.com>, <linux-scsi@vger.kernel.org>,
<martin.petersen@oracle.com>, <quic_asutoshd@quicinc.com>,
<quic_ziqichen@quicinc.com>, <santoshsy@gmail.com>,
<stanley.chu@mediatek.com>, <cpgs@samsung.com>,
<sc.suh@samsung.com>, <kwmad.kim@samsung.com>,
<kwangwon.min@samsung.com>, <sh425.lee@samsung.com>
Subject: Re: [PATCH v3 2/4] scsi: ufs: Fix handling of lrbp->cmd
Date: Tue, 27 Jun 2023 10:26:58 +0900 [thread overview]
Message-ID: <1891546521.01687833901791.JavaMail.epsvc@epcpadp3> (raw)
In-Reply-To: CGME20230627012659epcas2p1961cc5bf75bf1a324f6f4fdebd7f897c@epcas2p1.samsung.com
@@ -5408,7 +5406,6 @@ static void ufshcd_release_scsi_cmd(struct ufs_hba *hba,
struct scsi_cmnd *cmd = lrbp->cmd;
scsi_dma_unmap(cmd);
- lrbp->cmd = NULL; /* Mark the command as completed. */
ufshcd_release(hba);
ufshcd_clk_scaling_update_busy(hba);
}
Hi,
Is there any reason to delete "lrbp->cmd = NULL"?
As far as I know, clear to NULL to indicate that cmd is completed.
When the UFS MCQ mode is activated, check that lrbp->cmd is NULL to check the completion of the command.
https://lore.kernel.org/linux-scsi/f0d923ee1f009f171a55c258d044e814ec0917ab.1685396241.git.quic_nguyenb@quicinc.com/
If there is no special reason, why don't you add "lrb->cmd = NULL" again?
next parent reply other threads:[~2023-06-27 2:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230627012659epcas2p1961cc5bf75bf1a324f6f4fdebd7f897c@epcas2p1.samsung.com>
2023-06-27 1:26 ` hoyoung seo [this message]
2023-06-27 19:53 ` [PATCH v3 2/4] scsi: ufs: Fix handling of lrbp->cmd Bart Van Assche
2023-06-28 7:44 ` hoyoung seo
[not found] <CGME20260212105422epcas2p44c875c9f8d57d1b4f6d231b9aef833c9@epcas2p4.samsung.com>
2026-02-12 10:54 ` hoyoung seo
2026-02-12 17:05 ` Bart Van Assche
[not found] <CGME20260212104911epcas2p1ada1bb6a8bcac1126bece2dccd3ed10f@epcas2p1.samsung.com>
2026-02-12 10:49 ` hoyoung seo
2023-05-24 20:36 [PATCH v3 0/4] UFS host controller driver patches Bart Van Assche
2023-05-24 20:36 ` [PATCH v3 2/4] scsi: ufs: Fix handling of lrbp->cmd Bart Van Assche
2023-05-25 4:47 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01687833901791.JavaMail.epsvc@epcpadp3 \
--to=hy50.seo@samsung.com \
--cc=Arthur.Simchaev@wdc.com \
--cc=JBottomley@Parallels.com \
--cc=adrian.hunter@intel.com \
--cc=athierry@redhat.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cpgs@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kwangwon.min@samsung.com \
--cc=kwmad.kim@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_ziqichen@quicinc.com \
--cc=santoshsy@gmail.com \
--cc=sc.suh@samsung.com \
--cc=sh425.lee@samsung.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.