From: Keoseong Park <keosung.park@samsung.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Avri Altman <avri.altman@wdc.com>,
Peter Wang <peter.wang@mediatek.com>,
Bean Huo <beanhuo@micron.com>
Subject: RE: [PATCH v2 3/7] scsi: ufs: Remove two constants
Date: Fri, 28 Jun 2024 12:14:58 +0900 [thread overview]
Message-ID: <1891546521.01719563881553.JavaMail.epsvc@epcpadp4> (raw)
In-Reply-To: <20240627195918.2709502-4-bvanassche@acm.org>
> The SCSI host template members .cmd_per_lun and .can_queue are copied
> into the SCSI host data structure. Before these are used, these are
> overwritten by ufshcd_init(). Hence, this patch does not change any
> functionality.
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Keoseong Park <keosung.park@samsung.com>
Best Regards,
Keoseong
> ---
> drivers/ufs/core/ufshcd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index b7ceedba4f93..9a0697556953 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -164,8 +164,6 @@ EXPORT_SYMBOL_GPL(ufshcd_dump_regs);
> enum {
> UFSHCD_MAX_CHANNEL = 0,
> UFSHCD_MAX_ID = 1,
> - UFSHCD_CMD_PER_LUN = 32 - UFSHCD_NUM_RESERVED,
> - UFSHCD_CAN_QUEUE = 32 - UFSHCD_NUM_RESERVED,
> };
>
> static const char *const ufshcd_state_name[] = {
> @@ -8958,8 +8956,6 @@ static const struct scsi_host_template ufshcd_driver_template = {
> .eh_timed_out = ufshcd_eh_timed_out,
> .this_id = -1,
> .sg_tablesize = SG_ALL,
> - .cmd_per_lun = UFSHCD_CMD_PER_LUN,
> - .can_queue = UFSHCD_CAN_QUEUE,
> .max_segment_size = PRDT_DATA_BYTE_COUNT_MAX,
> .max_sectors = SZ_1M / SECTOR_SIZE,
> .max_host_blocked = 1,
next prev parent reply other threads:[~2024-06-28 8:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 19:58 [PATCH v2 0/7] UFS patches for kernel 6.11 Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 1/7] scsi: ufs: Declare ufshcd_mcq_poll_cqe_lock() once Bart Van Assche
2024-06-28 2:13 ` Keoseong Park
2024-06-28 19:28 ` Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 2/7] scsi: ufs: Initialize struct uic_command once Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 3/7] scsi: ufs: Remove two constants Bart Van Assche
2024-06-28 3:14 ` Keoseong Park [this message]
2024-06-27 19:58 ` [PATCH v2 4/7] scsi: ufs: Rename the MASK_TRANSFER_REQUESTS_SLOTS constant Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 5/7] scsi: ufs: Initialize hba->reserved_slot earlier Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 6/7] scsi: ufs: Inline ufshcd_mcq_vops_get_hba_mac() Bart Van Assche
2024-06-27 19:58 ` [PATCH v2 7/7] scsi: ufs: Make .get_hba_mac() optional Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1891546521.01719563881553.JavaMail.epsvc@epcpadp4 \
--to=keosung.park@samsung.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=peter.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.