From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Marc Sune <marcdevel@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] cryptodev: fix RTE_PMD_DEBUG_TRACE redefinition
Date: Thu, 10 Mar 2016 19:23:25 +0100 [thread overview]
Message-ID: <1894237.OM5rSysoGp@xps13> (raw)
In-Reply-To: <1456961677-1116-1-git-send-email-marcdevel@gmail.com>
2016-03-03 00:34, Marc Sune:
> RTE_PMD_DEBUG_TRACE used RTE_FUNC_PTR_OR_ERR_RET was redefined
> in rte_cryptodev_pmd.h which produced MACRO redefinition warnings
> when including both rte_cryptodev_pmd.h and rte_ethdev.h.
>
> This commit moves MACRO definition to rte_cryptodev.c to prevent
> this warning.
It is not the right fix.
This macro should probably be renamed with a crypto prefix or defined
only once (same thing for ethdev).
The function rte_pmd_debug_trace() and the macros
RTE_PROC_PRIMARY_OR_ERR_RET,
RTE_PROC_PRIMARY_OR_RET,
RTE_FUNC_PTR_OR_ERR_RET,
RTE_FUNC_PTR_OR_RET
should not be in lib/librte_eal/common/include/rte_dev.h.
The macros call RTE_PMD_DEBUG_TRACE which is defined elsewhere.
The rte_log.h is probably a better place.
But why these macros have no PMD prefix?
next prev parent reply other threads:[~2016-03-10 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 23:34 [PATCH] cryptodev: fix RTE_PMD_DEBUG_TRACE redefinition Marc Sune
2016-03-10 18:23 ` Thomas Monjalon [this message]
2016-03-14 22:16 ` Marc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894237.OM5rSysoGp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=marcdevel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.