From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH 2/2] errormsg: add descriptive macros to replace overloaded error codes Date: Wed, 24 May 2017 16:02:47 -0400 Message-ID: <1894724.IJY7jiRZBU@x2> References: <1491302268-797-1-git-send-email-rgb@redhat.com> <124499206.jtSla3cULl@x2> <20170508135200.GY25861@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170508135200.GY25861@madcap2.tricolour.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Richard Guy Briggs Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Monday, May 8, 2017 9:52:00 AM EDT Richard Guy Briggs wrote: > > > Ok, so coming back to patch acceptance, if I read correctly your > > > comments, reduce the four new error types to two? > > > > Yes, two are needed. One for missing filter/action and one for we are > > attempting an incompatible comparison between fields. > > Ok, here you go: > https://github.com/linux-audit/audit-userspace/pull/21 Was just going to look over this patch and now I see its not on the mail list. This version looks fine. I kind of prefer patches sent to the mail list so that any discussion is archived. -Steve