From: Szymon Janc <szymon.janc@tieto.com>
To: Jakub Tyszkowski <jakub.tyszkowski@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv2 00/16] android/tester: Unifying the way PDU is handled
Date: Tue, 30 Sep 2014 11:44:28 +0200 [thread overview]
Message-ID: <1896433.RfLfb6axKr@uw000953> (raw)
In-Reply-To: <1411713077-19757-1-git-send-email-jakub.tyszkowski@tieto.com>
Hi Jakub,
On Friday 26 of September 2014 08:31:01 Jakub Tyszkowski wrote:
> This patchset makes all testers use common struct for using raw data (PDUs).
> Also some helpers were added for pdu matching and sending.
>
> v2 changes:
> * added generic hook and connect callback in tester-main for handling simple
> cases when only pdu exchange is needed on given channel
>
> Jakub Tyszkowski (16):
> android/tester: Expose gatt-tester's pdu definition to other testers
> android/tester: Make AVRCP tests use generic pdu struct
> android/tester: Make A2DP tests use generic pdu struct
> android/tester: Make GATT tests use generic pdu struct
> android/tester: Make HidHost tests use generic pdu struct
> android/tester: Make PAN tests use generic pdu struct
> android/tester: Make HDP tests use generic pdu struct
> android/tester: Expose pdu_set structure so it can be reused
> android/tester: Add generic hook to handle pdu exchange
> android/tester: Make A2DP use pdu exchange mechanism
> android/tester: Make AVRCP tests use generic pdu exchange mechanism
> android/tester: Make GATT use generic cid_data
> android/tester: Make HDP tests use generic PDU exchange mechanism
> android/tester: Make HIDHost tests use generic PDU exchange mechanism
> android/tester: Make PAN use generic PDU exchange mechanism
> android-tester: Use generic connect callback for simple cases
>
> android/tester-a2dp.c | 109 +++++++--------------
> android/tester-avrcp.c | 181 +++++++++++++----------------------
> android/tester-gatt.c | 72 +++++---------
> android/tester-hdp.c | 200 ++++++++++++++++----------------------
> android/tester-hidhost.c | 243 +++++++++++++++++++++--------------------------
> android/tester-main.c | 58 +++++++++++
> android/tester-main.h | 32 +++++++
> android/tester-pan.c | 45 +++------
> 8 files changed, 413 insertions(+), 527 deletions(-)
>
This looks quite good to me but needs to be rebased.
--
Best regards,
Szymon Janc
prev parent reply other threads:[~2014-09-30 9:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 6:31 [PATCHv2 00/16] android/tester: Unifying the way PDU is handled Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 01/16] android/tester: Expose gatt-tester's pdu definition to other testers Jakub Tyszkowski
2014-09-30 10:08 ` Luiz Augusto von Dentz
2014-09-30 11:41 ` Tyszkowski Jakub
2014-09-30 12:10 ` Luiz Augusto von Dentz
2014-10-01 8:20 ` Tyszkowski Jakub
2014-09-26 6:31 ` [PATCHv2 02/16] android/tester: Make AVRCP tests use generic pdu struct Jakub Tyszkowski
2014-09-30 9:37 ` Szymon Janc
2014-09-26 6:31 ` [PATCHv2 03/16] android/tester: Make A2DP " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 04/16] android/tester: Make GATT " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 05/16] android/tester: Make HidHost " Jakub Tyszkowski
2014-09-30 9:40 ` Szymon Janc
2014-09-30 9:54 ` Luiz Augusto von Dentz
2014-09-30 10:00 ` Szymon Janc
2014-09-30 10:10 ` Luiz Augusto von Dentz
2014-09-30 12:01 ` Tyszkowski Jakub
2014-09-26 6:31 ` [PATCHv2 06/16] android/tester: Make PAN " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 07/16] android/tester: Make HDP " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 08/16] android/tester: Expose pdu_set structure so it can be reused Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 09/16] android/tester: Add generic hook to handle pdu exchange Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 10/16] android/tester: Make A2DP use pdu exchange mechanism Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 11/16] android/tester: Make AVRCP tests use generic " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 12/16] android/tester: Make GATT use generic cid_data Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 13/16] android/tester: Make HDP tests use generic PDU exchange mechanism Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 14/16] android/tester: Make HIDHost " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 15/16] android/tester: Make PAN " Jakub Tyszkowski
2014-09-26 6:31 ` [PATCHv2 16/16] android-tester: Use generic connect callback for simple cases Jakub Tyszkowski
2014-09-30 9:44 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1896433.RfLfb6axKr@uw000953 \
--to=szymon.janc@tieto.com \
--cc=jakub.tyszkowski@tieto.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.