From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 24 Aug 2016 17:02:56 +0200 Subject: [PATCH v05 60/72] arch/arm/include/uapi/asm/signal.h: use __kernel_size_t instead of size_t In-Reply-To: <1471890809-4383-61-git-send-email-mikko.rapeli@iki.fi> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-61-git-send-email-mikko.rapeli@iki.fi> Message-ID: <1898059.B1P75dnZ5Q@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday, August 22, 2016 8:33:17 PM CEST Mikko Rapeli wrote: > diff --git a/arch/arm/include/uapi/asm/signal.h b/arch/arm/include/uapi/asm/signal.h > index 33073bd..859f2de 100644 > --- a/arch/arm/include/uapi/asm/signal.h > +++ b/arch/arm/include/uapi/asm/signal.h > @@ -113,7 +113,7 @@ struct sigaction { > typedef struct sigaltstack { > void __user *ss_sp; > int ss_flags; > - size_t ss_size; > + __kernel_size_t ss_size; > } stack_t; I was going to reply with an Ack, but on further consideration, I'm not sure if we can't do this in general: size_t may be either 'unsigned int' or 'unsigned long' (depending on the architecture and toolchain), and if kernel and glibc disagree on this, we have a problem with any user space code that expects sigaltstack->ss_size to be the same type as size_t (as mandated by the man page). I wonder if there is another way to address this. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756774AbcHXPDf (ORCPT ); Wed, 24 Aug 2016 11:03:35 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:52161 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755153AbcHXPDd (ORCPT ); Wed, 24 Aug 2016 11:03:33 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Mikko Rapeli , linux-kernel@vger.kernel.org, Russell King Subject: Re: [PATCH v05 60/72] arch/arm/include/uapi/asm/signal.h: use __kernel_size_t instead of size_t Date: Wed, 24 Aug 2016 17:02:56 +0200 Message-ID: <1898059.B1P75dnZ5Q@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1471890809-4383-61-git-send-email-mikko.rapeli@iki.fi> References: <1471890809-4383-1-git-send-email-mikko.rapeli@iki.fi> <1471890809-4383-61-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:dboL7713gAEdli5Nrnqz5zjJo4Qy2/rp1Iv/7Pv8Q64ZYuG5oX8 QNXfLZSkrOO7XSGzW7eiFpSF6zql7PYhdishbQIsOtzZPRgNc5MMObx9RzxS6DsWqopyfE7 NcvxaRJqEgmJ4F8nVMYSCsFdECkvxEa6iVOnhaUQ6Im/ahogR2x/Q2K1iNXJB6q0UdboU9H kVIwPf2RgdFbLhrwgCyHg== X-UI-Out-Filterresults: notjunk:1;V01:K0:yjrgTT/GJx4=:KCZKljVsN4ChY+3nmuma0e 6udWZ9DV/sIgbKQ9hhUdSCreyKYIW6IbqZMpvWCGY0baWCzz/VN06SFYL4ulyoQ5pmUe9HJco e2nXTIffHm7LR9BIaLcBg7RIAUMbM9Be53iwQ7SNYypGiBUr71Js5UzIpsvmxBtrt2EpufpGN 5oMcALRqUEho59E3lwcIAQZI2KBbTV/Wo1CodiojjYL4KxdWP6HXkZZ/an6vj6YuBYByc9Xdq TVtOLeaYfHYs+bhVtDcoDp6peHG1Caugln9xHusdZraOfiActQXnw3j+otahGP/wPsdC3VVl4 BzrbhniV6pu6XKQ3yMtFTCq6xa0ynzJvC9ooneeNhxeemhwMu/rc8wkC2F9RSJ7vCm8ZD2xmG AM4HRA0BLEC4+l0Znv8mGDWCHMcD0lYm4P+PxZ9+UFuy42YNT1zaVcbwrnYVfiZSP6UWWXznj eKdXcwQvPtN95X6vkqIHZD8qrg7oPAj31eSJPfgOYVrcilk2/gwz0Dc9H/uEJZrZuMtaS8cww kpWp/NUEFKT0156Wq/tYGf6kZfpWPbPAIeQgNoFhmGmpXEcT1CO1U5h0nXqeEV4HIMnw8xUKw ojvEvt7i/XiNp1sNpUOuFjIl+I+LkzHKzId/wV3S2hO/o/oEpnzGSnO6FCKyUIM3OzX+AbkFT cp+pctPnEQJ4dWN/EAyCGGjbp4wjojWru+QYtXGFwhAue/mRwFIswycEaOYlutR1aJSFunuL6 vjtAfxBdPDOSxuYO Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, August 22, 2016 8:33:17 PM CEST Mikko Rapeli wrote: > diff --git a/arch/arm/include/uapi/asm/signal.h b/arch/arm/include/uapi/asm/signal.h > index 33073bd..859f2de 100644 > --- a/arch/arm/include/uapi/asm/signal.h > +++ b/arch/arm/include/uapi/asm/signal.h > @@ -113,7 +113,7 @@ struct sigaction { > typedef struct sigaltstack { > void __user *ss_sp; > int ss_flags; > - size_t ss_size; > + __kernel_size_t ss_size; > } stack_t; I was going to reply with an Ack, but on further consideration, I'm not sure if we can't do this in general: size_t may be either 'unsigned int' or 'unsigned long' (depending on the architecture and toolchain), and if kernel and glibc disagree on this, we have a problem with any user space code that expects sigaltstack->ss_size to be the same type as size_t (as mandated by the man page). I wonder if there is another way to address this. Arnd