All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: raven@themaw.net, viro@zeniv.linux.org.uk
Cc: dhowells@redhat.com, autofs@linux.kernel.org
Subject: autofs4_d_automount() can change path->dentry param
Date: Sat, 15 Jan 2011 11:11:02 +0000	[thread overview]
Message-ID: <18985.1295089862@redhat.com> (raw)


Hi Ian,

I've just noticed that autofs4_d_automount() can change the dentry pointer in
the path parameter (via autofs4_mountpoint_changed()).  Is this just doing a
straight substitution of one dentry for its equivalent?  I don't think it'll
be a problem for follow_automount() and follow_managed(), provided the dentry
stays in the same namespace - but if we eliminate the vfsmount pointer and
just pass the dentry pointer in to d_automount(), you won't be able to do this
anymore.  Would it work to simply return NULL here and hope the recheck picks
up the substitution?

David

             reply	other threads:[~2011-01-15 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-15 11:11 David Howells [this message]
2011-01-17  0:07 ` autofs4_d_automount() can change path->dentry param Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18985.1295089862@redhat.com \
    --to=dhowells@redhat.com \
    --cc=autofs@linux.kernel.org \
    --cc=raven@themaw.net \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.