From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Goldschmidt Date: Wed, 5 Dec 2018 17:08:53 +0100 Subject: [U-Boot] [PATCH] fdt: Add warning about CONFIG_OF_EMBED In-Reply-To: References: <20181205135708.58002-1-sjg@chromium.org> <8d444970-931e-4c75-7134-de8d09837812@gmail.com> Message-ID: <18c1081c-6bd2-d69a-cd44-60486ee1fcde@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, Am 05.12.2018 um 16:57 schrieb Simon Glass: > Hi Simon, > > On Wed, 5 Dec 2018 at 07:22, Simon Goldschmidt > wrote: >> >> Am 05.12.2018 um 14:57 schrieb Simon Glass: >>> This option has crept into use with some boards. Add a warning to try to >>> prevent this. >>> >>> As an example: >>> https://lists.denx.de/pipermail/u-boot/2017-September/304966.html >> >> We have just discussed this in another thread. There seem to be ~109 >> defconfigs in the tree that enable OF_EMBED. >> >> I doubt all of them do this for fun, so we might want to collect the >> reasons they do so. I do know two: >> >> - socfpga_stratix10_defconfig needs this to get a correct u-boot-spl.hex > > Let's fix that then. > >> - I would need it to ensure in SPL, the DTB is in one block with the >> other readonly parts. Without OF_EMBED, we have '.text', '.bss', DT. > > Similarly, let's change that. > > CONFIG_OF_EMBED should not be a work-around for missing features that we need. I'm with you there. Don't get me wrong, I don't want to argue to use OF_EMBED, just wanted to list the use cases I know so that we only fix them once instead of letting everyone fixing them on their own. Regards, Simon