diff for duplicates of <18c82f6f723cd97a9d6b9a7ff16c6ed62fd005d6.camel@mediatek.com> diff --git a/a/1.txt b/N1/1.txt index 3e235ff..c587e13 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,23 +1,23 @@ On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote: > On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: -> -> > +/* -> > + * PCM trigger callback. -> > + * Mandatory -> > + */ -> > +int (*trigger)(struct device *dev, int cmd); +> +> > + /* +> > + * PCM trigger callback. +> > + * Mandatory +> > + */ +> > + int (*trigger)(struct device *dev, int cmd); > > + -> +> > Making this mandatory would break all existing users, though... -> +> Yes, it should be described as optional. -> > +switch (event) { -> > +case SND_SOC_DAPM_PRE_PMU: -> > +if (hcp->hcd.ops->trigger) -> > +hcp->hcd.ops->trigger(component->dev->parent, +> > + switch (event) { +> > + case SND_SOC_DAPM_PRE_PMU: +> > + if (hcp->hcd.ops->trigger) +> > + hcp->hcd.ops->trigger(component->dev->parent, > > SNDRV_PCM_TRIGGER_START); -> +> > ..it's not actually mandatory so it's just the comment that's wrong. Agreed. @@ -38,8 +38,8 @@ Agreed. Let me describe the hardware connection about mt8186 with it6505(hdmi) and rt1015p(speakers). - ==>it6505 - = + ==>it6505 + = DL1(FE) ==>I2S3(BE) = = ==>rt1015p @@ -49,21 +49,3 @@ separately. So if hdmi-codec use the PCM trigger op, whne we turn on the speaker, hdmi-codec's PCM trigger op is also executed, resulting in sound on both devices. Is there another way to control them separately? Thank you. - - - - -************* MEDIATEK Confidentiality Notice - ******************** -The information contained in this e-mail message (including any -attachments) may be confidential, proprietary, privileged, or otherwise -exempt from disclosure under applicable laws. It is intended to be -conveyed only to the designated recipient(s). Any use, dissemination, -distribution, printing, retaining or copying of this e-mail (including its -attachments) by unintended recipient(s) is strictly prohibited and may -be unlawful. If you are not an intended recipient of this e-mail, or believe - -that you have received this e-mail in error, please notify the sender -immediately (by replying to this e-mail), delete any and all copies of -this e-mail (including any attachments) from your system, and do not -disclose the content of this e-mail to any other person. Thank you! diff --git a/a/content_digest b/N1/content_digest index bb4dfe4..ce337f1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,44 +5,44 @@ "Subject\0Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX\0" "Date\0Mon, 28 Nov 2022 15:07:22 +0000\0" "To\0broonie@kernel.org <broonie@kernel.org>\0" - "Cc\0alsa-devel@alsa-project.org <alsa-devel@alsa-project.org>" - neil.armstrong@linaro.org <neil.armstrong@linaro.org> - nfraprado@collabora.com <nfraprado@collabora.com> + "Cc\0linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> " Chunxu Li (\346\235\216\346\230\245\346\227\255) <Chunxu.Li@mediatek.com>" + ajye_huang@compal.corp-partner.google.com <ajye_huang@compal.corp-partner.google.com> " Allen-KH Cheng (\347\250\213\345\206\240\345\213\263) <Allen-KH.Cheng@mediatek.com>" - kuninori.morimoto.gx@renesas.com <kuninori.morimoto.gx@renesas.com> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org> + kuninori.morimoto.gx@renesas.com <kuninori.morimoto.gx@renesas.com> + andrzej.hajda@intel.com <andrzej.hajda@intel.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com> - linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org> robert.foss@linaro.org <robert.foss@linaro.org> - andrzej.hajda@intel.com <andrzej.hajda@intel.com> + Laurent.pinchart@ideasonboard.com <Laurent.pinchart@ideasonboard.com> + neil.armstrong@linaro.org <neil.armstrong@linaro.org> angelogioacchino.delregno@collabora.com <angelogioacchino.delregno@collabora.com> - ajye_huang@compal.corp-partner.google.com <ajye_huang@compal.corp-partner.google.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " Laurent.pinchart@ideasonboard.com <Laurent.pinchart@ideasonboard.com>\0" + nfraprado@collabora.com <nfraprado@collabora.com> + " alsa-devel@alsa-project.org <alsa-devel@alsa-project.org>\0" "\00:1\0" "b\0" "On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote:\n" "> On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote:\n" - ">\n" - "> > +/*\n" - "> > + * PCM trigger callback.\n" - "> > + * Mandatory\n" - "> > + */\n" - "> > +int (*trigger)(struct device *dev, int cmd);\n" + "> \n" + "> > +\t/*\n" + "> > +\t * PCM trigger callback.\n" + "> > +\t * Mandatory\n" + "> > +\t */\n" + "> > +\tint (*trigger)(struct device *dev, int cmd);\n" "> > +\n" - ">\n" + "> \n" "> Making this mandatory would break all existing users, though...\n" - ">\n" + "> \n" "Yes, it should be described as optional.\n" "\n" - "> > +switch (event) {\n" - "> > +case SND_SOC_DAPM_PRE_PMU:\n" - "> > +if (hcp->hcd.ops->trigger)\n" - "> > +hcp->hcd.ops->trigger(component->dev->parent,\n" + "> > +\tswitch (event) {\n" + "> > +\tcase SND_SOC_DAPM_PRE_PMU:\n" + "> > +\t\tif (hcp->hcd.ops->trigger)\n" + "> > +\t\t\thcp->hcd.ops->trigger(component->dev->parent,\n" "> > SNDRV_PCM_TRIGGER_START);\n" - ">\n" + "> \n" "> ..it's not actually mandatory so it's just the comment that's wrong.\n" "\n" "Agreed.\n" @@ -63,8 +63,8 @@ "Let me describe the hardware connection about mt8186 with it6505(hdmi)\n" "and rt1015p(speakers).\n" "\n" - " ==>it6505\n" - " =\n" + " ==>it6505 \n" + " = \n" "DL1(FE) ==>I2S3(BE) =\n" " =\n" " ==>rt1015p\n" @@ -73,24 +73,6 @@ "separately. So if hdmi-codec use the PCM trigger op, whne we turn on\n" "the speaker, hdmi-codec's PCM trigger op is also executed, resulting in\n" "sound on both devices.\n" - "Is there another way to control them separately? Thank you.\n" - "\n" - "\n" - "\n" - "\n" - "************* MEDIATEK Confidentiality Notice\n" - " ********************\n" - "The information contained in this e-mail message (including any\n" - "attachments) may be confidential, proprietary, privileged, or otherwise\n" - "exempt from disclosure under applicable laws. It is intended to be\n" - "conveyed only to the designated recipient(s). Any use, dissemination,\n" - "distribution, printing, retaining or copying of this e-mail (including its\n" - "attachments) by unintended recipient(s) is strictly prohibited and may\n" - "be unlawful. If you are not an intended recipient of this e-mail, or believe\n" - "\n" - "that you have received this e-mail in error, please notify the sender\n" - "immediately (by replying to this e-mail), delete any and all copies of\n" - "this e-mail (including any attachments) from your system, and do not\n" - disclose the content of this e-mail to any other person. Thank you! + Is there another way to control them separately? Thank you. -d51f816f5e834dc58d4d7661c7683fca4d9d0ddf6e2478daf8c0ea24a065b37e +2528d4ddc6bb83f6efd1c0defb586b26f147b39d7f4ba94f178723cada81dc05
diff --git a/a/1.txt b/N2/1.txt index 3e235ff..e9680c8 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,23 +1,23 @@ On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote: > On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: -> -> > +/* -> > + * PCM trigger callback. -> > + * Mandatory -> > + */ -> > +int (*trigger)(struct device *dev, int cmd); +> +> > + /* +> > + * PCM trigger callback. +> > + * Mandatory +> > + */ +> > + int (*trigger)(struct device *dev, int cmd); > > + -> +> > Making this mandatory would break all existing users, though... -> +> Yes, it should be described as optional. -> > +switch (event) { -> > +case SND_SOC_DAPM_PRE_PMU: -> > +if (hcp->hcd.ops->trigger) -> > +hcp->hcd.ops->trigger(component->dev->parent, +> > + switch (event) { +> > + case SND_SOC_DAPM_PRE_PMU: +> > + if (hcp->hcd.ops->trigger) +> > + hcp->hcd.ops->trigger(component->dev->parent, > > SNDRV_PCM_TRIGGER_START); -> +> > ..it's not actually mandatory so it's just the comment that's wrong. Agreed. @@ -38,8 +38,8 @@ Agreed. Let me describe the hardware connection about mt8186 with it6505(hdmi) and rt1015p(speakers). - ==>it6505 - = + ==>it6505 + = DL1(FE) ==>I2S3(BE) = = ==>rt1015p @@ -51,19 +51,7 @@ sound on both devices. Is there another way to control them separately? Thank you. - - -************* MEDIATEK Confidentiality Notice - ******************** -The information contained in this e-mail message (including any -attachments) may be confidential, proprietary, privileged, or otherwise -exempt from disclosure under applicable laws. It is intended to be -conveyed only to the designated recipient(s). Any use, dissemination, -distribution, printing, retaining or copying of this e-mail (including its -attachments) by unintended recipient(s) is strictly prohibited and may -be unlawful. If you are not an intended recipient of this e-mail, or believe - -that you have received this e-mail in error, please notify the sender -immediately (by replying to this e-mail), delete any and all copies of -this e-mail (including any attachments) from your system, and do not -disclose the content of this e-mail to any other person. Thank you! +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N2/content_digest index bb4dfe4..00726b0 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,44 +5,44 @@ "Subject\0Re: [PATCH v2 1/3] ASoC: hdmi-codec: Add event handler for hdmi TX\0" "Date\0Mon, 28 Nov 2022 15:07:22 +0000\0" "To\0broonie@kernel.org <broonie@kernel.org>\0" - "Cc\0alsa-devel@alsa-project.org <alsa-devel@alsa-project.org>" - neil.armstrong@linaro.org <neil.armstrong@linaro.org> - nfraprado@collabora.com <nfraprado@collabora.com> + "Cc\0linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> " Chunxu Li (\346\235\216\346\230\245\346\227\255) <Chunxu.Li@mediatek.com>" + ajye_huang@compal.corp-partner.google.com <ajye_huang@compal.corp-partner.google.com> " Allen-KH Cheng (\347\250\213\345\206\240\345\213\263) <Allen-KH.Cheng@mediatek.com>" - kuninori.morimoto.gx@renesas.com <kuninori.morimoto.gx@renesas.com> - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org> + kuninori.morimoto.gx@renesas.com <kuninori.morimoto.gx@renesas.com> + andrzej.hajda@intel.com <andrzej.hajda@intel.com> + linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@mediatek.com> - linux-mediatek@lists.infradead.org <linux-mediatek@lists.infradead.org> robert.foss@linaro.org <robert.foss@linaro.org> - andrzej.hajda@intel.com <andrzej.hajda@intel.com> + Laurent.pinchart@ideasonboard.com <Laurent.pinchart@ideasonboard.com> + neil.armstrong@linaro.org <neil.armstrong@linaro.org> angelogioacchino.delregno@collabora.com <angelogioacchino.delregno@collabora.com> - ajye_huang@compal.corp-partner.google.com <ajye_huang@compal.corp-partner.google.com> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - " Laurent.pinchart@ideasonboard.com <Laurent.pinchart@ideasonboard.com>\0" + nfraprado@collabora.com <nfraprado@collabora.com> + " alsa-devel@alsa-project.org <alsa-devel@alsa-project.org>\0" "\00:1\0" "b\0" "On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote:\n" "> On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote:\n" - ">\n" - "> > +/*\n" - "> > + * PCM trigger callback.\n" - "> > + * Mandatory\n" - "> > + */\n" - "> > +int (*trigger)(struct device *dev, int cmd);\n" + "> \n" + "> > +\t/*\n" + "> > +\t * PCM trigger callback.\n" + "> > +\t * Mandatory\n" + "> > +\t */\n" + "> > +\tint (*trigger)(struct device *dev, int cmd);\n" "> > +\n" - ">\n" + "> \n" "> Making this mandatory would break all existing users, though...\n" - ">\n" + "> \n" "Yes, it should be described as optional.\n" "\n" - "> > +switch (event) {\n" - "> > +case SND_SOC_DAPM_PRE_PMU:\n" - "> > +if (hcp->hcd.ops->trigger)\n" - "> > +hcp->hcd.ops->trigger(component->dev->parent,\n" + "> > +\tswitch (event) {\n" + "> > +\tcase SND_SOC_DAPM_PRE_PMU:\n" + "> > +\t\tif (hcp->hcd.ops->trigger)\n" + "> > +\t\t\thcp->hcd.ops->trigger(component->dev->parent,\n" "> > SNDRV_PCM_TRIGGER_START);\n" - ">\n" + "> \n" "> ..it's not actually mandatory so it's just the comment that's wrong.\n" "\n" "Agreed.\n" @@ -63,8 +63,8 @@ "Let me describe the hardware connection about mt8186 with it6505(hdmi)\n" "and rt1015p(speakers).\n" "\n" - " ==>it6505\n" - " =\n" + " ==>it6505 \n" + " = \n" "DL1(FE) ==>I2S3(BE) =\n" " =\n" " ==>rt1015p\n" @@ -76,21 +76,9 @@ "Is there another way to control them separately? Thank you.\n" "\n" "\n" - "\n" - "\n" - "************* MEDIATEK Confidentiality Notice\n" - " ********************\n" - "The information contained in this e-mail message (including any\n" - "attachments) may be confidential, proprietary, privileged, or otherwise\n" - "exempt from disclosure under applicable laws. It is intended to be\n" - "conveyed only to the designated recipient(s). Any use, dissemination,\n" - "distribution, printing, retaining or copying of this e-mail (including its\n" - "attachments) by unintended recipient(s) is strictly prohibited and may\n" - "be unlawful. If you are not an intended recipient of this e-mail, or believe\n" - "\n" - "that you have received this e-mail in error, please notify the sender\n" - "immediately (by replying to this e-mail), delete any and all copies of\n" - "this e-mail (including any attachments) from your system, and do not\n" - disclose the content of this e-mail to any other person. Thank you! + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -d51f816f5e834dc58d4d7661c7683fca4d9d0ddf6e2478daf8c0ea24a065b37e +d845bb7c172e823227a5fedb642c094342ada4130052a801fc8c6dd2411a2a83
diff --git a/N3/1.bin b/N3/1.bin new file mode 100644 index 0000000..399fac6 --- /dev/null +++ b/N3/1.bin @@ -0,0 +1,70 @@ +<pre> +On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote: +> On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: +>  +> > +/* +> > + * PCM trigger callback. +> > + * Mandatory +> > + */ +> > +int (*trigger)(struct device *dev, int cmd); +> > + +>  +> Making this mandatory would break all existing users, though... +>  +Yes, it should be described as optional. + +> > +switch (event) { +> > +case SND_SOC_DAPM_PRE_PMU: +> > +if (hcp->hcd.ops->trigger) +> > +hcp->hcd.ops->trigger(component->dev->parent, +> > SNDRV_PCM_TRIGGER_START); +>  +> ..it's not actually mandatory so it's just the comment that's wrong. + +Agreed. + +> I'm a little unclear why this is being implemented as a DAPM +> operation +> rather than having the driver forward the PCM trigger op if it's +> needed? +> Or alternatively if a DAPM callback is needed why not provide one +> directly rather than hooking into the trigger function - that's going +> to +> be called out of sequence with the rest of DAPM and be potentially +> confusing given the very different environments that trigger and DAPM +> operations run in.  A quick glance at the it6505 driver suggests it'd +> be +> happier with a DAPM callback. + +Let me describe the hardware connection about mt8186 with it6505(hdmi) +and rt1015p(speakers). + +                       ==>it6505  +                     =  +DL1(FE) ==>I2S3(BE) = +                     = +                       ==>rt1015p + +They shared the same one i2s port, but we'd like to control them +separately. So if hdmi-codec use the PCM trigger op, whne we turn on +the speaker, hdmi-codec's PCM trigger op is also executed, resulting in +sound on both devices. +Is there another way to control them separately? Thank you. + + + +</pre><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice + ******************** +The information contained in this e-mail message (including any +attachments) may be confidential, proprietary, privileged, or otherwise +exempt from disclosure under applicable laws. It is intended to be +conveyed only to the designated recipient(s). Any use, dissemination, +distribution, printing, retaining or copying of this e-mail (including its +attachments) by unintended recipient(s) is strictly prohibited and may +be unlawful. If you are not an intended recipient of this e-mail, or believe + +that you have received this e-mail in error, please notify the sender +immediately (by replying to this e-mail), delete any and all copies of +this e-mail (including any attachments) from your system, and do not +disclose the content of this e-mail to any other person. Thank you! +</pre><!--}--> diff --git a/N3/2.hdr b/N3/2.hdr new file mode 100644 index 0000000..45d76fc --- /dev/null +++ b/N3/2.hdr @@ -0,0 +1,3 @@ +Content-Type: text/plain; + charset="utf-8" +Content-Transfer-Encoding: base64 diff --git a/a/1.txt b/N3/2.txt similarity index 53% rename from a/1.txt rename to N3/2.txt index 3e235ff..c587e13 100644 --- a/a/1.txt +++ b/N3/2.txt @@ -1,23 +1,23 @@ On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote: > On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote: -> -> > +/* -> > + * PCM trigger callback. -> > + * Mandatory -> > + */ -> > +int (*trigger)(struct device *dev, int cmd); +> +> > + /* +> > + * PCM trigger callback. +> > + * Mandatory +> > + */ +> > + int (*trigger)(struct device *dev, int cmd); > > + -> +> > Making this mandatory would break all existing users, though... -> +> Yes, it should be described as optional. -> > +switch (event) { -> > +case SND_SOC_DAPM_PRE_PMU: -> > +if (hcp->hcd.ops->trigger) -> > +hcp->hcd.ops->trigger(component->dev->parent, +> > + switch (event) { +> > + case SND_SOC_DAPM_PRE_PMU: +> > + if (hcp->hcd.ops->trigger) +> > + hcp->hcd.ops->trigger(component->dev->parent, > > SNDRV_PCM_TRIGGER_START); -> +> > ..it's not actually mandatory so it's just the comment that's wrong. Agreed. @@ -38,8 +38,8 @@ Agreed. Let me describe the hardware connection about mt8186 with it6505(hdmi) and rt1015p(speakers). - ==>it6505 - = + ==>it6505 + = DL1(FE) ==>I2S3(BE) = = ==>rt1015p @@ -49,21 +49,3 @@ separately. So if hdmi-codec use the PCM trigger op, whne we turn on the speaker, hdmi-codec's PCM trigger op is also executed, resulting in sound on both devices. Is there another way to control them separately? Thank you. - - - - -************* MEDIATEK Confidentiality Notice - ******************** -The information contained in this e-mail message (including any -attachments) may be confidential, proprietary, privileged, or otherwise -exempt from disclosure under applicable laws. It is intended to be -conveyed only to the designated recipient(s). Any use, dissemination, -distribution, printing, retaining or copying of this e-mail (including its -attachments) by unintended recipient(s) is strictly prohibited and may -be unlawful. If you are not an intended recipient of this e-mail, or believe - -that you have received this e-mail in error, please notify the sender -immediately (by replying to this e-mail), delete any and all copies of -this e-mail (including any attachments) from your system, and do not -disclose the content of this e-mail to any other person. Thank you! diff --git a/a/content_digest b/N3/content_digest index bb4dfe4..2b8eab3 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -21,28 +21,100 @@ ajye_huang@compal.corp-partner.google.com <ajye_huang@compal.corp-partner.google.com> linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> " Laurent.pinchart@ideasonboard.com <Laurent.pinchart@ideasonboard.com>\0" - "\00:1\0" + "\01:1\0" + "b\0" + "<pre>\r\n" + "On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote:\r\n" + "> On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote:\r\n" + "> \r\n" + "> > +/*\r\n" + "> > + * PCM trigger callback.\r\n" + "> > + * Mandatory\r\n" + "> > + */\r\n" + "> > +int (*trigger)(struct device *dev, int cmd);\r\n" + "> > +\r\n" + "> \r\n" + "> Making this mandatory would break all existing users, though...\r\n" + "> \r\n" + "Yes, it should be described as optional.\r\n" + "\r\n" + "> > +switch (event) {\r\n" + "> > +case SND_SOC_DAPM_PRE_PMU:\r\n" + "> > +if (hcp->hcd.ops->trigger)\r\n" + "> > +hcp->hcd.ops->trigger(component->dev->parent,\r\n" + "> > SNDRV_PCM_TRIGGER_START);\r\n" + "> \r\n" + "> ..it's not actually mandatory so it's just the comment that's wrong.\r\n" + "\r\n" + "Agreed.\r\n" + "\r\n" + "> I'm a little unclear why this is being implemented as a DAPM\r\n" + "> operation\r\n" + "> rather than having the driver forward the PCM trigger op if it's\r\n" + "> needed?\r\n" + "> Or alternatively if a DAPM callback is needed why not provide one\r\n" + "> directly rather than hooking into the trigger function - that's going\r\n" + "> to\r\n" + "> be called out of sequence with the rest of DAPM and be potentially\r\n" + "> confusing given the very different environments that trigger and DAPM\r\n" + "> operations run in.  A quick glance at the it6505 driver suggests it'd\r\n" + "> be\r\n" + "> happier with a DAPM callback.\r\n" + "\r\n" + "Let me describe the hardware connection about mt8186 with it6505(hdmi)\r\n" + "and rt1015p(speakers).\r\n" + "\r\n" + "                       ==>it6505 \r\n" + "                     = \r\n" + "DL1(FE) ==>I2S3(BE) =\r\n" + "                     =\r\n" + "                       ==>rt1015p\r\n" + "\r\n" + "They shared the same one i2s port, but we'd like to control them\r\n" + "separately. So if hdmi-codec use the PCM trigger op, whne we turn on\r\n" + "the speaker, hdmi-codec's PCM trigger op is also executed, resulting in\r\n" + "sound on both devices.\r\n" + "Is there another way to control them separately? Thank you.\r\n" + "\r\n" + "\r\n" + "\r\n" + "</pre><!--type:text--><!--{--><pre>************* MEDIATEK Confidentiality Notice\r\n" + " ********************\r\n" + "The information contained in this e-mail message (including any \r\n" + "attachments) may be confidential, proprietary, privileged, or otherwise\r\n" + "exempt from disclosure under applicable laws. It is intended to be \r\n" + "conveyed only to the designated recipient(s). Any use, dissemination, \r\n" + "distribution, printing, retaining or copying of this e-mail (including its \r\n" + "attachments) by unintended recipient(s) is strictly prohibited and may \r\n" + "be unlawful. If you are not an intended recipient of this e-mail, or believe\r\n" + " \r\n" + "that you have received this e-mail in error, please notify the sender \r\n" + "immediately (by replying to this e-mail), delete any and all copies of \r\n" + "this e-mail (including any attachments) from your system, and do not\r\n" + "disclose the content of this e-mail to any other person. Thank you!\r\n" + </pre><!--}--> + "\01:2\0" "b\0" "On Fri, 2022-11-25 at 12:18 +0000, Mark Brown wrote:\n" "> On Fri, Nov 25, 2022 at 05:44:11PM +0800, Jiaxin Yu wrote:\n" - ">\n" - "> > +/*\n" - "> > + * PCM trigger callback.\n" - "> > + * Mandatory\n" - "> > + */\n" - "> > +int (*trigger)(struct device *dev, int cmd);\n" + "> \n" + "> > +\t/*\n" + "> > +\t * PCM trigger callback.\n" + "> > +\t * Mandatory\n" + "> > +\t */\n" + "> > +\tint (*trigger)(struct device *dev, int cmd);\n" "> > +\n" - ">\n" + "> \n" "> Making this mandatory would break all existing users, though...\n" - ">\n" + "> \n" "Yes, it should be described as optional.\n" "\n" - "> > +switch (event) {\n" - "> > +case SND_SOC_DAPM_PRE_PMU:\n" - "> > +if (hcp->hcd.ops->trigger)\n" - "> > +hcp->hcd.ops->trigger(component->dev->parent,\n" + "> > +\tswitch (event) {\n" + "> > +\tcase SND_SOC_DAPM_PRE_PMU:\n" + "> > +\t\tif (hcp->hcd.ops->trigger)\n" + "> > +\t\t\thcp->hcd.ops->trigger(component->dev->parent,\n" "> > SNDRV_PCM_TRIGGER_START);\n" - ">\n" + "> \n" "> ..it's not actually mandatory so it's just the comment that's wrong.\n" "\n" "Agreed.\n" @@ -63,8 +135,8 @@ "Let me describe the hardware connection about mt8186 with it6505(hdmi)\n" "and rt1015p(speakers).\n" "\n" - " ==>it6505\n" - " =\n" + " ==>it6505 \n" + " = \n" "DL1(FE) ==>I2S3(BE) =\n" " =\n" " ==>rt1015p\n" @@ -73,24 +145,6 @@ "separately. So if hdmi-codec use the PCM trigger op, whne we turn on\n" "the speaker, hdmi-codec's PCM trigger op is also executed, resulting in\n" "sound on both devices.\n" - "Is there another way to control them separately? Thank you.\n" - "\n" - "\n" - "\n" - "\n" - "************* MEDIATEK Confidentiality Notice\n" - " ********************\n" - "The information contained in this e-mail message (including any\n" - "attachments) may be confidential, proprietary, privileged, or otherwise\n" - "exempt from disclosure under applicable laws. It is intended to be\n" - "conveyed only to the designated recipient(s). Any use, dissemination,\n" - "distribution, printing, retaining or copying of this e-mail (including its\n" - "attachments) by unintended recipient(s) is strictly prohibited and may\n" - "be unlawful. If you are not an intended recipient of this e-mail, or believe\n" - "\n" - "that you have received this e-mail in error, please notify the sender\n" - "immediately (by replying to this e-mail), delete any and all copies of\n" - "this e-mail (including any attachments) from your system, and do not\n" - disclose the content of this e-mail to any other person. Thank you! + Is there another way to control them separately? Thank you. -d51f816f5e834dc58d4d7661c7683fca4d9d0ddf6e2478daf8c0ea24a065b37e +f498e25e35da2124a605af5a1a1ddf42db4ea9a0f1217eae20d979d46c5b9b4a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.