From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Tony Ambardar <tony.ambardar@gmail.com>, bpf@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>
Subject: Re: [PATCH bpf-next v1 18/19] selftests/bpf: Fix errors compiling crypto_sanity.c with musl libc
Date: Tue, 23 Jul 2024 10:55:26 +0100 [thread overview]
Message-ID: <18d399af-d79e-40af-bb80-2e6443bef220@linux.dev> (raw)
In-Reply-To: <911293968f424ad7b462d8805aeb3baee8f4985b.1721713597.git.tony.ambardar@gmail.com>
On 23/07/2024 06:54, Tony Ambardar wrote:
> Remove a redundant include of '<linux/in6.h>', whose needed definitions are
> already provided by 'test_progs.h'. This avoids errors seen compiling for
> mips64el/musl-libc:
>
> In file included from .../arpa/inet.h:9,
> from ./test_progs.h:17,
> from prog_tests/crypto_sanity.c:10:
> .../netinet/in.h:23:8: error: redefinition of 'struct in6_addr'
> 23 | struct in6_addr {
> | ^~~~~~~~
> In file included from crypto_sanity.c:7:
> .../linux/in6.h:33:8: note: originally defined here
> 33 | struct in6_addr {
> | ^~~~~~~~
> .../netinet/in.h:34:8: error: redefinition of 'struct sockaddr_in6'
> 34 | struct sockaddr_in6 {
> | ^~~~~~~~~~~~
> .../linux/in6.h:50:8: note: originally defined here
> 50 | struct sockaddr_in6 {
> | ^~~~~~~~~~~~
> .../netinet/in.h:42:8: error: redefinition of 'struct ipv6_mreq'
> 42 | struct ipv6_mreq {
> | ^~~~~~~~~
> .../linux/in6.h:60:8: note: originally defined here
> 60 | struct ipv6_mreq {
> | ^~~~~~~~~
>
> Fixes: 91541ab192fc ("selftests: bpf: crypto skcipher algo selftests")
> Signed-off-by: Tony Ambardar <tony.ambardar@gmail.com>
> ---
> tools/testing/selftests/bpf/prog_tests/crypto_sanity.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/crypto_sanity.c b/tools/testing/selftests/bpf/prog_tests/crypto_sanity.c
> index b1a3a49a822a..42bd07f7218d 100644
> --- a/tools/testing/selftests/bpf/prog_tests/crypto_sanity.c
> +++ b/tools/testing/selftests/bpf/prog_tests/crypto_sanity.c
> @@ -4,7 +4,6 @@
> #include <sys/types.h>
> #include <sys/socket.h>
> #include <net/if.h>
> -#include <linux/in6.h>
> #include <linux/if_alg.h>
>
> #include "test_progs.h"
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2024-07-23 9:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 5:54 [PATCH bpf-next v1 00/19] selftests/bpf: Improve libc portability / musl support (part 1) Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 01/19] selftests/bpf: Use pid_t consistently in test_progs.c Tony Ambardar
2024-07-24 2:40 ` Geliang Tang
2024-07-23 5:54 ` [PATCH bpf-next v1 02/19] selftests/bpf: Fix compile error from rlim_t in sk_storage_map.c Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 03/19] selftests/bpf: Fix error compiling bpf_iter_setsockopt.c with musl libc Tony Ambardar
2024-07-24 3:11 ` Geliang Tang
2024-07-23 5:54 ` [PATCH bpf-next v1 04/19] selftests/bpf: Drop unneeded include in unpriv_helpers.c Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 05/19] selftests/bpf: Drop unneeded include in sk_lookup.c Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 06/19] selftests/bpf: Drop unneeded include in flow_dissector.c Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 07/19] selftests/bpf: Fix missing ARRAY_SIZE() definition in bench.c Tony Ambardar
2024-07-24 7:08 ` Geliang Tang
2024-07-25 1:28 ` Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 08/19] selftests/bpf: Fix missing UINT_MAX definitions in benchmarks Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 09/19] selftests/bpf: Fix missing BUILD_BUG_ON() declaration Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 10/19] selftests/bpf: Fix include of <sys/fcntl.h> Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 11/19] selftests/bpf: Fix compiling parse_tcp_hdr_opt.c with musl-libc Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 12/19] selftests/bpf: Fix compiling kfree_skb.c " Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 13/19] selftests/bpf: Fix compiling flow_dissector.c " Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 14/19] selftests/bpf: Fix compiling tcp_rtt.c " Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 15/19] selftests/bpf: Fix compiling core_reloc.c " Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 16/19] selftests/bpf: Fix errors compiling lwt_redirect.c with musl libc Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 17/19] selftests/bpf: Fix errors compiling decap_sanity.c " Tony Ambardar
2024-07-23 5:54 ` [PATCH bpf-next v1 18/19] selftests/bpf: Fix errors compiling crypto_sanity.c " Tony Ambardar
2024-07-23 9:55 ` Vadim Fedorenko [this message]
2024-07-23 5:54 ` [PATCH bpf-next v1 19/19] selftests/bpf: Fix errors compiling cg_storage_multi.h " Tony Ambardar
2024-07-23 22:35 ` YiFei Zhu
2024-07-24 23:45 ` Andrii Nakryiko
2024-07-24 23:54 ` Tony Ambardar
2024-07-23 6:45 ` [PATCH bpf-next v1 00/19] selftests/bpf: Improve libc portability / musl support (part 1) bot+bpf-ci
2024-07-24 23:52 ` Andrii Nakryiko
2024-07-25 0:28 ` Tony Ambardar
2024-07-25 0:45 ` Andrii Nakryiko
2024-07-25 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18d399af-d79e-40af-bb80-2e6443bef220@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=tony.ambardar@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.