From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D431CC761A6 for ; Mon, 27 Mar 2023 12:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ULLeo3vqhXTMMYk9opWzFf2pnXXBv0D0AlIMYr2q004=; b=gBckLf+DqysGKH XuRBCk8eIWiSNrxg24fHtYu78Frk0Lk+Kr6PxkT9aNkbGbAMbPWW6EsIuLiA6fFrGg+6sbbSvCgoY OUy9jJXME+lgEyMSimmqzO4v6UjsJf3HnKDBK1jgsDz32qrjbsIplAH6CPws2ZNonMgxe0v9SSIgG XYTEIV2nqeIn1LDQmglbmOXJjxpcneVCcIr3ACgY+YKcSKu3FcusgpSFecz3Y1yVs9FvcbTw4fsWy /IFv2sE93E0JHGxSohXRNzvKR4/heRUTnH+u0eqmt1dZmvDfZYuUgZC2k2liWHJoEebiIMgW8/hvK DtxnjHZo3IAbbwXpERyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgm0u-00AyMl-0W; Mon, 27 Mar 2023 12:31:52 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgm0r-00AyMD-08 for linux-arm-kernel@lists.infradead.org; Mon, 27 Mar 2023 12:31:50 +0000 Received: by mail-lj1-x22f.google.com with SMTP id z42so8803464ljq.13 for ; Mon, 27 Mar 2023 05:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679920307; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bu/lxvT2KaSD2GMUVzzvNMSdz4ucFQV7venpvrr8mFQ=; b=MTuNzzG2C5InfTyHnjn/U5uh47yZ17eSTDqMUwnE6nBIduN19Lr5QCAbrmqASEMvTs j1jvQ8GNBw0ZffeheoiWCYp9wk8G3XSLH4taztWEPkkuNl08a+Mqg9G8tPZrmTDAXWNO dMXA+BSXKibJMc8Q0W/6yHYmEzN8e/tCejcL67TEyu/+d+Ej61uorSTx9yKb7wxaeBHM jpqaYU7+bj+LTsZbIGosxkYPWKV9G1UNCtq+CFqTvWtzh2KDfuYalSGSyW1jdJOE6kDi LzRoeGbYcRoStFOA9H6FZDamHE8xQP06zJI1K0PgIX+c9amGs2WVCAIF8fNvNO6sie+B vvZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679920307; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bu/lxvT2KaSD2GMUVzzvNMSdz4ucFQV7venpvrr8mFQ=; b=Q3nEn5GeciBTAQe6qhcjJUwI/SkV+U26VzlgI5I0F5+F3c1GC0fVnpGCQZATXb31J7 ga7gAgwVDrTxgLMFJ3oNEtlpDAlCCpZeRbp1a1lRL8uGzeeHCTcv76DF+lyScUctg1vd JS2+MMkw7uPHaa2cUm4lTLtA7vlBmLfp7itx1l/fNCT9NcIaZtyNmowFlIlFe1oQwaPa haCSWMEoc7Xs2LJxifGADt/W2QkXTpHh8s8XvMbSM3ln1j3HT36EbrOvUskqxIU2/u7J T2hVyoanwFKZ9+jw3X08N1NU5RDGCc0WiydFhvs+sGY+ozLiT1bU9BSkvDg9mPEZm8Jn rRsA== X-Gm-Message-State: AAQBX9eCD1kO047z3Tdu/VX0RdsQ46JM3cwdTz1dwThRZ19be/1bYmWQ OvRb5vxmvSjDZvp/zhVIARI= X-Google-Smtp-Source: AKy350a7HzDXoJ5dLGxPGsJhdOTqk0zoIuOiqefrUKq/8V5f5wG3EWmGjMyrBjAI7jJMRqsU5x611Q== X-Received: by 2002:a05:651c:54e:b0:295:a08c:12a1 with SMTP id q14-20020a05651c054e00b00295a08c12a1mr4420396ljp.0.1679920306863; Mon, 27 Mar 2023 05:31:46 -0700 (PDT) Received: from [192.168.0.192] ([194.146.248.75]) by smtp.gmail.com with ESMTPSA id y1-20020a2eb001000000b002986854f27dsm4609023ljk.23.2023.03.27.05.31.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 05:31:46 -0700 (PDT) Message-ID: <18d8a2cb-91c4-a77c-4802-1ebef62a8077@gmail.com> Date: Mon, 27 Mar 2023 14:31:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 070/117] media: jpeg-core: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, kernel@pengutronix.de References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230326143224.572654-73-u.kleine-koenig@pengutronix.de> From: Andrzej Pietrasiewicz In-Reply-To: <20230326143224.572654-73-u.kleine-koenig@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230327_053149_078688_521952E3 X-CRM114-Status: GOOD ( 25.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKVyBkbml1IDI2LjAzLjIwMjMgb8KgMTY6MzEsIFV3ZSBLbGVpbmUtS8O2bmlnIHBp c3plOgo+IFRoZSAucmVtb3ZlKCkgY2FsbGJhY2sgZm9yIGEgcGxhdGZvcm0gZHJpdmVyIHJldHVy bnMgYW4gaW50IHdoaWNoIG1ha2VzCj4gbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3Vt ZSBpdCdzIHBvc3NpYmxlIHRvIGRvIGVycm9yIGhhbmRsaW5nIGJ5Cj4gcmV0dXJuaW5nIGFuIGVy cm9yIGNvZGUuIEhvd2V2ZXIgdGhlIHZhbHVlIHJldHVybmVkIGlzIChtb3N0bHkpIGlnbm9yZWQK PiBhbmQgdGhpcyB0eXBpY2FsbHkgcmVzdWx0cyBpbiByZXNvdXJjZSBsZWFrcy4gVG8gaW1wcm92 ZSBoZXJlIHRoZXJlIGlzIGEKPiBxdWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0 dXJuIHZvaWQuIEluIHRoZSBmaXJzdCBzdGVwIG9mIHRoaXMKPiBxdWVzdCBhbGwgZHJpdmVycyBh cmUgY29udmVydGVkIHRvIC5yZW1vdmVfbmV3KCkgd2hpY2ggYWxyZWFkeSByZXR1cm5zCj4gdm9p ZC4KPiAKPiBUcml2aWFsbHkgY29udmVydCB0aGlzIGRyaXZlciBmcm9tIGFsd2F5cyByZXR1cm5p bmcgemVybyBpbiB0aGUgcmVtb3ZlCj4gY2FsbGJhY2sgdG8gdGhlIHZvaWQgcmV0dXJuaW5nIHZh cmlhbnQuCj4gCj4gU2lnbmVkLW9mZi1ieTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtv ZW5pZ0BwZW5ndXRyb25peC5kZT4KCkFja2VkLWJ5OiBBbmRyemVqIFBpZXRyYXNpZXdpY3ogPGFu ZHJ6ZWp0cDIwMTBAZ21haWwuY29tPgoKPiAtLS0KPiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0v c2Ftc3VuZy9zNXAtanBlZy9qcGVnLWNvcmUuYyB8IDYgKystLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3NhbXN1bmcvczVwLWpwZWcvanBlZy1jb3JlLmMgYi9kcml2ZXJz L21lZGlhL3BsYXRmb3JtL3NhbXN1bmcvczVwLWpwZWcvanBlZy1jb3JlLmMKPiBpbmRleCA1NTgx NDA0MWI4ZDguLmMzYzdlNDhmMWI2ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRm b3JtL3NhbXN1bmcvczVwLWpwZWcvanBlZy1jb3JlLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3Bs YXRmb3JtL3NhbXN1bmcvczVwLWpwZWcvanBlZy1jb3JlLmMKPiBAQCAtMjk5MSw3ICsyOTkxLDcg QEAgc3RhdGljIGludCBzNXBfanBlZ19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2 KQo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiAtc3RhdGljIGludCBzNXBfanBlZ19yZW1v dmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArc3RhdGljIHZvaWQgczVwX2pwZWdf cmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICB7Cj4gICAJc3RydWN0IHM1 cF9qcGVnICpqcGVnID0gcGxhdGZvcm1fZ2V0X2RydmRhdGEocGRldik7Cj4gICAJaW50IGk7Cj4g QEAgLTMwMDgsOCArMzAwOCw2IEBAIHN0YXRpYyBpbnQgczVwX2pwZWdfcmVtb3ZlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAJCWZvciAoaSA9IGpwZWctPnZhcmlhbnQtPm51bV9j bG9ja3MgLSAxOyBpID49IDA7IGktLSkKPiAgIAkJCWNsa19kaXNhYmxlX3VucHJlcGFyZShqcGVn LT5jbG9ja3NbaV0pOwo+ICAgCX0KPiAtCj4gLQlyZXR1cm4gMDsKPiAgIH0KPiAgIAo+ICAgI2lm ZGVmIENPTkZJR19QTQo+IEBAIC0zMTY0LDcgKzMxNjIsNyBAQCBzdGF0aWMgdm9pZCAqanBlZ19n ZXRfZHJ2X2RhdGEoc3RydWN0IGRldmljZSAqZGV2KQo+ICAgCj4gICBzdGF0aWMgc3RydWN0IHBs YXRmb3JtX2RyaXZlciBzNXBfanBlZ19kcml2ZXIgPSB7Cj4gICAJLnByb2JlID0gczVwX2pwZWdf cHJvYmUsCj4gLQkucmVtb3ZlID0gczVwX2pwZWdfcmVtb3ZlLAo+ICsJLnJlbW92ZV9uZXcgPSBz NXBfanBlZ19yZW1vdmUsCj4gICAJLmRyaXZlciA9IHsKPiAgIAkJLm9mX21hdGNoX3RhYmxlCT0g b2ZfbWF0Y2hfcHRyKHNhbXN1bmdfanBlZ19tYXRjaCksCj4gICAJCS5uYW1lCQk9IFM1UF9KUEVH X00yTV9OQU1FLAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D42CC76195 for ; Mon, 27 Mar 2023 12:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232225AbjC0Mbv (ORCPT ); Mon, 27 Mar 2023 08:31:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232467AbjC0Mbu (ORCPT ); Mon, 27 Mar 2023 08:31:50 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA4D140EB for ; Mon, 27 Mar 2023 05:31:48 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id t14so8835745ljd.5 for ; Mon, 27 Mar 2023 05:31:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679920307; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bu/lxvT2KaSD2GMUVzzvNMSdz4ucFQV7venpvrr8mFQ=; b=MTuNzzG2C5InfTyHnjn/U5uh47yZ17eSTDqMUwnE6nBIduN19Lr5QCAbrmqASEMvTs j1jvQ8GNBw0ZffeheoiWCYp9wk8G3XSLH4taztWEPkkuNl08a+Mqg9G8tPZrmTDAXWNO dMXA+BSXKibJMc8Q0W/6yHYmEzN8e/tCejcL67TEyu/+d+Ej61uorSTx9yKb7wxaeBHM jpqaYU7+bj+LTsZbIGosxkYPWKV9G1UNCtq+CFqTvWtzh2KDfuYalSGSyW1jdJOE6kDi LzRoeGbYcRoStFOA9H6FZDamHE8xQP06zJI1K0PgIX+c9amGs2WVCAIF8fNvNO6sie+B vvZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679920307; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bu/lxvT2KaSD2GMUVzzvNMSdz4ucFQV7venpvrr8mFQ=; b=ryGOdOOcm1RPus3OdQE/rBfVlDKrwwPYN9WyvsTwyAAHftUa4FG3wTeAFJQbZQn1Hj KoWnj4Mq4PeX7YUoN9f7oZjmyw453IEFX+e5kjv2Dv9BNiDbQCN+GjpGcn4/2LU4TVNY IGddTO8pYWe/ofPpkQu0TQxrQHZZjcse4HzwPauwKYz9MYnQwGMbssYstMUXXctRKbcz nMK1hib29gtAP/SMfv1Pn5/MHA5ZLBxZLraOjeb23UKJm9DfbPkaoWDSLXZ4a6ABNQAP 0mSodmklsjXlG5ioBxz8q3eIURm7+mk7BzEtZYlbjg5F5f836rUG8qBh8UkRkGarROzY QbuQ== X-Gm-Message-State: AAQBX9cO2HBMx6Ks50bTJRM/o/8x5jdaXAWO/w2he2Khv1AVnkp/mPeT njug3eIbCnLbGFH7+/cLUAY= X-Google-Smtp-Source: AKy350a7HzDXoJ5dLGxPGsJhdOTqk0zoIuOiqefrUKq/8V5f5wG3EWmGjMyrBjAI7jJMRqsU5x611Q== X-Received: by 2002:a05:651c:54e:b0:295:a08c:12a1 with SMTP id q14-20020a05651c054e00b00295a08c12a1mr4420396ljp.0.1679920306863; Mon, 27 Mar 2023 05:31:46 -0700 (PDT) Received: from [192.168.0.192] ([194.146.248.75]) by smtp.gmail.com with ESMTPSA id y1-20020a2eb001000000b002986854f27dsm4609023ljk.23.2023.03.27.05.31.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Mar 2023 05:31:46 -0700 (PDT) Message-ID: <18d8a2cb-91c4-a77c-4802-1ebef62a8077@gmail.com> Date: Mon, 27 Mar 2023 14:31:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 070/117] media: jpeg-core: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Jacek Anaszewski , Sylwester Nawrocki , Mauro Carvalho Chehab Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, kernel@pengutronix.de References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> <20230326143224.572654-73-u.kleine-koenig@pengutronix.de> From: Andrzej Pietrasiewicz In-Reply-To: <20230326143224.572654-73-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Uwe, W dniu 26.03.2023 o 16:31, Uwe Kleine-König pisze: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Acked-by: Andrzej Pietrasiewicz > --- > drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > index 55814041b8d8..c3c7e48f1b6e 100644 > --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c > @@ -2991,7 +2991,7 @@ static int s5p_jpeg_probe(struct platform_device *pdev) > return ret; > } > > -static int s5p_jpeg_remove(struct platform_device *pdev) > +static void s5p_jpeg_remove(struct platform_device *pdev) > { > struct s5p_jpeg *jpeg = platform_get_drvdata(pdev); > int i; > @@ -3008,8 +3008,6 @@ static int s5p_jpeg_remove(struct platform_device *pdev) > for (i = jpeg->variant->num_clocks - 1; i >= 0; i--) > clk_disable_unprepare(jpeg->clocks[i]); > } > - > - return 0; > } > > #ifdef CONFIG_PM > @@ -3164,7 +3162,7 @@ static void *jpeg_get_drv_data(struct device *dev) > > static struct platform_driver s5p_jpeg_driver = { > .probe = s5p_jpeg_probe, > - .remove = s5p_jpeg_remove, > + .remove_new = s5p_jpeg_remove, > .driver = { > .of_match_table = of_match_ptr(samsung_jpeg_match), > .name = S5P_JPEG_M2M_NAME,