From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, philmd@linaro.org,
Paolo Bonzini <pbonzini@redhat.com>,
manos.pitsidianakis@linaro.org,
"Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>,
richard.henderson@linaro.org,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 2/7] hw/hyperv/hyperv.h: header cleanup
Date: Thu, 6 Mar 2025 14:40:28 -0800 [thread overview]
Message-ID: <18fd9ebb-dfe0-403f-994a-e542e890eb4e@linaro.org> (raw)
In-Reply-To: <871pva4a5g.fsf@draig.linaro.org>
On 3/6/25 04:27, Alex Bennée wrote:
> Pierrick Bouvier <pierrick.bouvier@linaro.org> writes:
>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>> include/hw/hyperv/hyperv.h | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/hw/hyperv/hyperv.h b/include/hw/hyperv/hyperv.h
>> index d717b4e13d4..c6f7039447f 100644
>> --- a/include/hw/hyperv/hyperv.h
>> +++ b/include/hw/hyperv/hyperv.h
>> @@ -10,7 +10,9 @@
>> #ifndef HW_HYPERV_HYPERV_H
>> #define HW_HYPERV_HYPERV_H
>>
>> -#include "cpu-qom.h"
>> +#include "qemu/osdep.h"
>
> We shouldn't need to include osdep.h in headers, indeed style says:
>
> Do not include "qemu/osdep.h" from header files since the .c file will have
> already included it.
>
Sure, I'll remove it.
>> +#include "exec/hwaddr.h"
>> +#include "hw/core/cpu.h"
>> #include "hw/hyperv/hyperv-proto.h"
>>
>> typedef struct HvSintRoute HvSintRoute;
>
next prev parent reply other threads:[~2025-03-06 22:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 6:41 [PATCH 0/7] hw/hyperv: remove duplication compilation units Pierrick Bouvier
2025-03-06 6:41 ` [PATCH 1/7] hw/hyperv/hv-balloon-stub: common compilation unit Pierrick Bouvier
2025-03-06 6:41 ` [PATCH 2/7] hw/hyperv/hyperv.h: header cleanup Pierrick Bouvier
2025-03-06 12:27 ` Alex Bennée
2025-03-06 22:40 ` Pierrick Bouvier [this message]
2025-03-06 6:41 ` [PATCH 3/7] hw/hyperv/vmbus: common compilation unit Pierrick Bouvier
2025-03-06 20:29 ` Maciej S. Szmigiero
2025-03-06 22:59 ` Pierrick Bouvier
2025-03-07 11:03 ` Maciej S. Szmigiero
2025-03-07 17:27 ` Pierrick Bouvier
2025-03-06 6:41 ` [PATCH 4/7] hw/hyperv/hyperv-proto: move SYNDBG definition from target/i386 Pierrick Bouvier
2025-03-06 10:42 ` Philippe Mathieu-Daudé
2025-03-06 6:41 ` [PATCH 5/7] hw/hyperv/syndbg: common compilation unit Pierrick Bouvier
2025-03-06 16:19 ` Richard Henderson
2025-03-06 16:23 ` Pierrick Bouvier
2025-03-06 17:58 ` Philippe Mathieu-Daudé
2025-03-06 22:56 ` Pierrick Bouvier
2025-03-07 11:07 ` Maciej S. Szmigiero
2025-03-07 14:50 ` Alex Bennée
2025-03-07 17:34 ` Maciej S. Szmigiero
2025-03-07 17:28 ` Pierrick Bouvier
2025-03-06 6:41 ` [PATCH 6/7] hw/hyperv/balloon: common balloon compilation units Pierrick Bouvier
2025-03-06 6:41 ` [PATCH 7/7] hw/hyperv/hyperv_testdev: common compilation unit Pierrick Bouvier
2025-03-06 16:26 ` [PATCH 0/7] hw/hyperv: remove duplication compilation units Richard Henderson
2025-03-06 16:35 ` Pierrick Bouvier
2025-03-06 16:35 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18fd9ebb-dfe0-403f-994a-e542e890eb4e@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=maciej.szmigiero@oracle.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.