From: Keith Owens <kaos@ocs.com.au>
To: Geoffrey Espin <espin@idiom.com>
Cc: linux-mips <linux-mips@oss.sgi.com>
Subject: Re: No bzImage target for MIPS
Date: Fri, 14 Dec 2001 14:51:21 +1100 [thread overview]
Message-ID: <1901.1008301881@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Thu, 13 Dec 2001 19:28:46 -0800." <20011213192846.A36207@idiom.com>
On Thu, 13 Dec 2001 19:28:46 -0800,
Geoffrey Espin <espin@idiom.com> wrote:
>=misc.c=========================================================================
>#include "../../../fs/jffs2/zlib.c" /**/
>#include "../../../lib/ctype.c"
I am phasing out the practice of ../ in kernel include paths. It is
much better to do
#include "zlib.c"
#include "ctype.c"
and the Makefile adds -I$(TOPDIR)/fs/jffs2 -I$(TOPDIR)/lib. Then when
sources are moved from one directory to another, the source does not
change, only the Makefile. Relative paths are a pain in the neck in
Makefiles, they are even more of a pain in source code.
>TOPDIR = ../../..
TOPDIR := $(shell cd ../../..; /bin/pwd)
is better, it returns an absolute path instead of a relative one.
Keith Owens, kernel build maintainer
next prev parent reply other threads:[~2001-12-14 4:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-14 0:47 No bzImage target for MIPS Krishna Kondaka
2001-12-14 1:10 ` Pete Popov
2001-12-14 3:28 ` Geoffrey Espin
2001-12-14 3:51 ` Keith Owens [this message]
2001-12-14 4:12 ` Geoffrey Espin
2001-12-14 18:05 ` Pete Popov
2001-12-14 18:52 ` Geoffrey Espin
2001-12-14 19:11 ` Pete Popov
2001-12-15 8:31 ` Karsten Merker
2001-12-15 9:14 ` Keith Owens
2001-12-15 12:46 ` Florian Lohoff
2001-12-17 20:32 ` Ralf Baechle
2001-12-17 13:12 ` Maciej W. Rozycki
2001-12-15 12:42 ` Florian Lohoff
-- strict thread matches above, loose matches on Subject: below --
2001-12-14 0:55 Marc Karasek
2001-12-14 22:59 Marc Karasek
2001-12-14 23:42 ` Pete Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1901.1008301881@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=espin@idiom.com \
--cc=linux-mips@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.