Re: [PATCH] xfs_repair: junk leaf attribute if count == 0

["Libor Klepáč" <libor.klepac@bcom.cz>]

Hello,

On úterý 13. prosince 2016 10:04:27 CET Eric Sandeen wrote:
> On 12/13/16 4:52 AM, Libor Klep�? wrote:
> > Hello,
> > should this patch possibly fix errors i reported in this thread?
> > https://www.spinics.net/lists/linux-xfs/msg01728.html
> > 
> > Is it safe to test it? (i do have backups)
> 
> It should be safe, yes.
>
ok,  will try it soon(ish) with machines named vps1 and vps3 in my mails. vps2 
is problematic to shutdown and test.
 
> (you could always run xfs_repair -n first to be extra careful).
> 
> Were those errors during mount/replay, though, or was it when the
> filesystem was up and running?
> 
It was always when running, some errors were just logged, some caused fs 
shutdown

> I ask because I also sent a patch to ignore these empty attributes
> in the verifier during log replay.
> 

> FWIW, Only some of your reported buffers look "empty" though, the one
> at 514098.682726 may have had something else wrong.
> 
Ok, i see, it has some "data" in it

> Anyway, yes, probably worth checking with xfs_repair (-n) with this
> patch added.  Let us know what you find! :)
> 
> -Eric
> 

Libor