From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sf@sfritsch.de>) id 1WQP8d-0002wk-RJ
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:39:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sf@sfritsch.de>) id 1WQP8X-0003OU-Qy
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:39:07 -0400
Received: from eru.sfritsch.de ([188.40.99.202]:52696)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sf@sfritsch.de>) id 1WQP8X-0003O9-LD
	for qemu-devel@nongnu.org; Wed, 19 Mar 2014 18:39:01 -0400
From: Stefan Fritsch <sf@sfritsch.de>
Date: Wed, 19 Mar 2014 23:38:57 +0100
Message-ID: <1907885.BLXM6R4UH8@k>
In-Reply-To: <20140225030633.GA29423@amosk.info>
References: <alpine.DEB.2.02.1402052200180.19415@eru.sfritsch.de>
	<alpine.DEB.2.02.1402230924170.10869@eru.sfritsch.de>
	<20140225030633.GA29423@amosk.info>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without
	F_CTRL_VLAN
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Cc: vyasevic@redhat.com, Amos Kong <akong@redhat.com>, Anthony Liguori <aliguori@amazon.com>

Hi,

Am Dienstag, 25. Februar 2014, 11:06:33 schrieb Amos Kong:
> > > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote:
> > > > If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out
> > > > all
> > > > VLAN-tagged packets but send them to the guest.


AFAICS, no fix has been committed, yet. Is there anything I need to do 
to get this fixed?


> > > Can we just update receive_filter() to filter out VLAN-tagged
> > > packets only when VIRTIO_NET_F_CTRL_VLAN is negotiated?
> 
> If we change receive_filter(), we also need a flag to indicate
> management this feature isn't negotiated, management will do some
> additional operation to host device to get same effect.
>  
> 
> > We could. But this adds a (very small) per-packet overhead while
> > my patch  only adds overhead during reset. Therefore I didn't
> > take that approach. But if changing receive_filter() makes
> > management much easier, that could be acceptable.
> 
> Actually your solution is better, QEMU will return a long list
> [0,1,2,...4095] to management, host device will filter all the vlan
> packets and send to QEMU.
> 
> So the problem raised by mst doesn't exist.

Cheers,
Stefan