From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry Date: Mon, 12 Mar 2018 17:58:22 +0100 Message-ID: <1909495.WV5cT3kS9W@diego> References: <20180309222327.18689-1-enric.balletbo@collabora.com> <20180309222327.18689-7-enric.balletbo@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180309222327.18689-7-enric.balletbo@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Enric Balletbo i Serra Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, Laurent.pinchart@ideasonboard.com, ykk@rock-chips.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, linux-input@vger.kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, linux-kernel@vger.kernel.org, jeffy.chen@rock-chips.com, =?ISO-8859-1?Q?St=E9phane?= Marchesin , Sonny Rao , linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com, wzz@rock-chips.com, hl@rock-chips.com, jingoohan1@gmail.com, sw0312.kim@samsung.com, dianders@chromium.org, tfiga@chromium.org, kyungmin.park@samsung.com, kuankuan.y@gmail.com, hshi@chromium.org List-Id: linux-input@vger.kernel.org SGksCgp0aGUgc3ViamVjdCBpcyBtaXNsZWFkaW5nIEkgdGhpbmssIGFzIHRoaXMgaXMgdG91Y2hp bmcgb25seSB0aGUgZ2VuZXJpYwpicmlkZ2UgY29kZSBhbmQgbm90IGFueXRoaW5nIFJvY2tjaGlw LXJlbGF0ZWQsIHNvIHNob3VsZCBwcm9iYWJseQpiZSAiZHJtL2JyaWRnZSI/CgpBbSBGcmVpdGFn LCA5LiBNw6RyeiAyMDE4LCAyMzoyMjo1NyBDRVQgc2NocmllYiBFbnJpYyBCYWxsZXRibyBpIFNl cnJhOgo+IEZyb206IHphaW4gd2FuZyA8d3p6QHJvY2stY2hpcHMuY29tPgo+IAo+IFdlIGN1cnJl bnRseSB3YWl0IGZvciB0aGUgcGFuZWwgdG8gbWlycm9yIG91ciBpbnRlbmRlZCBQU1Igc3RhdGUK PiBiZWZvcmUgY29udGludWluZyBvbiBib3RoIFBTUiBlbnRlciBhbmQgUFNSIGV4aXQuIFRoaXMg aXMgcmVhbGx5Cj4gb25seSBpbXBvcnRhbnQgdG8gZG8gd2hlbiB3ZSdyZSBlbnRlcmluZyBQU1Is IHNpbmNlIHdlIHdhbnQgdG8KPiBiZSBzdXJlIHRoZSBsYXN0IGZyYW1lIHdlIHB1c2hlZCBpcyBi ZWluZyBzZXJ2ZWQgZnJvbSB0aGUgcGFuZWwncwo+IGludGVybmFsIGZiIGJlZm9yZSBzaHV0dGlu ZyBkb3duIHRoZSBzb2MgYmxvY2tzICh2b3AvYW5hbG9naXgpLgo+IAo+IFRoaXMgcGF0Y2ggY2hh bmdlcyB0aGUgYmVoYXZpb3Igc3VjaCB0aGF0IHdlIG9ubHkgd2FpdCBmb3IgdGhlCj4gcGFuZWwg dG8gY29tcGxldGUgdGhlIFBTUiB0cmFuc2l0aW9uIHdoZW4gd2UncmUgZW50ZXJpbmcgUFNSLCBh bmQKPiB0byBza2lwIHZlcmlmaWNhdGlvbiB3aGVuIHdlJ3JlIGV4aXRpbmcuCj4gCj4gQ2M6IFN0 w6lwaGFuZSBNYXJjaGVzaW4gPG1hcmNoZXVAY2hyb21pdW0ub3JnPgo+IENjOiBTb25ueSBSYW8g PHNvbm55cmFvQGNocm9taXVtLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiB6YWluIHdhbmcgPHd6ekBy b2NrLWNoaXBzLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBTZWFuIFBhdWwgPHNlYW5wYXVsQGNocm9t aXVtLm9yZz4KPiBTaWduZWQtb2ZmLWJ5OiBUaGllcnJ5IEVzY2FuZGUgPHRoaWVycnkuZXNjYW5k ZUBjb2xsYWJvcmEuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEVucmljIEJhbGxldGJvIGkgU2VycmEg PGVucmljLmJhbGxldGJvQGNvbGxhYm9yYS5jb20+Cj4gVGVzdGVkLWJ5OiBNYXJlayBTenlwcm93 c2tpIDxtLnN6eXByb3dza2lAc2Ftc3VuZy5jb20+CgpjaGFuZ2UgaXRzZWxmIGxvb2tzIGdvb2Qs IHNvClJldmlld2VkLWJ5OiBIZWlrbyBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Mon, 12 Mar 2018 17:58:22 +0100 Subject: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry In-Reply-To: <20180309222327.18689-7-enric.balletbo@collabora.com> References: <20180309222327.18689-1-enric.balletbo@collabora.com> <20180309222327.18689-7-enric.balletbo@collabora.com> Message-ID: <1909495.WV5cT3kS9W@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, the subject is misleading I think, as this is touching only the generic bridge code and not anything Rockchip-related, so should probably be "drm/bridge"? Am Freitag, 9. M?rz 2018, 23:22:57 CET schrieb Enric Balletbo i Serra: > From: zain wang > > We currently wait for the panel to mirror our intended PSR state > before continuing on both PSR enter and PSR exit. This is really > only important to do when we're entering PSR, since we want to > be sure the last frame we pushed is being served from the panel's > internal fb before shutting down the soc blocks (vop/analogix). > > This patch changes the behavior such that we only wait for the > panel to complete the PSR transition when we're entering PSR, and > to skip verification when we're exiting. > > Cc: St?phane Marchesin > Cc: Sonny Rao > Signed-off-by: zain wang > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > Signed-off-by: Enric Balletbo i Serra > Tested-by: Marek Szyprowski change itself looks good, so Reviewed-by: Heiko Stuebner From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932526AbeCLQ6g convert rfc822-to-8bit (ORCPT ); Mon, 12 Mar 2018 12:58:36 -0400 Received: from gloria.sntech.de ([95.129.55.99]:39434 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932190AbeCLQ6e (ORCPT ); Mon, 12 Mar 2018 12:58:34 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Enric Balletbo i Serra Cc: architt@codeaurora.org, inki.dae@samsung.com, thierry.reding@gmail.com, hjc@rock-chips.com, seanpaul@chromium.org, airlied@linux.ie, tfiga@chromium.org, dri-devel@lists.freedesktop.org, dianders@chromium.org, a.hajda@samsung.com, ykk@rock-chips.com, kernel@collabora.com, m.szyprowski@samsung.com, linux-samsung-soc@vger.kernel.org, jy0922.shim@samsung.com, rydberg@bitmath.org, krzk@kernel.org, linux-rockchip@lists.infradead.org, kgene@kernel.org, linux-input@vger.kernel.org, orjan.eide@arm.com, wxt@rock-chips.com, jeffy.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com, wzz@rock-chips.com, hl@rock-chips.com, jingoohan1@gmail.com, sw0312.kim@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, Laurent.pinchart@ideasonboard.com, kuankuan.y@gmail.com, hshi@chromium.org, =?ISO-8859-1?Q?St=E9phane?= Marchesin , Sonny Rao Subject: Re: [PATCH v5 06/36] drm/rockchip: Only wait for panel ACK on PSR entry Date: Mon, 12 Mar 2018 17:58:22 +0100 Message-ID: <1909495.WV5cT3kS9W@diego> In-Reply-To: <20180309222327.18689-7-enric.balletbo@collabora.com> References: <20180309222327.18689-1-enric.balletbo@collabora.com> <20180309222327.18689-7-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, the subject is misleading I think, as this is touching only the generic bridge code and not anything Rockchip-related, so should probably be "drm/bridge"? Am Freitag, 9. März 2018, 23:22:57 CET schrieb Enric Balletbo i Serra: > From: zain wang > > We currently wait for the panel to mirror our intended PSR state > before continuing on both PSR enter and PSR exit. This is really > only important to do when we're entering PSR, since we want to > be sure the last frame we pushed is being served from the panel's > internal fb before shutting down the soc blocks (vop/analogix). > > This patch changes the behavior such that we only wait for the > panel to complete the PSR transition when we're entering PSR, and > to skip verification when we're exiting. > > Cc: Stéphane Marchesin > Cc: Sonny Rao > Signed-off-by: zain wang > Signed-off-by: Sean Paul > Signed-off-by: Thierry Escande > Signed-off-by: Enric Balletbo i Serra > Tested-by: Marek Szyprowski change itself looks good, so Reviewed-by: Heiko Stuebner