From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 534A97464; Mon, 18 Dec 2023 06:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="loBrPuyc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ADCEC433C8; Mon, 18 Dec 2023 06:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702882389; bh=EpFEN3Jue2G6Rxerxg89hbnN15oJOVy46RhaWGQO2tw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=loBrPuycmVkyYVqG8sgfHh3oEDZfWG5B8CoIyakdwRnEweatH2xsCuIZr02Fy23+s NP6GBo2huii33qSC8iG8JeB8qFZasdKInhhYftE3Q8ChdHj8/tCwUsmKJl6c8YLKxy cVlJTOYI8GtA3yDDTwe6nVlimJa8Rz5X2BUKqoUuQwFaMSrfaStI0bPQlO9a2rflyi xT2Ps/TW6alm8uF+2a2DYLo5ROKLijEteSNVxVnWCGFPt3iup5B11HrcZF/360Z7Jf zAUZNPBt9TAyJg61SfSNPXKR06JSvPTEKJqzevSpQ10Jd357eLVI5OPHS0/Yf/Iojn MqyxR4tcyMymA== Message-ID: <190f58f7-2ed6-46f8-af59-5e167a0bddeb@kernel.org> Date: Mon, 18 Dec 2023 15:53:06 +0900 Precedence: bulk X-Mailing-List: dm-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] block: remove support for the host aware zone model Content-Language: en-US To: =?UTF-8?B?RWQgVHNhaSAo6JSh5a6X6LuSKQ==?= , "hch@lst.de" , "axboe@kernel.dk" Cc: "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "martin.petersen@oracle.com" , =?UTF-8?B?Q2FzcGVyIExpICjmnY7kuK3mpq4p?= , =?UTF-8?B?Q2h1bi1IdW5nIFd1ICjlt6vpp7/lro8p?= , "linux-scsi@vger.kernel.org" , "dm-devel@lists.linux.dev" , "linux-nvme@lists.infradead.org" , "pbonzini@redhat.com" , "linux-btrfs@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , "stefanha@redhat.com" References: <20231217165359.604246-1-hch@lst.de> <20231217165359.604246-4-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2023/12/18 15:15, Ed Tsai (蔡宗軒) wrote: > Hi Christoph, > > some minor suggestions: > > On Sun, 2023-12-17 at 17:53 +0100, Christoph Hellwig wrote: >> >> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c >> index 198d38b53322c1..260b5b8f2b0d7e 100644 >> --- a/drivers/md/dm-table.c >> +++ b/drivers/md/dm-table.c >> @@ -1579,21 +1579,18 @@ bool dm_table_has_no_data_devices(struct >> dm_table *t) >> return true; >> } >> >> -static int device_not_zoned_model(struct dm_target *ti, struct >> dm_dev *dev, >> - sector_t start, sector_t len, void >> *data) >> +static int device_not_zoned(struct dm_target *ti, struct dm_dev >> *dev, >> + sector_t start, sector_t len, void *data) >> { >> - struct request_queue *q = bdev_get_queue(dev->bdev); >> - enum blk_zoned_model *zoned_model = data; >> + bool *zoned = data; >> >> - return blk_queue_zoned_model(q) != *zoned_model; >> + return bdev_is_zoned(dev->bdev) != *zoned; >> } >> >> static int device_is_zoned_model(struct dm_target *ti, struct dm_dev >> *dev, >> sector_t start, sector_t len, void >> *data) > > Seems like the word "model" should also be remove here. > >> { >> - struct request_queue *q = bdev_get_queue(dev->bdev); >> - >> - return blk_queue_zoned_model(q) != BLK_ZONED_NONE; >> + return bdev_is_zoned(dev->bdev); >> } >> >> /* >> @@ -1603,8 +1600,7 @@ static int device_is_zoned_model(struct >> dm_target *ti, struct dm_dev *dev, >> * has the DM_TARGET_MIXED_ZONED_MODEL feature set, the devices can >> have any >> * zoned model with all zoned devices having the same zone size. >> */ >> -static bool dm_table_supports_zoned_model(struct dm_table *t, >> - enum blk_zoned_model >> zoned_model) >> +static bool dm_table_supports_zoned(struct dm_table *t, bool zoned) >> { >> for (unsigned int i = 0; i < t->num_targets; i++) { >> struct dm_target *ti = dm_table_get_target(t, i); >> @@ -1623,11 +1619,11 @@ static bool >> dm_table_supports_zoned_model(struct dm_table *t, >> >> if (dm_target_supports_zoned_hm(ti->type)) { >> if (!ti->type->iterate_devices || >> - ti->type->iterate_devices(ti, >> device_not_zoned_model, >> - &zoned_model)) >> + ti->type->iterate_devices(ti, >> device_not_zoned, >> + &zoned)) >> return false; >> } else if (!dm_target_supports_mixed_zoned_model(ti- >>> type)) { >> - if (zoned_model == BLK_ZONED_HM) >> + if (zoned) >> return false; >> } >> } > > The parameter "bool zoned" is redundant. It should be removed from the > above 3 functions > > Additionally, because we no longer need to distinguish the zoned model > here, DM_TARGET_MIXED_ZONED_MODEL is meaningless. We can also clean up > its related code. Nope. The mixed thing is for mixing up non-zoned with zoned models. For the entire DM code, HM and HA are both treated as HM-like zoned. -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61C96C35274 for ; Mon, 18 Dec 2023 06:53:29 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1rF7VI-0004hF-Q4; Mon, 18 Dec 2023 06:53:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rF7VH-0004h9-Ew for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Dec 2023 06:53:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Egr0NLFekHxbvioypBIptqX4P98m9+GvwDJy/D/IsaI=; b=lv5cIH6vhJXCQ0A9akq4LDte/T L+Hn+gpihhedE3CRjMgmgPbpfVi2qoj5MrLRgMi5wzL2wKgBt7mlgrxJiZccxe2i7we9n0wXyB06x WvpMUsSIHO3KSl0ldGtfK7nbWjEL3gw3JlC6bH4Gmtjy6fqcy5lyh8KFDar6FrRVN1sE=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Egr0NLFekHxbvioypBIptqX4P98m9+GvwDJy/D/IsaI=; b=i0tcgZuPn+C4Gr3PfQPruamUN0 CWMnXo1+Q2hFBt1W9Kq7Sb1OlhWGLtbqGnCu5T6DRMfu9U1f2FPQLs38z6cdcWXY3pDG0QN+fAV0j fOnpGjUjjWYb3kvwXuptKVi4DeDlpsMAD/+dgyZixdir1hFdwNAz9fDJA6TrrtXWhmNY=; Received: from sin.source.kernel.org ([145.40.73.55]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1rF7VF-0000cF-HA for linux-f2fs-devel@lists.sourceforge.net; Mon, 18 Dec 2023 06:53:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 836A5CE0EDA; Mon, 18 Dec 2023 06:53:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8ADCEC433C8; Mon, 18 Dec 2023 06:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702882389; bh=EpFEN3Jue2G6Rxerxg89hbnN15oJOVy46RhaWGQO2tw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=loBrPuycmVkyYVqG8sgfHh3oEDZfWG5B8CoIyakdwRnEweatH2xsCuIZr02Fy23+s NP6GBo2huii33qSC8iG8JeB8qFZasdKInhhYftE3Q8ChdHj8/tCwUsmKJl6c8YLKxy cVlJTOYI8GtA3yDDTwe6nVlimJa8Rz5X2BUKqoUuQwFaMSrfaStI0bPQlO9a2rflyi xT2Ps/TW6alm8uF+2a2DYLo5ROKLijEteSNVxVnWCGFPt3iup5B11HrcZF/360Z7Jf zAUZNPBt9TAyJg61SfSNPXKR06JSvPTEKJqzevSpQ10Jd357eLVI5OPHS0/Yf/Iojn MqyxR4tcyMymA== Message-ID: <190f58f7-2ed6-46f8-af59-5e167a0bddeb@kernel.org> Date: Mon, 18 Dec 2023 15:53:06 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: =?UTF-8?B?RWQgVHNhaSAo6JSh5a6X6LuSKQ==?= , "hch@lst.de" , "axboe@kernel.dk" References: <20231217165359.604246-1-hch@lst.de> <20231217165359.604246-4-hch@lst.de> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: X-Headers-End: 1rF7VF-0000cF-HA Subject: Re: [f2fs-dev] [PATCH 3/5] block: remove support for the host aware zone model X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "dm-devel@lists.linux.dev" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , =?UTF-8?B?Q2FzcGVyIExpICjmnY7kuK3mpq4p?= , =?UTF-8?B?Q2h1bi1IdW5nIFd1ICjlt6vpp7/lro8p?= , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "virtualization@lists.linux.dev" , "stefanha@redhat.com" , "pbonzini@redhat.com" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-btrfs@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMjAyMy8xMi8xOCAxNToxNSwgRWQgVHNhaSAo6JSh5a6X6LuSKSB3cm90ZToKPiBIaSBDaHJp c3RvcGgsCj4gCj4gc29tZSBtaW5vciBzdWdnZXN0aW9uczoKPiAKPiBPbiBTdW4sIDIwMjMtMTIt MTcgYXQgMTc6NTMgKzAxMDAsIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOgo+Pgo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9tZC9kbS10YWJsZS5jIGIvZHJpdmVycy9tZC9kbS10YWJsZS5jCj4+IGlu ZGV4IDE5OGQzOGI1MzMyMmMxLi4yNjBiNWI4ZjJiMGQ3ZSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVy cy9tZC9kbS10YWJsZS5jCj4+ICsrKyBiL2RyaXZlcnMvbWQvZG0tdGFibGUuYwo+PiBAQCAtMTU3 OSwyMSArMTU3OSwxOCBAQCBib29sIGRtX3RhYmxlX2hhc19ub19kYXRhX2RldmljZXMoc3RydWN0 Cj4+IGRtX3RhYmxlICp0KQo+PiAgCXJldHVybiB0cnVlOwo+PiAgfQo+PiAgCj4+IC1zdGF0aWMg aW50IGRldmljZV9ub3Rfem9uZWRfbW9kZWwoc3RydWN0IGRtX3RhcmdldCAqdGksIHN0cnVjdAo+ PiBkbV9kZXYgKmRldiwKPj4gLQkJCQkgIHNlY3Rvcl90IHN0YXJ0LCBzZWN0b3JfdCBsZW4sIHZv aWQKPj4gKmRhdGEpCj4+ICtzdGF0aWMgaW50IGRldmljZV9ub3Rfem9uZWQoc3RydWN0IGRtX3Rh cmdldCAqdGksIHN0cnVjdCBkbV9kZXYKPj4gKmRldiwKPj4gKwkJCSAgICBzZWN0b3JfdCBzdGFy dCwgc2VjdG9yX3QgbGVuLCB2b2lkICpkYXRhKQo+PiAgewo+PiAtCXN0cnVjdCByZXF1ZXN0X3F1 ZXVlICpxID0gYmRldl9nZXRfcXVldWUoZGV2LT5iZGV2KTsKPj4gLQllbnVtIGJsa196b25lZF9t b2RlbCAqem9uZWRfbW9kZWwgPSBkYXRhOwo+PiArCWJvb2wgKnpvbmVkID0gZGF0YTsKPj4gIAo+ PiAtCXJldHVybiBibGtfcXVldWVfem9uZWRfbW9kZWwocSkgIT0gKnpvbmVkX21vZGVsOwo+PiAr CXJldHVybiBiZGV2X2lzX3pvbmVkKGRldi0+YmRldikgIT0gKnpvbmVkOwo+PiAgfQo+PiAgCj4+ ICBzdGF0aWMgaW50IGRldmljZV9pc196b25lZF9tb2RlbChzdHJ1Y3QgZG1fdGFyZ2V0ICp0aSwg c3RydWN0IGRtX2Rldgo+PiAqZGV2LAo+PiAgCQkJCSBzZWN0b3JfdCBzdGFydCwgc2VjdG9yX3Qg bGVuLCB2b2lkCj4+ICpkYXRhKQo+IAo+IFNlZW1zIGxpa2UgdGhlIHdvcmQgIm1vZGVsIiBzaG91 bGQgYWxzbyBiZSByZW1vdmUgaGVyZS4KPiAKPj4gIHsKPj4gLQlzdHJ1Y3QgcmVxdWVzdF9xdWV1 ZSAqcSA9IGJkZXZfZ2V0X3F1ZXVlKGRldi0+YmRldik7Cj4+IC0KPj4gLQlyZXR1cm4gYmxrX3F1 ZXVlX3pvbmVkX21vZGVsKHEpICE9IEJMS19aT05FRF9OT05FOwo+PiArCXJldHVybiBiZGV2X2lz X3pvbmVkKGRldi0+YmRldik7Cj4+ICB9Cj4+ICAKPj4gIC8qCj4+IEBAIC0xNjAzLDggKzE2MDAs NyBAQCBzdGF0aWMgaW50IGRldmljZV9pc196b25lZF9tb2RlbChzdHJ1Y3QKPj4gZG1fdGFyZ2V0 ICp0aSwgc3RydWN0IGRtX2RldiAqZGV2LAo+PiAgICogaGFzIHRoZSBETV9UQVJHRVRfTUlYRURf Wk9ORURfTU9ERUwgZmVhdHVyZSBzZXQsIHRoZSBkZXZpY2VzIGNhbgo+PiBoYXZlIGFueQo+PiAg ICogem9uZWQgbW9kZWwgd2l0aCBhbGwgem9uZWQgZGV2aWNlcyBoYXZpbmcgdGhlIHNhbWUgem9u ZSBzaXplLgo+PiAgICovCj4+IC1zdGF0aWMgYm9vbCBkbV90YWJsZV9zdXBwb3J0c196b25lZF9t b2RlbChzdHJ1Y3QgZG1fdGFibGUgKnQsCj4+IC0JCQkJCSAgZW51bSBibGtfem9uZWRfbW9kZWwK Pj4gem9uZWRfbW9kZWwpCj4+ICtzdGF0aWMgYm9vbCBkbV90YWJsZV9zdXBwb3J0c196b25lZChz dHJ1Y3QgZG1fdGFibGUgKnQsIGJvb2wgem9uZWQpCj4+ICB7Cj4+ICAJZm9yICh1bnNpZ25lZCBp bnQgaSA9IDA7IGkgPCB0LT5udW1fdGFyZ2V0czsgaSsrKSB7Cj4+ICAJCXN0cnVjdCBkbV90YXJn ZXQgKnRpID0gZG1fdGFibGVfZ2V0X3RhcmdldCh0LCBpKTsKPj4gQEAgLTE2MjMsMTEgKzE2MTks MTEgQEAgc3RhdGljIGJvb2wKPj4gZG1fdGFibGVfc3VwcG9ydHNfem9uZWRfbW9kZWwoc3RydWN0 IGRtX3RhYmxlICp0LAo+PiAgCj4+ICAJCWlmIChkbV90YXJnZXRfc3VwcG9ydHNfem9uZWRfaG0o dGktPnR5cGUpKSB7Cj4+ICAJCQlpZiAoIXRpLT50eXBlLT5pdGVyYXRlX2RldmljZXMgfHwKPj4g LQkJCSAgICB0aS0+dHlwZS0+aXRlcmF0ZV9kZXZpY2VzKHRpLAo+PiBkZXZpY2Vfbm90X3pvbmVk X21vZGVsLAo+PiAtCQkJCQkJICAgICAgJnpvbmVkX21vZGVsKSkKPj4gKwkJCSAgICB0aS0+dHlw ZS0+aXRlcmF0ZV9kZXZpY2VzKHRpLAo+PiBkZXZpY2Vfbm90X3pvbmVkLAo+PiArCQkJCQkJICAg ICAgJnpvbmVkKSkKPj4gIAkJCQlyZXR1cm4gZmFsc2U7Cj4+ICAJCX0gZWxzZSBpZiAoIWRtX3Rh cmdldF9zdXBwb3J0c19taXhlZF96b25lZF9tb2RlbCh0aS0KPj4+IHR5cGUpKSB7Cj4+IC0JCQlp ZiAoem9uZWRfbW9kZWwgPT0gQkxLX1pPTkVEX0hNKQo+PiArCQkJaWYgKHpvbmVkKQo+PiAgCQkJ CXJldHVybiBmYWxzZTsKPj4gIAkJfQo+PiAgCX0KPiAKPiBUaGUgcGFyYW1ldGVyICJib29sIHpv bmVkIiBpcyByZWR1bmRhbnQuIEl0IHNob3VsZCBiZSByZW1vdmVkIGZyb20gdGhlCj4gYWJvdmUg MyBmdW5jdGlvbnMKPiAKPiBBZGRpdGlvbmFsbHksIGJlY2F1c2Ugd2Ugbm8gbG9uZ2VyIG5lZWQg dG8gZGlzdGluZ3Vpc2ggdGhlIHpvbmVkIG1vZGVsCj4gaGVyZSwgRE1fVEFSR0VUX01JWEVEX1pP TkVEX01PREVMIGlzIG1lYW5pbmdsZXNzLiBXZSBjYW4gYWxzbyBjbGVhbiB1cAo+IGl0cyByZWxh dGVkIGNvZGUuCgpOb3BlLiBUaGUgbWl4ZWQgdGhpbmcgaXMgZm9yIG1peGluZyB1cCBub24tem9u ZWQgd2l0aCB6b25lZCBtb2RlbHMuCkZvciB0aGUgZW50aXJlIERNIGNvZGUsIEhNIGFuZCBIQSBh cmUgYm90aCB0cmVhdGVkIGFzIEhNLWxpa2Ugem9uZWQuCgotLSAKRGFtaWVuIExlIE1vYWwKV2Vz dGVybiBEaWdpdGFsIFJlc2VhcmNoCgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkxpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0CkxpbnV4LWYyZnMt ZGV2ZWxAbGlzdHMuc291cmNlZm9yZ2UubmV0Cmh0dHBzOi8vbGlzdHMuc291cmNlZm9yZ2UubmV0 L2xpc3RzL2xpc3RpbmZvL2xpbnV4LWYyZnMtZGV2ZWwK