From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 001438AD0 for ; Tue, 15 Nov 2022 21:38:32 +0000 (UTC) Received: by mail-ed1-f47.google.com with SMTP id i21so23842473edj.10 for ; Tue, 15 Nov 2022 13:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q0qqcluEnKDWuRRDz3pvE3cXQ8iH9uHWt3hqRxoLeo8=; b=gJP6ZkyFtTpF18nmTzBe/C15w/ppBZ0izikt5RYF188kCgQHvCZ5gINPbDmtvBJ1k9 eaDAB3H4huNHELIlrinYLLWWvNTiNJBjjD9ssyMeD0zizbWoprs51Wgw3iGNcjKDvgP7 AxLGnxMxoSIaNzQc+JELR3+hYcODZQ/eKMpDUZfxLCaaPMy9X363aFAhFTBEGS1v31Ce KiLDTWfZTjmlq1hLURSWnykEmfbe374SyJt9XXNI4oXpQQ1H2ZTQMvg4ThYH0i3xQ4km bxFSJjPrrm2ps89EKqD6MyIM8ihjXwM0A8//PwC3lOISKjWi6qMiEAN4vYythSaNaeFh iiBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q0qqcluEnKDWuRRDz3pvE3cXQ8iH9uHWt3hqRxoLeo8=; b=M90++JcvdMpoCvfl/k+2SW4vPgFUr22IXa6b9ckwx2+s20BuAByykBYtcdeL2ockhP NNdHk1NOuc3fx4ec2pwb7nctIXGOKWWZgdTmVvPHdBmPZeO/GTPyw3j0zMpgPvUqDvO0 kEnGM6TfzDP2wIpuLBViJGMP9srRGLEE4iFixscBCTl5YgQNy5HJAxlSoZ75D2HFJBE1 r4SEmqNni+yxDlaTzHbBpAGZunPYA+winEyqyyyLHw+dIH7dav3OQ2LbLuY/+bejpaDI T/jHzYgLACBP9j0GA833ATIxSbGGla54i1RZTB/R0J1yC7Y7A35s+Ub51JUprqorCQBG 8vXA== X-Gm-Message-State: ANoB5plYS3inQhlxoQJ+QwK4ndJm1YmPjPWepjt70lp8+zE3wlUk+ziV RV1XcZWdX0EXngRlmV4NLwk= X-Google-Smtp-Source: AA0mqf7+GgVYuxL5xasn4VNMBRz2Sy90Pg6Fu+lL4brjmrxjY5GbT2MB3TR585xiHGp5XW6K6Q+wWw== X-Received: by 2002:a05:6402:360d:b0:461:b033:90ac with SMTP id el13-20020a056402360d00b00461b03390acmr16819244edb.257.1668548311172; Tue, 15 Nov 2022 13:38:31 -0800 (PST) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id 7-20020a170906310700b007389c5a45f0sm6082972ejx.148.2022.11.15.13.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 13:38:30 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland Cc: Ivaylo Dimitrov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Andre Przywara Subject: Re: [PATCH v3 3/3] bus: sunxi-rsb: Clear interrupt status before each transfer Date: Tue, 15 Nov 2022 22:38:29 +0100 Message-ID: <1910101.PYKUYFuaPT@jernej-laptop> In-Reply-To: <735349b0-6738-8ace-a7d3-aafae2a62501@sholland.org> References: <20221114015749.28490-1-samuel@sholland.org> <2170633.72vocr9iq0@jernej-laptop> <735349b0-6738-8ace-a7d3-aafae2a62501@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne torek, 15. november 2022 ob 07:08:12 CET je Samuel Holland napisal(a): > On 11/14/22 15:00, Jernej =C5=A0krabec wrote: > > Hi Samuel, > >=20 > > Dne ponedeljek, 14. november 2022 ob 02:57:49 CET je Samuel Holland > >=20 > > napisal(a): > >> Currently, the driver clears the interrupt status bits after anything > >> could have set them. However, this requires duplicating the same logic > >> in several places. > >>=20 > >> Instead of clearing the status flags in the interrupt handler, disable > >> all further interrupts by clearing the RSB_CTRL_GLOBAL_INT_ENB bit. > >=20 > > where is this bit cleared? >=20 > It is cleared by any write to RSB_CTRL that does not include it. I noted > it below with the "disable interrupts" comments. Right. >=20 > >> Then we can delay the status register write until the start of the next > >> transfer, so it only has to be done in one place. > >>=20 > >> Signed-off-by: Samuel Holland > >> --- > >>=20 > >> Changes in v3: > >> - Add a patch refactoring how the status bits are cleared > >> =20 > >> drivers/bus/sunxi-rsb.c | 20 +++++--------------- > >> 1 file changed, 5 insertions(+), 15 deletions(-) > >>=20 > >> diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c > >> index 3aa91aed3bf7..cb622e60897b 100644 > >> --- a/drivers/bus/sunxi-rsb.c > >> +++ b/drivers/bus/sunxi-rsb.c > >> @@ -279,6 +279,7 @@ static int _sunxi_rsb_run_xfer(struct sunxi_rsb *r= sb) > >>=20 > >> int_mask =3D RSB_INTS_LOAD_BSY | RSB_INTS_TRANS_ERR | > >> RSB_INTS_TRANS_OVER; > >> writel(int_mask, rsb->regs + RSB_INTE); > >>=20 > >> + writel(int_mask, rsb->regs + RSB_INTS); > >=20 > > Wouldn't be better to clear status before enabling interrupts? Unless > > global interrupt flag is cleared beforehand, but I don't see that > > anywhere. > Indeed the intention was that the global interrupt flag is cleared > beforehand, and only enabled on the next line below. However, I realize > I missed disabling it for the new atomic case. >=20 > I'm not so sure anymore that this patch is an improvement. What do you > think? I can send a v4 with a fix, or I am fine with skipping this > patch. I would at least like the other two to be merged for -fixes. Sure, first two patches will go in regardless. I'm not convinced of value o= f=20 this patch either. I guess we can skip it. Best regards, Jernej >=20 > Regards, > Samuel >=20 > >> writel(RSB_CTRL_START_TRANS | RSB_CTRL_GLOBAL_INT_ENB, > >> =09 > >> rsb->regs + RSB_CTRL); > >>=20 > >> @@ -286,7 +287,6 @@ static int _sunxi_rsb_run_xfer(struct sunxi_rsb *r= sb) > >>=20 > >> timeout =3D readl_poll_timeout_atomic(rsb->regs +=20 RSB_INTS, > >> =09 > >> =20 status, (status & int_mask), > >> 10,=20 100000); > >>=20 > >> - writel(status, rsb->regs + RSB_INTS); > >>=20 > >> } else { > >> =09 > >> timeout =3D !wait_for_completion_io_timeout(&rsb- > >>=20 > >> complete, > >>=20 > >> =09 msecs_to_jiffies(100)); > >>=20 > >> @@ -296,12 +296,9 @@ static int _sunxi_rsb_run_xfer(struct sunxi_rsb > >> *rsb) > >>=20 > >> if (timeout) { > >> =09 > >> dev_dbg(rsb->dev, "RSB timeout\n"); > >>=20 > >> - /* abort the transfer */ > >> + /* abort the transfer and disable interrupts */ > >>=20 > >> writel(RSB_CTRL_ABORT_TRANS, rsb->regs + RSB_CTRL); > >>=20 > >> - /* clear any interrupt flags */ > >> - writel(readl(rsb->regs + RSB_INTS), rsb->regs +=20 RSB_INTS); > >> - > >>=20 > >> return -ETIMEDOUT; > >> =09 > >> } > >>=20 > >> @@ -503,15 +500,11 @@ EXPORT_SYMBOL_GPL(__devm_regmap_init_sunxi_rsb); > >>=20 > >> static irqreturn_t sunxi_rsb_irq(int irq, void *dev_id) > >> { > >> =20 > >> struct sunxi_rsb *rsb =3D dev_id; > >>=20 > >> - u32 status; > >>=20 > >> - status =3D readl(rsb->regs + RSB_INTS); > >> - rsb->status =3D status; > >> + /* disable interrupts */ > >> + writel(0, rsb->regs + RSB_CTRL); > >>=20 > >> - /* Clear interrupts */ > >> - status &=3D (RSB_INTS_LOAD_BSY | RSB_INTS_TRANS_ERR | > >> - RSB_INTS_TRANS_OVER); > >> - writel(status, rsb->regs + RSB_INTS); > >> + rsb->status =3D readl(rsb->regs + RSB_INTS); > >>=20 > >> complete(&rsb->complete); > >>=20 > >> @@ -532,9 +525,6 @@ static int sunxi_rsb_init_device_mode(struct > >> sunxi_rsb > >> *rsb) if (reg & RSB_DMCR_DEVICE_START) > >>=20 > >> ret =3D -ETIMEDOUT; > >>=20 > >> - /* clear interrupt status bits */ > >> - writel(readl(rsb->regs + RSB_INTS), rsb->regs + RSB_INTS); > >> - > >>=20 > >> return ret; > >> =20 > >> } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72CFFC4332F for ; Tue, 15 Nov 2022 21:40:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z3THYFwCjgpBUhO2nAv+49gSRfnYJU/z1v3Wk4IS40E=; b=jJTUvJg/o8SF6h fuGqxfTqYwDf1C5UHA6SR5MZyn58J95v7g0xPy/aERF0PYvAcQ1hgp6VVHX0u4LQs/N5pyL1Lm8UF 6ZMKDW3O2IW7apb3h4RyCVR+aG5X2Zk5+CWdn5E4jtahie9ZwQkrd1AgaTb5sTg7ZzsVm/FFVR0LG KQGFIesfpOoRGhEFa0ooLjV+xEINleh1+tbPGdrnAmxOu+78P8IhvD7PlSYMztBJBap1zrKe7Pzm+ cJd5ej1XcGx4ov93F7tVwrD1ihgVbu7yo9xYT1m1R2vAamM8Hi/NsNT5jfr2WvXh9GYOIRR3zZot2 cDwWxAGnU+mdhkzeMXZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov3dc-00F5tO-3y; Tue, 15 Nov 2022 21:38:36 +0000 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ov3dY-00F5sE-Sh for linux-arm-kernel@lists.infradead.org; Tue, 15 Nov 2022 21:38:34 +0000 Received: by mail-ed1-x533.google.com with SMTP id l11so23870580edb.4 for ; Tue, 15 Nov 2022 13:38:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=q0qqcluEnKDWuRRDz3pvE3cXQ8iH9uHWt3hqRxoLeo8=; b=gJP6ZkyFtTpF18nmTzBe/C15w/ppBZ0izikt5RYF188kCgQHvCZ5gINPbDmtvBJ1k9 eaDAB3H4huNHELIlrinYLLWWvNTiNJBjjD9ssyMeD0zizbWoprs51Wgw3iGNcjKDvgP7 AxLGnxMxoSIaNzQc+JELR3+hYcODZQ/eKMpDUZfxLCaaPMy9X363aFAhFTBEGS1v31Ce KiLDTWfZTjmlq1hLURSWnykEmfbe374SyJt9XXNI4oXpQQ1H2ZTQMvg4ThYH0i3xQ4km bxFSJjPrrm2ps89EKqD6MyIM8ihjXwM0A8//PwC3lOISKjWi6qMiEAN4vYythSaNaeFh iiBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q0qqcluEnKDWuRRDz3pvE3cXQ8iH9uHWt3hqRxoLeo8=; b=hiWF3KCDSjh9ExoK3fWE3nROnPIOO8Zpv8MPWWaBGj5Bho/HI1BfSM3lgIyWOJAwW9 gaOfGpgqaX4nIoAap/a94+AkTjqEqMqFv1UEFNabKi5LzSPyNVNNIazCcP4eFhtsL8dO iVRvI8+SA2AT1siHPrU/8IWu5IiW8fO3ufA0m2FndbTGbh/Lx65offlhBsRYadXH/I3E 3ZpjAgKtP4XjmX4IBBJW6FalM/hQECippf8NfDzhwfnOKCwOn3Pos3nDPv6WWSMhguBf ALDg7nXQPgk0/TqhA3ROjaIU/Ynh/XdJm3qF2LhW8bVTm022C34zXPhnPCGeqYt/Fpw1 MZJQ== X-Gm-Message-State: ANoB5pmMZT19WLk2XmAjgDNyvhW/7vP4hrHySO7AebQoharDcSz0jU+6 mykSNESaOeeG7dBO8wBSARE= X-Google-Smtp-Source: AA0mqf7+GgVYuxL5xasn4VNMBRz2Sy90Pg6Fu+lL4brjmrxjY5GbT2MB3TR585xiHGp5XW6K6Q+wWw== X-Received: by 2002:a05:6402:360d:b0:461:b033:90ac with SMTP id el13-20020a056402360d00b00461b03390acmr16819244edb.257.1668548311172; Tue, 15 Nov 2022 13:38:31 -0800 (PST) Received: from jernej-laptop.localnet (82-149-19-102.dynamic.telemach.net. [82.149.19.102]) by smtp.gmail.com with ESMTPSA id 7-20020a170906310700b007389c5a45f0sm6082972ejx.148.2022.11.15.13.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 13:38:30 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland Cc: Ivaylo Dimitrov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Andre Przywara Subject: Re: [PATCH v3 3/3] bus: sunxi-rsb: Clear interrupt status before each transfer Date: Tue, 15 Nov 2022 22:38:29 +0100 Message-ID: <1910101.PYKUYFuaPT@jernej-laptop> In-Reply-To: <735349b0-6738-8ace-a7d3-aafae2a62501@sholland.org> References: <20221114015749.28490-1-samuel@sholland.org> <2170633.72vocr9iq0@jernej-laptop> <735349b0-6738-8ace-a7d3-aafae2a62501@sholland.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221115_133832_950970_F9E6B07A X-CRM114-Status: GOOD ( 33.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHRvcmVrLCAxNS4gbm92ZW1iZXIgMjAyMiBvYiAwNzowODoxMiBDRVQgamUgU2FtdWVsIEhv bGxhbmQgbmFwaXNhbChhKToKPiBPbiAxMS8xNC8yMiAxNTowMCwgSmVybmVqIMWga3JhYmVjIHdy b3RlOgo+ID4gSGkgU2FtdWVsLAo+ID4gCj4gPiBEbmUgcG9uZWRlbGplaywgMTQuIG5vdmVtYmVy IDIwMjIgb2IgMDI6NTc6NDkgQ0VUIGplIFNhbXVlbCBIb2xsYW5kCj4gPiAKPiA+IG5hcGlzYWwo YSk6Cj4gPj4gQ3VycmVudGx5LCB0aGUgZHJpdmVyIGNsZWFycyB0aGUgaW50ZXJydXB0IHN0YXR1 cyBiaXRzIGFmdGVyIGFueXRoaW5nCj4gPj4gY291bGQgaGF2ZSBzZXQgdGhlbS4gSG93ZXZlciwg dGhpcyByZXF1aXJlcyBkdXBsaWNhdGluZyB0aGUgc2FtZSBsb2dpYwo+ID4+IGluIHNldmVyYWwg cGxhY2VzLgo+ID4+IAo+ID4+IEluc3RlYWQgb2YgY2xlYXJpbmcgdGhlIHN0YXR1cyBmbGFncyBp biB0aGUgaW50ZXJydXB0IGhhbmRsZXIsIGRpc2FibGUKPiA+PiBhbGwgZnVydGhlciBpbnRlcnJ1 cHRzIGJ5IGNsZWFyaW5nIHRoZSBSU0JfQ1RSTF9HTE9CQUxfSU5UX0VOQiBiaXQuCj4gPiAKPiA+ IHdoZXJlIGlzIHRoaXMgYml0IGNsZWFyZWQ/Cj4gCj4gSXQgaXMgY2xlYXJlZCBieSBhbnkgd3Jp dGUgdG8gUlNCX0NUUkwgdGhhdCBkb2VzIG5vdCBpbmNsdWRlIGl0LiBJIG5vdGVkCj4gaXQgYmVs b3cgd2l0aCB0aGUgImRpc2FibGUgaW50ZXJydXB0cyIgY29tbWVudHMuCgpSaWdodC4KCj4gCj4g Pj4gVGhlbiB3ZSBjYW4gZGVsYXkgdGhlIHN0YXR1cyByZWdpc3RlciB3cml0ZSB1bnRpbCB0aGUg c3RhcnQgb2YgdGhlIG5leHQKPiA+PiB0cmFuc2Zlciwgc28gaXQgb25seSBoYXMgdG8gYmUgZG9u ZSBpbiBvbmUgcGxhY2UuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1ieTogU2FtdWVsIEhvbGxhbmQg PHNhbXVlbEBzaG9sbGFuZC5vcmc+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gQ2hhbmdlcyBpbiB2MzoK PiA+PiAgLSBBZGQgYSBwYXRjaCByZWZhY3RvcmluZyBob3cgdGhlIHN0YXR1cyBiaXRzIGFyZSBj bGVhcmVkCj4gPj4gIAo+ID4+ICBkcml2ZXJzL2J1cy9zdW54aS1yc2IuYyB8IDIwICsrKysrLS0t LS0tLS0tLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDE1IGRl bGV0aW9ucygtKQo+ID4+IAo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2J1cy9zdW54aS1yc2Iu YyBiL2RyaXZlcnMvYnVzL3N1bnhpLXJzYi5jCj4gPj4gaW5kZXggM2FhOTFhZWQzYmY3Li5jYjYy MmU2MDg5N2IgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9idXMvc3VueGktcnNiLmMKPiA+PiAr KysgYi9kcml2ZXJzL2J1cy9zdW54aS1yc2IuYwo+ID4+IEBAIC0yNzksNiArMjc5LDcgQEAgc3Rh dGljIGludCBfc3VueGlfcnNiX3J1bl94ZmVyKHN0cnVjdCBzdW54aV9yc2IgKnJzYikKPiA+PiAK PiA+PiAgCWludF9tYXNrID0gUlNCX0lOVFNfTE9BRF9CU1kgfCBSU0JfSU5UU19UUkFOU19FUlIg fAo+ID4+ICAJUlNCX0lOVFNfVFJBTlNfT1ZFUjsKPiA+PiAgCXdyaXRlbChpbnRfbWFzaywgcnNi LT5yZWdzICsgUlNCX0lOVEUpOwo+ID4+IAo+ID4+ICsJd3JpdGVsKGludF9tYXNrLCByc2ItPnJl Z3MgKyBSU0JfSU5UUyk7Cj4gPiAKPiA+IFdvdWxkbid0IGJlIGJldHRlciB0byBjbGVhciBzdGF0 dXMgYmVmb3JlIGVuYWJsaW5nIGludGVycnVwdHM/IFVubGVzcwo+ID4gZ2xvYmFsIGludGVycnVw dCBmbGFnIGlzIGNsZWFyZWQgYmVmb3JlaGFuZCwgYnV0IEkgZG9uJ3Qgc2VlIHRoYXQKPiA+IGFu eXdoZXJlLgo+IEluZGVlZCB0aGUgaW50ZW50aW9uIHdhcyB0aGF0IHRoZSBnbG9iYWwgaW50ZXJy dXB0IGZsYWcgaXMgY2xlYXJlZAo+IGJlZm9yZWhhbmQsIGFuZCBvbmx5IGVuYWJsZWQgb24gdGhl IG5leHQgbGluZSBiZWxvdy4gSG93ZXZlciwgSSByZWFsaXplCj4gSSBtaXNzZWQgZGlzYWJsaW5n IGl0IGZvciB0aGUgbmV3IGF0b21pYyBjYXNlLgo+IAo+IEknbSBub3Qgc28gc3VyZSBhbnltb3Jl IHRoYXQgdGhpcyBwYXRjaCBpcyBhbiBpbXByb3ZlbWVudC4gV2hhdCBkbyB5b3UKPiB0aGluaz8g SSBjYW4gc2VuZCBhIHY0IHdpdGggYSBmaXgsIG9yIEkgYW0gZmluZSB3aXRoIHNraXBwaW5nIHRo aXMKPiBwYXRjaC4gSSB3b3VsZCBhdCBsZWFzdCBsaWtlIHRoZSBvdGhlciB0d28gdG8gYmUgbWVy Z2VkIGZvciAtZml4ZXMuCgpTdXJlLCBmaXJzdCB0d28gcGF0Y2hlcyB3aWxsIGdvIGluIHJlZ2Fy ZGxlc3MuIEknbSBub3QgY29udmluY2VkIG9mIHZhbHVlIG9mIAp0aGlzIHBhdGNoIGVpdGhlci4g SSBndWVzcyB3ZSBjYW4gc2tpcCBpdC4KCkJlc3QgcmVnYXJkcywKSmVybmVqCgo+IAo+IFJlZ2Fy ZHMsCj4gU2FtdWVsCj4gCj4gPj4gIAl3cml0ZWwoUlNCX0NUUkxfU1RBUlRfVFJBTlMgfCBSU0Jf Q1RSTF9HTE9CQUxfSU5UX0VOQiwKPiA+PiAgCQo+ID4+ICAJICAgICAgIHJzYi0+cmVncyArIFJT Ql9DVFJMKTsKPiA+PiAKPiA+PiBAQCAtMjg2LDcgKzI4Nyw2IEBAIHN0YXRpYyBpbnQgX3N1bnhp X3JzYl9ydW5feGZlcihzdHJ1Y3Qgc3VueGlfcnNiICpyc2IpCj4gPj4gCj4gPj4gIAkJdGltZW91 dCA9IHJlYWRsX3BvbGxfdGltZW91dF9hdG9taWMocnNiLT5yZWdzICsgClJTQl9JTlRTLAo+ID4+ ICAJCQo+ID4+ICAJCQkJCQkgICAgCnN0YXR1cywgKHN0YXR1cyAmIGludF9tYXNrKSwKPiA+PiAg CQkJCQkJICAgIDEwLCAKMTAwMDAwKTsKPiA+PiAKPiA+PiAtCQl3cml0ZWwoc3RhdHVzLCByc2It PnJlZ3MgKyBSU0JfSU5UUyk7Cj4gPj4gCj4gPj4gIAl9IGVsc2Ugewo+ID4+ICAJCj4gPj4gIAkJ dGltZW91dCA9ICF3YWl0X2Zvcl9jb21wbGV0aW9uX2lvX3RpbWVvdXQoJnJzYi0KPiA+PiAKPiA+ PiBjb21wbGV0ZSwKPiA+PiAKPiA+PiAgCQkJCQkJCQogIG1zZWNzX3RvX2ppZmZpZXMoMTAwKSk7 Cj4gPj4gCj4gPj4gQEAgLTI5NiwxMiArMjk2LDkgQEAgc3RhdGljIGludCBfc3VueGlfcnNiX3J1 bl94ZmVyKHN0cnVjdCBzdW54aV9yc2IKPiA+PiAqcnNiKQo+ID4+IAo+ID4+ICAJaWYgKHRpbWVv dXQpIHsKPiA+PiAgCQo+ID4+ICAJCWRldl9kYmcocnNiLT5kZXYsICJSU0IgdGltZW91dFxuIik7 Cj4gPj4gCj4gPj4gLQkJLyogYWJvcnQgdGhlIHRyYW5zZmVyICovCj4gPj4gKwkJLyogYWJvcnQg dGhlIHRyYW5zZmVyIGFuZCBkaXNhYmxlIGludGVycnVwdHMgKi8KPiA+PiAKPiA+PiAgCQl3cml0 ZWwoUlNCX0NUUkxfQUJPUlRfVFJBTlMsIHJzYi0+cmVncyArIFJTQl9DVFJMKTsKPiA+PiAKPiA+ PiAtCQkvKiBjbGVhciBhbnkgaW50ZXJydXB0IGZsYWdzICovCj4gPj4gLQkJd3JpdGVsKHJlYWRs KHJzYi0+cmVncyArIFJTQl9JTlRTKSwgcnNiLT5yZWdzICsgClJTQl9JTlRTKTsKPiA+PiAtCj4g Pj4gCj4gPj4gIAkJcmV0dXJuIC1FVElNRURPVVQ7Cj4gPj4gIAkKPiA+PiAgCX0KPiA+PiAKPiA+ PiBAQCAtNTAzLDE1ICs1MDAsMTEgQEAgRVhQT1JUX1NZTUJPTF9HUEwoX19kZXZtX3JlZ21hcF9p bml0X3N1bnhpX3JzYik7Cj4gPj4gCj4gPj4gIHN0YXRpYyBpcnFyZXR1cm5fdCBzdW54aV9yc2Jf aXJxKGludCBpcnEsIHZvaWQgKmRldl9pZCkKPiA+PiAgewo+ID4+ICAKPiA+PiAgCXN0cnVjdCBz dW54aV9yc2IgKnJzYiA9IGRldl9pZDsKPiA+PiAKPiA+PiAtCXUzMiBzdGF0dXM7Cj4gPj4gCj4g Pj4gLQlzdGF0dXMgPSByZWFkbChyc2ItPnJlZ3MgKyBSU0JfSU5UUyk7Cj4gPj4gLQlyc2ItPnN0 YXR1cyA9IHN0YXR1czsKPiA+PiArCS8qIGRpc2FibGUgaW50ZXJydXB0cyAqLwo+ID4+ICsJd3Jp dGVsKDAsIHJzYi0+cmVncyArIFJTQl9DVFJMKTsKPiA+PiAKPiA+PiAtCS8qIENsZWFyIGludGVy cnVwdHMgKi8KPiA+PiAtCXN0YXR1cyAmPSAoUlNCX0lOVFNfTE9BRF9CU1kgfCBSU0JfSU5UU19U UkFOU19FUlIgfAo+ID4+IC0JCSAgIFJTQl9JTlRTX1RSQU5TX09WRVIpOwo+ID4+IC0Jd3JpdGVs KHN0YXR1cywgcnNiLT5yZWdzICsgUlNCX0lOVFMpOwo+ID4+ICsJcnNiLT5zdGF0dXMgPSByZWFk bChyc2ItPnJlZ3MgKyBSU0JfSU5UUyk7Cj4gPj4gCj4gPj4gIAljb21wbGV0ZSgmcnNiLT5jb21w bGV0ZSk7Cj4gPj4gCj4gPj4gQEAgLTUzMiw5ICs1MjUsNiBAQCBzdGF0aWMgaW50IHN1bnhpX3Jz Yl9pbml0X2RldmljZV9tb2RlKHN0cnVjdAo+ID4+IHN1bnhpX3JzYgo+ID4+ICpyc2IpIGlmIChy ZWcgJiBSU0JfRE1DUl9ERVZJQ0VfU1RBUlQpCj4gPj4gCj4gPj4gIAkJcmV0ID0gLUVUSU1FRE9V VDsKPiA+PiAKPiA+PiAtCS8qIGNsZWFyIGludGVycnVwdCBzdGF0dXMgYml0cyAqLwo+ID4+IC0J d3JpdGVsKHJlYWRsKHJzYi0+cmVncyArIFJTQl9JTlRTKSwgcnNiLT5yZWdzICsgUlNCX0lOVFMp Owo+ID4+IC0KPiA+PiAKPiA+PiAgCXJldHVybiByZXQ7Cj4gPj4gIAo+ID4+ICB9CgoKCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=