From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F38C433E0 for ; Thu, 25 Jun 2020 06:24:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B184206EB for ; Thu, 25 Jun 2020 06:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389989AbgFYGYO convert rfc822-to-8bit (ORCPT ); Thu, 25 Jun 2020 02:24:14 -0400 Received: from lithops.sigma-star.at ([195.201.40.130]:56628 "EHLO lithops.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728725AbgFYGYO (ORCPT ); Thu, 25 Jun 2020 02:24:14 -0400 Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 33A54626F1A9; Thu, 25 Jun 2020 08:24:11 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 5lXw8bOohNOj; Thu, 25 Jun 2020 08:24:09 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 407E1626F1AD; Thu, 25 Jun 2020 08:24:09 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LCL_KQ4g-Hqv; Thu, 25 Jun 2020 08:24:09 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id F0FBE626F1A9; Thu, 25 Jun 2020 08:24:08 +0200 (CEST) Date: Thu, 25 Jun 2020 08:24:08 +0200 (CEST) From: Richard Weinberger To: Kees Cook Cc: Randy Dunlap , Richard Weinberger , Greg Kroah-Hartman , Prasad Sodagudi , Sami Tolvanen , Amit Daniel Kachhap , linux-kselftest , clang-built-linux , linux-kernel Message-ID: <1916262186.58280.1593066248850.JavaMail.zimbra@nod.at> In-Reply-To: <202006242300.145D555@keescook> References: <20200529200347.2464284-1-keescook@chromium.org> <202006241335.2C0FB5DF90@keescook> <10f7c20a-0a32-f5cf-7fdf-761db22afcd9@infradead.org> <03486f13-b138-2fc6-4d90-2737d86add2f@infradead.org> <80f501f4-d4fb-1f22-5603-57b5490a695d@infradead.org> <202006242300.145D555@keescook> Subject: Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF68 (Linux)/8.8.12_GA_3809) Thread-Topic: lkdtm: Various clean ups Thread-Index: nApJhg2/+hA+nTNrNh5Vko39Y8Hygg== Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Kees Cook" > An: "Randy Dunlap" > CC: "Richard Weinberger" , "richard" , "Greg Kroah-Hartman" > , "Prasad Sodagudi" , "Sami Tolvanen" , > "Amit Daniel Kachhap" , "linux-kselftest" , "clang-built-linux" > , "linux-kernel" > Gesendet: Donnerstag, 25. Juni 2020 08:06:18 > Betreff: Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups > On Wed, Jun 24, 2020 at 06:45:47PM -0700, Randy Dunlap wrote: >> Looks like lkdtm/bugs.c needs to get/use arch/x86/include/asm/processor.h >> but it actually uses arch/x86/um/asm/processor*.h, which does not have the >> needed structs etc. > > Should I just test for !UML in bugs.c? (This is all for the > lkdtm_DOUBLE_FAULT() test.) I already do those kinds of checks for the > lkdtm_UNSET_SMEP() test. e.g.: Just had a look. Yes, this sounds good to me. UML has CONFIG_X86_32=y but no GDT. :-) Thanks, //richard