From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan.Bruens@rwth-aachen.de (=?iso-8859-1?Q?Br=FCns=2C_Stefan?=) Date: Mon, 16 Oct 2017 14:21:02 +0000 Subject: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree In-Reply-To: <20171016070217.GO30097@localhost> References: <20170928014928.2272-1-stefan.bruens@rwth-aachen.de> <6277478a-601a-48b0-8e1f-1d309049d4f4@rwthex-w2-a.rwth-ad.de> <20171016070217.GO30097@localhost> Message-ID: <1918888.BSE68NRsHe@sbruens-linux> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote: > On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Br?ns wrote: > > To avoid introduction of a new compatible for each small SoC/DMA > > controller > > variation, move the definition of the channel count to the devicetree. > > > > The number of vchans is no longer explicit, but limited by the highest > > port/DMA request number. The result is a slight overallocation for SoCs > > with a sparse port mapping. > > This doesnt apply for me, please check The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/ vkoul/slave-dma.git/commit/?h=topic/ sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc , which removed the "const struct of_device_id *device;" declaration. > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 7fce976a13d8..b5906da2a975 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -42,6 +42,9 @@ ... > @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match); > static int sun6i_dma_probe(struct platform_device *pdev) > { > const struct of_device_id *device; > + struct device_node *np = pdev->dev.of_node; > struct sun6i_dma_dev *sdc; > struct resource *res; > int ret, i; Can you fix this up, or should I send a new version of this patch? Kind regards, Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Br=FCns=2C_Stefan?= Subject: Re: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree Date: Mon, 16 Oct 2017 14:21:02 +0000 Message-ID: <1918888.BSE68NRsHe@sbruens-linux> References: <20170928014928.2272-1-stefan.bruens@rwth-aachen.de> <6277478a-601a-48b0-8e1f-1d309049d4f4@rwthex-w2-a.rwth-ad.de> <20171016070217.GO30097@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20171016070217.GO30097@localhost> Content-Language: en-US Content-ID: <5F8DD73AABF8AC4D8CCEA2F0D2E7A171-KnNo0XtUZUuELgA04lAiVw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vinod Koul Cc: "linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Chen-Yu Tsai , Andre Przywara , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Dan Williams , Rob Herring , "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Code Kipper , Maxime Ripard , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote: > On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Brüns wrote: > > To avoid introduction of a new compatible for each small SoC/DMA > > controller > > variation, move the definition of the channel count to the devicetree. > > > > The number of vchans is no longer explicit, but limited by the highest > > port/DMA request number. The result is a slight overallocation for SoCs > > with a sparse port mapping. > > This doesnt apply for me, please check The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/ vkoul/slave-dma.git/commit/?h=topic/ sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc , which removed the "const struct of_device_id *device;" declaration. > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 7fce976a13d8..b5906da2a975 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -42,6 +42,9 @@ .. > @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match); > static int sun6i_dma_probe(struct platform_device *pdev) > { > const struct of_device_id *device; > + struct device_node *np = pdev->dev.of_node; > struct sun6i_dma_dev *sdc; > struct resource *res; > int ret, i; Can you fix this up, or should I send a new version of this patch? Kind regards, Stefan -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753055AbdJPOVI convert rfc822-to-8bit (ORCPT ); Mon, 16 Oct 2017 10:21:08 -0400 Received: from mail-out-1.itc.rwth-aachen.de ([134.130.5.46]:25727 "EHLO mail-out-1.itc.rwth-aachen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752196AbdJPOVF (ORCPT ); Mon, 16 Oct 2017 10:21:05 -0400 X-IronPort-AV: E=Sophos;i="5.43,387,1503352800"; d="scan'208";a="18809211" From: =?iso-8859-1?Q?Br=FCns=2C_Stefan?= To: Vinod Koul CC: "linux-sunxi@googlegroups.com" , "devicetree@vger.kernel.org" , Chen-Yu Tsai , Andre Przywara , "linux-kernel@vger.kernel.org" , Dan Williams , Rob Herring , "dmaengine@vger.kernel.org" , Code Kipper , Maxime Ripard , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree Thread-Topic: [PATCH v4 07/11] dmaengine: sun6i: Retrieve channel count/max request from devicetree Thread-Index: AQHTRkxrPePU6MtDWEiiDTCFsvbDR6LmZd0A Date: Mon, 16 Oct 2017 14:21:02 +0000 Message-ID: <1918888.BSE68NRsHe@sbruens-linux> References: <20170928014928.2272-1-stefan.bruens@rwth-aachen.de> <6277478a-601a-48b0-8e1f-1d309049d4f4@rwthex-w2-a.rwth-ad.de> <20171016070217.GO30097@localhost> In-Reply-To: <20171016070217.GO30097@localhost> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [78.35.13.203] Content-Type: text/plain; charset="iso-8859-1" Content-ID: <5F8DD73AABF8AC4D8CCEA2F0D2E7A171@rwth-ad.de> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Montag, 16. Oktober 2017 09:02:17 CEST Vinod Koul wrote: > On Thu, Sep 28, 2017 at 03:49:24AM +0200, Stefan Brüns wrote: > > To avoid introduction of a new compatible for each small SoC/DMA > > controller > > variation, move the definition of the channel count to the devicetree. > > > > The number of vchans is no longer explicit, but limited by the highest > > port/DMA request number. The result is a slight overallocation for SoCs > > with a sparse port mapping. > > This doesnt apply for me, please check The hunk below fails after https://git.kernel.org/pub/scm/linux/kernel/git/ vkoul/slave-dma.git/commit/?h=topic/ sun&id=8f3b00347bf075fb457f90ce76573615f567e7bc , which removed the "const struct of_device_id *device;" declaration. > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c > index 7fce976a13d8..b5906da2a975 100644 > --- a/drivers/dma/sun6i-dma.c > +++ b/drivers/dma/sun6i-dma.c > @@ -42,6 +42,9 @@ .. > @@ -1155,6 +1159,7 @@ MODULE_DEVICE_TABLE(of, sun6i_dma_match); > static int sun6i_dma_probe(struct platform_device *pdev) > { > const struct of_device_id *device; > + struct device_node *np = pdev->dev.of_node; > struct sun6i_dma_dev *sdc; > struct resource *res; > int ret, i; Can you fix this up, or should I send a new version of this patch? Kind regards, Stefan