From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC3F9C2D0A8 for ; Mon, 28 Sep 2020 12:28:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B3AD21531 for ; Mon, 28 Sep 2020 12:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgI1M2A convert rfc822-to-8bit (ORCPT ); Mon, 28 Sep 2020 08:28:00 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3562 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726406AbgI1M2A (ORCPT ); Mon, 28 Sep 2020 08:28:00 -0400 Received: from DGGEMM401-HUB.china.huawei.com (unknown [172.30.72.55]) by Forcepoint Email with ESMTP id 1CB135AB8D6469FA6C12; Mon, 28 Sep 2020 20:27:57 +0800 (CST) Received: from dggema701-chm.china.huawei.com (10.3.20.65) by DGGEMM401-HUB.china.huawei.com (10.3.20.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 28 Sep 2020 20:27:56 +0800 Received: from dggema753-chm.china.huawei.com (10.1.198.195) by dggema701-chm.china.huawei.com (10.3.20.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Mon, 28 Sep 2020 20:27:56 +0800 Received: from dggema753-chm.china.huawei.com ([10.9.48.84]) by dggema753-chm.china.huawei.com ([10.9.48.84]) with mapi id 15.01.1913.007; Mon, 28 Sep 2020 20:27:56 +0800 From: liweihang To: Jason Gunthorpe CC: "dledford@redhat.com" , "leon@kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: Re: [PATCH for-next] RDMA/hns: Remove unused variables and definitions Thread-Topic: [PATCH for-next] RDMA/hns: Remove unused variables and definitions Thread-Index: AQHWlLQdbOCmP0FTx0GazLYtS50Zjw== Date: Mon, 28 Sep 2020 12:27:56 +0000 Message-ID: <191e848eff4840ef80d9fbb0eab064a8@huawei.com> References: <1601200341-7924-1-git-send-email-liweihang@huawei.com> <20200928115547.GL9916@ziepe.ca> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.67.100.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 2020/9/28 19:55, Jason Gunthorpe wrote: > On Sun, Sep 27, 2020 at 05:52:21PM +0800, Weihang Li wrote: >> From: Lang Cheng >> >> Some code was removed but the variables were still there, and some >> parameters have been changed to be queried from firmware. So the >> definitions of them are no longer needed. >> >> Signed-off-by: Lang Cheng >> Signed-off-by: Weihang Li >> --- >> drivers/infiniband/hw/hns/hns_roce_device.h | 8 -------- >> drivers/infiniband/hw/hns/hns_roce_qp.c | 2 -- >> 2 files changed, 10 deletions(-) > > Should have a fixes for the patch that removed the code > > Jason > Hi Jason, Thanks for the comment. But I'm confused about when we should add fixes tag. For example, The only purpose of this patch is to remove redundant macro definitions, the macros to be removed belong to 4 different former patches, so we have to add 4 lines of fixes. It seems difficult to merge this one back to previous versions of kernel. Should I split this patch into 4 patches and add a fixes tag for each one, or just put all these fixes tag in this patch? Thanks Weihang