From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD1F1D60D1B for ; Tue, 19 Nov 2024 10:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cWTYfL2NcNvtJ7hT2DfleWj2jSJLFnsNcjBnW0uewCg=; b=bpce8oKHqcbs5BbgmhYm7u62Z+ GSBLQ2gMUn+74DFiuPOgOUYLF0RvLyp4tlmkVe4O8FQ/ja8lo9dVnwv0Pp+RDVZsNzl+tI65yKJ+5 4etLIj1Je45HvBFhxEh+3cgFM5SKhGFAAuABVbcbTSWnr0yIlT9DEVUv3GZ0FCiiinDEu3SIIGUGo 7lygtelUPcJLmZjInfyhM8RXk7Y3yt6+JMNxuZzWSoU71a6gqMStBLyVxHgB4JhKMTApjtjMdtbov 05DbnZ1JtuTiTtO7Gzr0mQzoV1FQoJjl9FyuPoWCngc/gajVUv9kiVxVWv0xeHYSQC9ToztqqoocI MalYscGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tDLAe-0000000BzVf-3QBy; Tue, 19 Nov 2024 10:09:20 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tDL9i-0000000BzMe-3E1B for linux-arm-kernel@lists.infradead.org; Tue, 19 Nov 2024 10:08:23 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-212583bd467so2747855ad.3 for ; Tue, 19 Nov 2024 02:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732010901; x=1732615701; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cWTYfL2NcNvtJ7hT2DfleWj2jSJLFnsNcjBnW0uewCg=; b=UXJnRUf+IwctLXuLsod/+VfXtla9UtAmI9331WAnhLStX9ONyNaTnT8ImMAkKPXhUd 1SLnPZoTI4x/byTKKZCTGpVD8bTSW3uxnf2aDhFsK7WNjhZuRUMoAtQhtQKquW3ZbiHA pg4CBSrof9B1EX1wN+9+wg/UMkXNNZGqJL/1eB8WWQqavn9bBEFn9dGKQWDajQIwahs6 UJ9KPkM4XdKpUx0ff55qgReGYqqwfRyVi6lk5S2lADLk7js2dvkx8Xc36FvBO7ONGcEA O/LinBOw+LAy/0QY21GFqaMirj82xQxDnPoOXWbbseN2ClnQJox//X+2SdQXnZSH7ecY 9TuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732010901; x=1732615701; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cWTYfL2NcNvtJ7hT2DfleWj2jSJLFnsNcjBnW0uewCg=; b=DeDxifKs/NpOhSp7qe9KlMYLzPUk55CXapaiLYPQIzky3nuG36i65VjGNNTOME69Pk 1cxVB8AhCVoKX8aqRhIZQhWpmHm4oIgDL4E9b5VEIfTsDDt6/OzvpCgWyikpNixMwm6Q ANNGAQEvvr/1gfLmJtwh/zDVUHKBZQrCEyWiACg8Q3IkoAR0Dsy4s4Z1ArUapZZiI1le NnTTSApEVCGVFFp1lsb6eCtHX8xqQN+9NGNsTeLnVxH3BYdg/uPradp1KvVLLEextFCi rsev+czLO+XaNPJrblpIeR9JQWUPW6Vkz7mGeaDOkw29jnlvd9OEDieFRhJ5BP1kTe3+ K7vA== X-Forwarded-Encrypted: i=1; AJvYcCUqgf1OtmpctnnLFJcXGhJsBkO32lLYTUJoufLNhhOqU8VHLHHShwyPRJnGZiNyL+eDpsOGoVoD9tgFUY6r7i1W@lists.infradead.org X-Gm-Message-State: AOJu0YydfvIklpcMGtDZIFjdrD+K2uY5CLZ8doSfdYLjbrh+EMXg/G2x 9tsulipR7wEMwCXYa1AOaF90h6JdJfhzT7vBPAd5DWr/ADAV5Khb X-Google-Smtp-Source: AGHT+IEAjyQGdRHNm7PwkX2khYpceIhQ92EAPL/Ia7j4slTtR5ja4Ryry5i8z7VVQ8n6txgqIQJr+w== X-Received: by 2002:a17:903:1d1:b0:20c:9983:27ae with SMTP id d9443c01a7336-211d0ecdac7mr237798475ad.48.1732010900702; Tue, 19 Nov 2024 02:08:20 -0800 (PST) Received: from [192.168.0.102] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2120ac39585sm41966965ad.261.2024.11.19.02.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 02:08:20 -0800 (PST) Message-ID: <191ebf4b-231d-4ebc-9ff2-4916ef718970@gmail.com> Date: Tue, 19 Nov 2024 18:08:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family To: Andrew Lunn Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mcoquelin.stm32@gmail.com, richardcochran@gmail.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com References: <20241118082707.8504-1-a0987203069@gmail.com> <20241118082707.8504-4-a0987203069@gmail.com> <4d44bc93-6a81-4dc8-9f22-a103882f25e1@lunn.ch> Content-Language: en-US From: Joey Lu In-Reply-To: <4d44bc93-6a81-4dc8-9f22-a103882f25e1@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241119_020822_806383_B9136573 X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andrew Lunn 於 11/19/2024 9:48 AM 寫道: >> + if (of_property_read_u32(dev->of_node, "tx-internal-delay-ps", &arg)) { >> + tx_delay = 0; /* Default value is 0 */ >> + } else { >> + if (arg <= 2000) { >> + tx_delay = (arg == 2000) ? 0xF : (arg / PATH_DELAY_DEC); >> + dev_dbg(dev, "Set Tx path delay to 0x%x\n", tx_delay); > The device tree binding says: > > + tx-internal-delay-ps: > + enum: [0, 2000] > > > So only two values are allowed. Yet the C code is > > arg / PATH_DELAY_DEC > > which seems to allow 16 values? > > Please make this consistent. > > > Andrew Oops. That was my misuse; I will change it to minimum and maximum. Thanks! BR, Joey > > --- > pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0B0FD6C2B6 for ; Tue, 19 Nov 2024 22:49:46 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XtKSH1grTz3cb0 for ; Wed, 20 Nov 2024 09:49:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2607:f8b0:4864:20::62e" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1732010904; cv=none; b=jcPwAdHGJto13Ir73f1Af+1/Q0BhcQuKYimgq5DL+RMyDJOxRo4uDVAN2LMBRQOmQoL1VNSB9YdVz93vIJR2qzFCLiwUMGJtVc+EUFany5PZhyxPO7bXKIqZ6xRLhwhRfbFdt4pbikz6tyaJgZW/8/H2sV8C3sJQRQ1oVCY3L3a7obfZTZWWgq6BMeL10CyvOxt4Lo0K+rgublbA7560c4+CtG2c+hO4XVaTtD2wUrIDeIZiJGsZfkk5GYY0A/sJGREHOdlpkdDsS1FcBcPLcRJeytMMByChvALOFRxtkRMXBS5FI6wkaUzV2ag9mABWrjCYzt4YF2If8fOy7dWsaA== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1732010904; c=relaxed/relaxed; bh=cWTYfL2NcNvtJ7hT2DfleWj2jSJLFnsNcjBnW0uewCg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VIkoGA2uOAkjGCkzSt5PKkml9Q0zhlyaC/tFPFlXsDvgXaWD+IQArfj2OGTZQ3LiJnbUNDT7IhkznKxNuOcAYTr/1LL574QtQOP4i0x7vyrbg008oKktniux9pmEzvmrukXmSgXqgtLaFTBXSHBdUwwKUHg2tjIPBvUdQKb22D7O3aEzA8D2vlY4n3ESw+AlOKeXN1k+rK/3iEOHcd9HeK+M/9hkTB0vMIgB/oUR0e2raU8VXpYXlWrSMpeAVC2I6mDZwT1a+GtLcMMcHdnRCPiE0RRsWPUZiZNfs45zzFdLVlOAC/p5Ns7TA2jQGCvvqvPiESvMj91v4Lz8TtjAxg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=C29N1NRZ; dkim-atps=neutral; spf=pass (client-ip=2607:f8b0:4864:20::62e; helo=mail-pl1-x62e.google.com; envelope-from=a0987203069@gmail.com; receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=C29N1NRZ; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62e; helo=mail-pl1-x62e.google.com; envelope-from=a0987203069@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Xt0Z00lb1z2yMb for ; Tue, 19 Nov 2024 21:08:23 +1100 (AEDT) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-20c9978a221so6659125ad.1 for ; Tue, 19 Nov 2024 02:08:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732010901; x=1732615701; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cWTYfL2NcNvtJ7hT2DfleWj2jSJLFnsNcjBnW0uewCg=; b=C29N1NRZehc8F9J2EMfne9W4UD2tylMxX/B9iT/Uw3IOOaCpDFKNJJaWwLKuUlbnPh K/w+a/HctLl2mvvixD9r5/SJdH4BG1okr5KMFRfkg9MYVTCsY+EvJXRDfc3DxMP0RZNT QtPVRendS3GpX0s3dMVTMgnexC5p1M+W8cDflCsx/pCHBrD971nJuDG7F5fySFhEF5av ONU3OTORZVfMi20WEcZXsUR2/XaOdWINh9M3Azg2GzDaU/z74ZanzgPXGMmX/0oQyhiO c5YXKScyRTObs2I/NX7hAKc8kq2ihPxoePBkiphTPYJqRBOxKA96xo4qvgnH6NklllXX 8iqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732010901; x=1732615701; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cWTYfL2NcNvtJ7hT2DfleWj2jSJLFnsNcjBnW0uewCg=; b=esy4998vu4/FDDztPKEwhRDUJQhlQLHLyYOUdsF3fpnGZGboaPeN6xcZd6wn2yGvBn +H8ydFw+jqFIa+Sx/SgXUNdHMYWG6mNru8HmK8w3o+BT0ebvIeqKzIK78YEWsMpRCkru 8Kp92sByDo7uKmqSYonW3VzfZrv62FoNT3QycjJHQp7JxIz0khCrwlQ3wNMwWfFsjVoZ WBGd+BBdaMGnM5cK06af+2UWW9J5A3tfDhe+sGU7NSIInW3tOCnjtexpmAd+YRlOa569 MAunqZwDUO76CcwMxxEOHdaU8G+lV42WcOY42MeSin5UfpzlF6cStO7NQxQsENOOQtNc K9sA== X-Forwarded-Encrypted: i=1; AJvYcCUpF3USKumbE02IRJB3GT4k3JrviIADDAeZO5HpAozK1BT3ofVuh1sX801Hi0y3xvQpln8kyuaq@lists.ozlabs.org X-Gm-Message-State: AOJu0YyBjuXiwYm7nJAx94buebg+MrKgd+lX595s4+Y8YM/HlUXpzQaZ q97J9rwlZu1kDM7y2smmcZEMV2q8uFrpDkwNeq94glDkMDqEODzV X-Google-Smtp-Source: AGHT+IEAjyQGdRHNm7PwkX2khYpceIhQ92EAPL/Ia7j4slTtR5ja4Ryry5i8z7VVQ8n6txgqIQJr+w== X-Received: by 2002:a17:903:1d1:b0:20c:9983:27ae with SMTP id d9443c01a7336-211d0ecdac7mr237798475ad.48.1732010900702; Tue, 19 Nov 2024 02:08:20 -0800 (PST) Received: from [192.168.0.102] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2120ac39585sm41966965ad.261.2024.11.19.02.08.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Nov 2024 02:08:20 -0800 (PST) Message-ID: <191ebf4b-231d-4ebc-9ff2-4916ef718970@gmail.com> Date: Tue, 19 Nov 2024 18:08:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family To: Andrew Lunn References: <20241118082707.8504-1-a0987203069@gmail.com> <20241118082707.8504-4-a0987203069@gmail.com> <4d44bc93-6a81-4dc8-9f22-a103882f25e1@lunn.ch> Content-Language: en-US From: Joey Lu In-Reply-To: <4d44bc93-6a81-4dc8-9f22-a103882f25e1@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Wed, 20 Nov 2024 09:49:30 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ychuang3@nuvoton.com, edumazet@google.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-stm32@st-md-mailman.stormreply.com, robh@kernel.org, openbmc@lists.ozlabs.org, joabreu@synopsys.com, kuba@kernel.org, pabeni@redhat.com, devicetree@vger.kernel.org, conor+dt@kernel.org, richardcochran@gmail.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch, mcoquelin.stm32@gmail.com, krzk+dt@kernel.org, davem@davemloft.net Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Andrew Lunn 於 11/19/2024 9:48 AM 寫道: >> + if (of_property_read_u32(dev->of_node, "tx-internal-delay-ps", &arg)) { >> + tx_delay = 0; /* Default value is 0 */ >> + } else { >> + if (arg <= 2000) { >> + tx_delay = (arg == 2000) ? 0xF : (arg / PATH_DELAY_DEC); >> + dev_dbg(dev, "Set Tx path delay to 0x%x\n", tx_delay); > The device tree binding says: > > + tx-internal-delay-ps: > + enum: [0, 2000] > > > So only two values are allowed. Yet the C code is > > arg / PATH_DELAY_DEC > > which seems to allow 16 values? > > Please make this consistent. > > > Andrew Oops. That was my misuse; I will change it to minimum and maximum. Thanks! BR, Joey > > --- > pw-bot: cr